request_region return value check

There are many places where the return value from request_region is not checked for null value. This is required right ? I am just checking before I can send patched fixing them

Quoted 3 lines · Vivek Subbarao

There are many places where the return value from request_region is not checked for null value. This is required right ? I am just checking before I can send patched fixing them

Most of the time, but not always.

Sometimes people know it will succeed. The first one I looked at in drivers/acpi/acpi_processor.c the caller doesn't care if it succeeds and there is a comment explaining why.

Quoted 7 lines · Dan Carpenter

Quoted 3 lines · Vivek Subbarao

There are many places where the return value from request_region is not checked for null value. This is required right ? I am just checking before I can send patched fixing them

Most of the time, but not always.

Quoted 4 lines

Sometimes people know it will succeed. The first one I looked at in drivers/acpi/acpi_processor.c the caller doesn't care if it succeeds and there is a comment explaining why.

I see a lot of calls to request_region in __init calls. For example there is a call in netwinder-hw.c:wb977_init. Should they be checking for the return value ?