Skip to contentSkip to conversation

configurable partial slab support on UP

DISCUSSION Uwe Kleine-König 3 participants 3 messages Jul 16, 2013 – Jul 17, 2013

lore
Share & tools
lore
#0 lore raw

Hello,

(sorry for breaking the mail threading, but I failed to find the right mail to reply to.)

while doing make oldconfig on an !SMP config using 3.11-rc1 I was asked if I want CONFIG_SLUB_CPU_PARTIAL. AFAICT this setting only affects SMP machines? If so I suggest to make the choice depend on SMP and treat the !SMP case as CONFIG_SLUB_CPU_PARTIAL=n.

This was introduced in commit
345c905 (slub: Make cpu partial slab support configurable)

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#1 lore raw
Quoted 5 lines · Uwe Kleine-König

Hello,

(sorry for breaking the mail threading, but I failed to find the right mail to reply to.)

Quoted 7 lines

while doing make oldconfig on an !SMP config using 3.11-rc1 I was asked if I want CONFIG_SLUB_CPU_PARTIAL. AFAICT this setting only affects SMP machines? If so I suggest to make the choice depend on SMP and treat the !SMP case as CONFIG_SLUB_CPU_PARTIAL=n.

This was introduced in commit
345c905 (slub: Make cpu partial slab support configurable)

The per-CPU partial list is used on UP machines as well so the config option does affect them. Whether or not they should be used is another topic entirely. Christoph, Joonsoo?

Pekka

#2 lore raw
Quoted 4 lines · Pekka Enberg
Quoted 4 lines

while doing make oldconfig on an !SMP config using 3.11-rc1 I was asked if I want CONFIG_SLUB_CPU_PARTIAL. AFAICT this setting only affects SMP machines? If so I suggest to make the choice depend on SMP and treat the !SMP case as CONFIG_SLUB_CPU_PARTIAL=n.

Sounds ok.

Quoted 7 lines
Quoted 3 lines

This was introduced in commit
345c905 (slub: Make cpu partial slab support configurable)

The per-CPU partial list is used on UP machines as well so the config option does affect them. Whether or not they should be used is another topic entirely. Christoph, Joonsoo?

cpu partial pages are used to avoid contention which does not exist in the UP case. We can simply default to off for UP.