TTY: snyclinkmp: calculating wrong addresses

PATCH New Dan Carpenter 1 participant 1 message Jul 19, 2013

Subsystems (2)

Kernel janitors TTY layer and serial drivers

lore

Share & tools

lore

Dan Carpenter

author

2013-07-19 05:53 UTC #0 lore raw

PATCH 1/1 TTY: snyclinkmp: calculating wrong addresses

This is a static checker fix and I don't have a way to test it. But from the context it looks like this is a typo where SCABUFSIZE was intended instead of sizeof(SCABUFSIZE). SCABUFSIZE is 1024 and sizeof(int) is 4. I would suspect this is a bad bug.

Signed-off-by Dan Carpenter <[email protected]>

drivers/tty/synclinkmp.c +1 -0

index ff17138..dc6e969 100644
@@ -3478,7 +3478,7 @@ static int alloc_buf_list(SLMP_INFO *info)
 	for ( i = 0; i < info->rx_buf_count; i++ ) {
 		/* calculate and store physical address of this buffer entry */
 		info->rx_buf_list_ex[i].phys_entry -			info->buffer_list_phys + (i * sizeof(SCABUFSIZE));
+			info->buffer_list_phys + (i * SCABUFSIZE);
 
 		/* calculate and store physical address of */
 		/* next entry in cirular list of entries */