Skip to contentSkip to conversation

tracing: Kill the unbalanced tr->ref++ in tracing_buffers_open()

PATCH New Oleg Nesterov 1 participant 1 message Jul 19, 2013 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing: Kill the unbalanced tr->ref++ in tracing_buffers_open()

tracing_buffers_open() does trace_array_get() and then it wrongly inrcements tr->ref again under trace_types_lock. This means that every caller leaks trace_array:

	# cd /sys/kernel/debug/tracing/
	# mkdir instances/X
	# true < instances/X/per_cpu/cpu0/trace_pipe_raw
	# rmdir instances/X
	rmdir: failed to remove `instances/X': Device or resource busy
---
 kernel/trace/trace.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/trace/trace.c +0 -2
index ee471fb..278c5f5 100644
@@ -4944,8 +4944,6 @@ static int tracing_buffers_open(struct inode *inode, struct file *filp)
 
 	mutex_lock(&trace_types_lock);
 
-	tr->ref++;
-
 	info->iter.tr		= tr;
 	info->iter.cpu_file	= tc->cpu;
 	info->iter.trace	= tr->current_trace;
Signature · 1 line
1.5.5.1