Skip to contentSkip to conversation

staging:iio:dummy fix kfifo_buf kconfig dependency issue if kfifo modular and buffer enabled for built in dummy driver.

PATCH In review Jonathan Cameron 2 participants 3 messages Sep 1, 2013 – Sep 8, 2013 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

Jonathan Cameron

author maintainer
#1 lore raw

PATCH 1/1 staging:iio:dummy fix kfifo_buf kconfig dependency issue if kfifo modular and buffer enabled for built in dummy driver.

In reply to a message not in the archive

This only occurs in the unlikely event that the example driver is built in whilst the buffer implementation is not.

Solved by switching from a depends on to a select for this particular case.

---
 drivers/staging/iio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/Kconfig +1 -1
index db4d6dc..b36feb0 100644
@@ -37,7 +37,7 @@ config IIO_SIMPLE_DUMMY_EVENTS
 
 config IIO_SIMPLE_DUMMY_BUFFER
        boolean "Buffered capture support"
-       depends on IIO_KFIFO_BUF
+       select IIO_KFIFO_BUF
        help
          Add buffered data capture to the simple dummy driver.
 
Signature · 1 line
1.8.4
Acked-by on v1 1/1
#2 lore raw
Quoted 8 lines · Jonathan Cameron

This only occurs in the unlikely event that the example driver is built in whilst the buffer implementation is not.

Solved by switching from a depends on to a select for this particular case.

Thanks.

Quoted 18 lines
---
 drivers/staging/iio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/Kconfig +1 -1
index db4d6dc..b36feb0 100644
@@ -37,7 +37,7 @@ config IIO_SIMPLE_DUMMY_EVENTS
 
 config IIO_SIMPLE_DUMMY_BUFFER
        boolean "Buffered capture support"
-       depends on IIO_KFIFO_BUF
+       select IIO_KFIFO_BUF
        help
          Add buffered data capture to the simple dummy driver.
 
Signature · 1 line
~Randy
author maintainer Applied
#3 lore raw
Quoted 11 lines · Randy Dunlap
Quoted 8 lines · Jonathan Cameron

This only occurs in the unlikely event that the example driver is built in whilst the buffer implementation is not.

Solved by switching from a depends on to a select for this particular case.

applied to the fixes-togreg branch of iio.git. I'll send this on to Greg once rc1 is out.

Quoted 23 lines

Thanks.

Quoted 18 lines
---
 drivers/staging/iio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/Kconfig +1 -1
index db4d6dc..b36feb0 100644
@@ -37,7 +37,7 @@ config IIO_SIMPLE_DUMMY_EVENTS
 
 config IIO_SIMPLE_DUMMY_BUFFER
        boolean "Buffered capture support"
-       depends on IIO_KFIFO_BUF
+       select IIO_KFIFO_BUF
        help
          Add buffered data capture to the simple dummy driver.