Skip to contentSkip to conversation

userns: Convert xfs to use kuid_t/kgid_t where appropriate

PATCH Superseded Dwight Engen 1 participant 1 message Jul 24, 2013

v5 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

v5 cover userns: Convert xfs to use kuid_t/kgid_t where appropriate

Hi All,

This updated patchset is on top of ad81f054 of xfs git (3.11-rc1). The patches do not convert the id's returned from bulkstat, since bulkstat cannot be called from inside a userns right now anyway since the caller must be CAP_SYS_ADMIN in init_user_ns.

Changes since v4 patchset (addressing Dave's comments):
- add parenthesis in if with binary and logical and (EOFBLOCKS flags)
- rename xfs_fs_eofblocks_to_internal -> xfs_fs_eofblocks_from_user and move conversion validation into it
- fix negative error returns from XFS_IOC_FREE_EOFBLOCKS
- add check for read-only filesystem to XFS_IOC_FREE_EOFBLOCKS

Changes since v3 patchset:
- export inode_capable() for building xfs as a module
- implement Brian's proposal for an internal flag to indicate to xfs_inode_free_eofblocks() that it should do a permission check. ioctl callers will always set this flag, which is simpler than making them specify XFS_EOF_FLAGS_UID or XFS_EOF_FLAGS_GID, internal callers can leave it unset so no permission checking is done
- take Brian's suggestion on moving the policy from the conversion function into the ioctl code, and moving stuff to xfs_icache.h

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs