Skip to contentSkip to conversation

Chen Qi : useradd.bbclass: add a new base class and code refactor

oe-commits Martin Jansa 2 participants 2 messages Aug 15, 2013 – Aug 16, 2013 1 message not in the archive

lore
Share & tools
lore

Martin Jansa

author
#1 lore raw
In reply to a message not in the archive
Quoted 8 lines · On Wed, Jul 24, 2013 at 10:26:48AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 2a57bb7e9a7e154578aa7cb9aeebdf398a54ec00
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=2a57bb7e9a7e154578aa7cb9aeebdf398a54ec00
Author: Chen Qi <[email protected]>
Date:   Fri Jul 19 09:52:25 2013 +0800
Quoted 7 lines

useradd.bbclass: add a new base class and code refactor

Add a new base class, useradd_base.bbclass, which is mainly a collection of basic functions for user/group settings.

The useradd_base.bbclass is intended to be inherited by useradd.bbclass and the extrausers.bbclass to avoid code cuplication.

This code is calling bbwarn in postinst scripts, but only implementation I've found is in logging.bbclass and isn't included in postinst shell code causing:

/tmp/opkg-HtXU0e/dbus-1-Ea0TSc/preinst: 15:
/tmp/opkg-HtXU0e/dbus-1-Ea0TSc/preinst: bbwarn: not found

#2 lore raw
Quoted 14 lines · Martin Jansa
Quoted 13 lines · On Wed, Jul 24, 2013 at 10:26:48AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 2a57bb7e9a7e154578aa7cb9aeebdf398a54ec00
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=2a57bb7e9a7e154578aa7cb9aeebdf398a54ec00
Author: Chen Qi <[email protected]>
Date:   Fri Jul 19 09:52:25 2013 +0800

useradd.bbclass: add a new base class and code refactor

Add a new base class, useradd_base.bbclass, which is mainly a collection of basic functions for user/group settings.

Quoted 8 lines
Quoted 2 lines

The useradd_base.bbclass is intended to be inherited by useradd.bbclass and the extrausers.bbclass to avoid code cuplication.

This code is calling bbwarn in postinst scripts, but only implementation I've found is in logging.bbclass and isn't included in postinst shell code causing:

/tmp/opkg-HtXU0e/dbus-1-Ea0TSc/preinst: 15:
/tmp/opkg-HtXU0e/dbus-1-Ea0TSc/preinst: bbwarn: not found

Hi Martin,

I'm really sorry for this trouble. I didn't notice this when I first made the patch.

I'll send out a patch to fix this.

Thanks for reporting this.

Best Regards,
Chen Qi