Skip to contentSkip to conversation

Muhammad Shakeel : systemd: Remove init. d dir if systemd unit file is present and sysvinit not a distro feature

oe-commits Martin Jansa 2 participants 3 messages Aug 3, 2013 – Aug 4, 2013 1 message not in the archive

lore
Share & tools
lore

Martin Jansa

author
#1 lore raw
In reply to a message not in the archive
Quoted 8 lines · On Wed, Jul 31, 2013 at 05:51:34AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 823c90ad344ca2205f3055e2dcae08c6616f29b7
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=823c90ad344ca2205f3055e2dcae08c6616f29b7
Author: Muhammad Shakeel <[email protected]>
Date:   Mon Jul 29 13:09:51 2013 +0500
Quoted 8 lines

systemd: Remove init.d dir if systemd unit file is present and sysvinit not a distro feature

If systemd is supported DISTRO_FEATURE and sysvinit is not and also if systemd_unitdir contains anything then no need to keep init.d scripts for sysvinit compatibility.

Signed-off-by Muhammad Shakeel <[email protected]>
Signed-off-by Saul Wold <[email protected]>

There is small issue with this patch applied:

do_rootfs failing:
| Collected errors:
| * satisfy_dependencies_for: Cannot satisfy the following dependencies for packagegroup-core-boot:

|  *    busybox-hwclock *
|  * opkg_install_cmd: Cannot install package packagegroup-core-boot.

Systemd images with packagegroup-core-boot RDEPEND on busybox-hwclock:
meta/recipes-core/packagegroups/packagegroup-core-boot.bb:
${@base_contains("MACHINE_FEATURES", "rtc", "busybox-hwclock", "", d)} \

Which is created only when there is /etc/init.d/hwclock.sh file:
FILES_${PN}-hwclock = "${sysconfdir}/init.d/hwclock.sh"

There are at least 3 options
1) ALLOW_EMPTY_${PN}-hwclock = "1"
in busybox.inc
2) add hwclock.service to the same package
3) change packagegroup-core-boot to depend on busybox-hwclock only with sysvinit enabled

I think the best way to resolve this is 2), any volunteer?

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 34 lines · Martin Jansa
Quoted 8 lines · On Wed, Jul 31, 2013 at 05:51:34AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 823c90ad344ca2205f3055e2dcae08c6616f29b7
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=823c90ad344ca2205f3055e2dcae08c6616f29b7
Author: Muhammad Shakeel <[email protected]>
Date:   Mon Jul 29 13:09:51 2013 +0500
Quoted 8 lines

systemd: Remove init.d dir if systemd unit file is present and sysvinit not a distro feature

If systemd is supported DISTRO_FEATURE and sysvinit is not and also if systemd_unitdir contains anything then no need to keep init.d scripts for sysvinit compatibility.

Signed-off-by Muhammad Shakeel <[email protected]>
Signed-off-by Saul Wold <[email protected]>

There is small issue with this patch applied:

do_rootfs failing:
| Collected errors:
| * satisfy_dependencies_for: Cannot satisfy the following dependencies for packagegroup-core-boot:

|  *    busybox-hwclock *
|  * opkg_install_cmd: Cannot install package packagegroup-core-boot.

Systemd images with packagegroup-core-boot RDEPEND on busybox-hwclock:
meta/recipes-core/packagegroups/packagegroup-core-boot.bb:
${@base_contains("MACHINE_FEATURES", "rtc", "busybox-hwclock", "", d)} \

Which is created only when there is /etc/init.d/hwclock.sh file:
FILES_${PN}-hwclock = "${sysconfdir}/init.d/hwclock.sh"

Quoted 9 lines

There are at least 3 options
1) ALLOW_EMPTY_${PN}-hwclock = "1"
in busybox.inc
2) add hwclock.service to the same package
3) change packagegroup-core-boot to depend on busybox-hwclock only with sysvinit enabled

I think the best way to resolve this is 2), any volunteer?

I think my patch from Friday, which I needed to correct the commit message should address this in packagegroup-boot-core, which is #3 on your list.

This was discussed in Bug # 4969 (https://bugzilla.yoctoproject.org/show_bug.cgi?id=4969) and systemd uses timedatectl.

If you have more details or other thoughts, please comment here or on that bug.

Thanks
Sau!

Quoted 7 lines

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#3 lore raw
Quoted 48 lines · Saul Wold
Quoted 34 lines · Martin Jansa
Quoted 8 lines · On Wed, Jul 31, 2013 at 05:51:34AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 823c90ad344ca2205f3055e2dcae08c6616f29b7
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=823c90ad344ca2205f3055e2dcae08c6616f29b7
Author: Muhammad Shakeel <[email protected]>
Date:   Mon Jul 29 13:09:51 2013 +0500
Quoted 8 lines

systemd: Remove init.d dir if systemd unit file is present and sysvinit not a distro feature

If systemd is supported DISTRO_FEATURE and sysvinit is not and also if systemd_unitdir contains anything then no need to keep init.d scripts for sysvinit compatibility.

Signed-off-by Muhammad Shakeel <[email protected]>
Signed-off-by Saul Wold <[email protected]>

There is small issue with this patch applied:

do_rootfs failing:
| Collected errors:
| * satisfy_dependencies_for: Cannot satisfy the following dependencies for packagegroup-core-boot:

|  *    busybox-hwclock *
|  * opkg_install_cmd: Cannot install package packagegroup-core-boot.

Systemd images with packagegroup-core-boot RDEPEND on busybox-hwclock:
meta/recipes-core/packagegroups/packagegroup-core-boot.bb:
${@base_contains("MACHINE_FEATURES", "rtc", "busybox-hwclock", "", d)} \

Which is created only when there is /etc/init.d/hwclock.sh file:
FILES_${PN}-hwclock = "${sysconfdir}/init.d/hwclock.sh"

Quoted 9 lines

There are at least 3 options
1) ALLOW_EMPTY_${PN}-hwclock = "1"
in busybox.inc
2) add hwclock.service to the same package
3) change packagegroup-core-boot to depend on busybox-hwclock only with sysvinit enabled

I think the best way to resolve this is 2), any volunteer?

I think my patch from Friday, which I needed to correct the commit message should address this in packagegroup-boot-core, which is #3 on your list.

Quoted 6 lines

This was discussed in Bug # 4969
(https://bugzilla.yoctoproject.org/show_bug.cgi?id=4969) and systemd uses timedatectl.

If you have more details or other thoughts, please comment here or on that bug.

Works fine with that patch applied, thanks!

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]