Skip to contentSkip to conversation

List of pending patches: what to do?

Buildroot Thomas Petazzoni 11 participants 32 messages Jul 31, 2013 – Aug 19, 2013

lore
Share & tools
lore
#0 lore raw

Hello,

We currently have 228 pending patches in our patchwork at
http://patchwork.ozlabs.org/project/buildroot/list/. Many patches are old and should be adopted to be cleaned up and resubmitted, or maybe need to be rejected but after some community discussion.

In order to help reducing the backlog of patches, I'm pasting below the entire list of patches with their title and direct link to patchwork. What I'm interested in is people replying to this e-mail and giving their opinion about some of the patches (don't try to look at all of them, but at least a few of them). Opinions can be: we should reject, I'm interested in adopting the patch and refreshing it, the patch is interesting but needs this and that to be merged, etc.

Thanks for your help!

http://patchwork.ozlabs.org/patch/155498 New: add lava-test package
http://patchwork.ozlabs.org/patch/164551 [v3] busybox: install S41inetd and inetd.conf if inetd is enabled in busybox.
http://patchwork.ozlabs.org/patch/165382 [1/1] ccache: expose control interface via 'make ccache-options'
http://patchwork.ozlabs.org/patch/165542 [V2] p910nd: Add p910nd lightweight printserver
http://patchwork.ozlabs.org/patch/165674 [RFC,1/2] Add configuration item for custom JavaScript install path
http://patchwork.ozlabs.org/patch/165675 [RFC,2/2] Use JavaScript install path from configuration during package installation
http://patchwork.ozlabs.org/patch/171840 Added package v86d which provides a real-mode helper for uvesafb driver.
http://patchwork.ozlabs.org/patch/172024 Makefile: add variable print capabilities
http://patchwork.ozlabs.org/patch/172171 avahi: only install default.script/S05avahi-setup.sh if not present in fs skeleton
http://patchwork.ozlabs.org/patch/172278 pkg-infra: limit -reconfigure and -rebuild actions
http://patchwork.ozlabs.org/patch/172506 [01/11] libgpg-error: add optional nls support
http://patchwork.ozlabs.org/patch/173191 grub: fix stage2 link with recent binutils
http://patchwork.ozlabs.org/patch/173259 Added local package support.
http://patchwork.ozlabs.org/patch/176795 valgrind: valgrind/valgrind.h missing if --disable-tls enabled
http://patchwork.ozlabs.org/patch/176956 [2/2] rdiff-backup: new package
http://patchwork.ozlabs.org/patch/177618 [1/2,v4] package: pkg-generic: Support building override source without copying in common package infrastructure.
http://patchwork.ozlabs.org/patch/177705 grub: add host support
http://patchwork.ozlabs.org/patch/178526 syslinux: fix host build with newer Linux headers
http://patchwork.ozlabs.org/patch/179493 relative DL_DIR okay?
http://patchwork.ozlabs.org/patch/180241 Add support for the HABA-KNX-LITE
http://patchwork.ozlabs.org/patch/180285 upx: high-performance executable packer with in-place decompression support
http://patchwork.ozlabs.org/patch/180668 Add custom boards support for Atmel SAM-BA software
http://patchwork.ozlabs.org/patch/181185 linux: add default defconfig
http://patchwork.ozlabs.org/patch/181414 adding custom company packages
http://patchwork.ozlabs.org/patch/181503 [3/5] luajit: allow building for the host
http://patchwork.ozlabs.org/patch/181505 [5/5] lua: refactor without useless define's
http://patchwork.ozlabs.org/patch/181716 [1/2] Provide PAM default configuration files when building linux-pam package
http://patchwork.ozlabs.org/patch/181870 [1/9] firefox: host-python dependency needs --enable-unicodedata
http://patchwork.ozlabs.org/patch/181871 [2/9] firefox: valgrind dependency needs --enable-tls for debug build
http://patchwork.ozlabs.org/patch/181874 [3/9] firefox: sqlite dependency needs new compile-time options
http://patchwork.ozlabs.org/patch/181872 [4/9] firefox: installing default extensions needs host-xmlstarlet dependency
http://patchwork.ozlabs.org/patch/181875 [5/9] firefox: installing default extensions needs host-unzip dependency
http://patchwork.ozlabs.org/patch/181877 [6/9] firefox: Mozilla Web Browser
http://patchwork.ozlabs.org/patch/181876 [7/9] firefox: GNU gnash flash plugin needs agg dependency
http://patchwork.ozlabs.org/patch/181873 [8/9] firefox: GNU gnash flash plugin needs gconf dependency
http://patchwork.ozlabs.org/patch/181878 [9/9] firefox: GNU gnash flash, an open source Adobe Flash player & plugin
http://patchwork.ozlabs.org/patch/182233 Depend autotools targets on host-ccache when BR2_CCACHE is enabled.
http://patchwork.ozlabs.org/patch/182497 [1/4] If linux-pam is built, enable dbm functionality in Berkeley DB
http://patchwork.ozlabs.org/patch/182498 [2/4] Make Berkeley DB a dependency of linux-pam and make sure it is selected
http://patchwork.ozlabs.org/patch/182499 [3/4] Provide PAM default configuration files when building linux-pam package
http://patchwork.ozlabs.org/patch/182500 [4/4] PAM support in Busybox if linux-pam is built
http://patchwork.ozlabs.org/patch/182537 Fixing linux-pam build failures
http://patchwork.ozlabs.org/patch/182856 [RFC] patches-from-git.sh: new support script
http://patchwork.ozlabs.org/patch/185420 iucode-tool: new package
http://patchwork.ozlabs.org/patch/185422 Enables thread debugging with full gdb on target
http://patchwork.ozlabs.org/patch/185522 eaccelerator
http://patchwork.ozlabs.org/patch/186837 Add config for PHP eaccelerator package. Signed-off-by: Dallas Clement <[email protected]>
http://patchwork.ozlabs.org/patch/186840 Added build configuration for Network UPS Tools (nut) package. Signed-off-by: Dallas Clement <[email protected]>
http://patchwork.ozlabs.org/patch/187437 [3/3] mplayer: Fix DVD support
http://patchwork.ozlabs.org/patch/187775 pkg-infra: produce legal info for proprietary packages
http://patchwork.ozlabs.org/patch/187776 intel-microcode: new package
http://patchwork.ozlabs.org/patch/188525 Question about 64Bit kernel and 32Bit applications
http://patchwork.ozlabs.org/patch/188623 [1/2] Makefile: Fix target-purgelocales
http://patchwork.ozlabs.org/patch/188624 [2/2] Makefile: Add /usr/lib/locale to target-purgelocales
http://patchwork.ozlabs.org/patch/189336 libglib2: Fix midori save file dialog not being rendered
http://patchwork.ozlabs.org/patch/190922 autoconf version update 2.69 and patch rediff
http://patchwork.ozlabs.org/patch/190962 rpm5
http://patchwork.ozlabs.org/patch/191186 beecrypt: enable OpenMP if Buildroot GCC supports it
http://patchwork.ozlabs.org/patch/191204 putty: UNIX port of the famous Telnet and SSH GUI client
http://patchwork.ozlabs.org/patch/191300 gpsd: add patch to fix CPPFLAGS related build issue
http://patchwork.ozlabs.org/patch/191813 [RFC] grub2: new boot loader
http://patchwork.ozlabs.org/patch/193560 new pkg tor
http://patchwork.ozlabs.org/patch/195057 [PATCHv3] QtSerialPort: new package
http://patchwork.ozlabs.org/patch/195456 matchbox-desktop: Append -ldl to the linker
http://patchwork.ozlabs.org/patch/195476 package: add knxweb
http://patchwork.ozlabs.org/patch/196141 uClibc: install libc.so even if BR2_PREFER_STATIC_LIB is enabled
http://patchwork.ozlabs.org/patch/197028 lua: remove shared library feature
http://patchwork.ozlabs.org/patch/198013 perl: fix build
http://patchwork.ozlabs.org/patch/198127 automake version update 1.12.4
http://patchwork.ozlabs.org/patch/198133 libatomic_ops version update 7.3alpha2 old version 1.2 does not compiles with modern gcc and utils
http://patchwork.ozlabs.org/patch/198234 group file: define groups expected by udev
http://patchwork.ozlabs.org/patch/198555 [v2,5/6] cpanminus: requires host-qemu
http://patchwork.ozlabs.org/patch/198840 [1/1] mesa3d: build with host library with python support
http://patchwork.ozlabs.org/patch/199883 [07/10] libffi: make thread support optional
http://patchwork.ozlabs.org/patch/199891 busybox: needs linux-pam dependency added if using custom busybox .config & busybox login applet
http://patchwork.ozlabs.org/patch/200644 libevent: Add Gentoo patch for C libraries without the sysctl syscall
http://patchwork.ozlabs.org/patch/200889 [04/33] igh-ethercat: disable drivers build with kernel 3.6
http://patchwork.ozlabs.org/patch/200896 [05/33] imagemagick: explicitly disable c++ support if no c++ compiler available
http://patchwork.ozlabs.org/patch/200909 [20/33] pkg-download.mk: add tarball check in the wget method
http://patchwork.ozlabs.org/patch/201313 Passing arguments to the linker when external toolchain is used.
http://patchwork.ozlabs.org/patch/204176 [v2] luajit: complete replacement for lua
http://patchwork.ozlabs.org/patch/204481 Clean kernel when "make linux-clean" is called
http://patchwork.ozlabs.org/patch/204804 flite: new package
http://patchwork.ozlabs.org/patch/204806 libcanfestival: new package
http://patchwork.ozlabs.org/patch/207037 [RESEND,2/2] wpa_supplicant: rework .config file editing
http://patchwork.ozlabs.org/patch/207431 [4/4] gstreamer: replace gst-ffmpeg with gst-libav
http://patchwork.ozlabs.org/patch/207507 [1/2] dbus: bump dbus version from 1.4.24 to current 1.6.8
http://patchwork.ozlabs.org/patch/207508 [2/2] dbus: fix permissions of the installed launch helper
http://patchwork.ozlabs.org/patch/207548 Add a config override file capability.
http://patchwork.ozlabs.org/patch/207717 dtb: provide option to install dtb to boot directory
http://patchwork.ozlabs.org/patch/207827 tokyocabinet: new package
http://patchwork.ozlabs.org/patch/207942 [RFC,1/2] barebox: Build barebox in separate directory.
http://patchwork.ozlabs.org/patch/207943 [RFC,2/2] barebox: Add possibility to build also barebox xloader (MLO).
http://patchwork.ozlabs.org/patch/207947 new package: p7zip
http://patchwork.ozlabs.org/patch/207978 toolchain-external: re-introduce Sourcery CodeBench ARM 2010.09
http://patchwork.ozlabs.org/patch/208152 [v3] usbip: new package
http://patchwork.ozlabs.org/patch/208350 [v2,2/2] rxvt-unicode: new package
http://patchwork.ozlabs.org/patch/208680 [v2] mesa3d: bumped to 8.0.5
http://patchwork.ozlabs.org/patch/208801 [3/8] package/Makefile.in: update/fix HOST_PATH variable
http://patchwork.ozlabs.org/patch/208802 [4/8] package/pkg-cmake.mk: make sure $(HOST_PATH) is in the PATH at configure time
http://patchwork.ozlabs.org/patch/208803 [5/8] dependencies: build a host python2 if no suitable one can be found
http://patchwork.ozlabs.org/patch/208804 [6/8] scons: add host-python2-if-needed dependency
http://patchwork.ozlabs.org/patch/208805 [7/8] scons: ensure $(HOST_DIR)/usr/bin is in the PATH when invoking $(SCONS)
http://patchwork.ozlabs.org/patch/208806 [8/8] manual: add host python2 dependency section
http://patchwork.ozlabs.org/patch/211644 [1/1,v2] Hide issue and hostname menu when using a custom skeleton.
http://patchwork.ozlabs.org/patch/212498 [1/2] new package: python-posix_ipc.
http://patchwork.ozlabs.org/patch/212499 [2/2] new package: python-posix_ipc
http://patchwork.ozlabs.org/patch/212500 [1/1] added python unicode selection to menu
http://patchwork.ozlabs.org/patch/213112 [1/2] makebootfat: new package
http://patchwork.ozlabs.org/patch/213113 [2/2] Basic filesystem image with partition table support
http://patchwork.ozlabs.org/patch/213230 Update dmraid from 1.0.0-rc15 to 1.0.0-rc16-3.
http://patchwork.ozlabs.org/patch/213384 [RFC] Fix avr32 build using internal toolchain
http://patchwork.ozlabs.org/patch/214943 [1/1] Documentation update : add tips to build manual, add information about buildroot toolchain not being relocable and put some hints to use it, move the Beyond Buildroot section before FAQs and add content
http://patchwork.ozlabs.org/patch/215631 Problem using Linux kernel archive from Gitorious
http://patchwork.ozlabs.org/patch/216485 Docu: Add LIBFOO_EXTRACT_CMDS
http://patchwork.ozlabs.org/patch/217204 Linux: enable local Linux tarball in config
http://patchwork.ozlabs.org/patch/217639 minimal dockstar setup
http://patchwork.ozlabs.org/patch/218109 scripts: xorg-release: handle case when version needs downgrade
http://patchwork.ozlabs.org/patch/218928 [v2] configs: at91sam9260eknf: new configuration for Atmel AT91SAM9260-EK
http://patchwork.ozlabs.org/patch/219795 lxc: new package
http://patchwork.ozlabs.org/patch/220024 [1/1] python: fix to ensure libpython is stripped
http://patchwork.ozlabs.org/patch/220542 package: add the duma memory debugging library
http://patchwork.ozlabs.org/patch/220706 [v4,1/5] Python menu reorganization
http://patchwork.ozlabs.org/patch/220707 [v4,2/5] Add python3 config directory simlink
http://patchwork.ozlabs.org/patch/220705 [v4,3/5] Add PYTHON variable to ease the support of both version
http://patchwork.ozlabs.org/patch/220708 [v4,4/5] python-bottle: Convert package to be used with python2 or python3
http://patchwork.ozlabs.org/patch/220709 [v4,5/5] python-serial: Convert package to be used with python2 or python3
http://patchwork.ozlabs.org/patch/220720 Using external toolchain wrapper outside of buildroot
http://patchwork.ozlabs.org/patch/220844 new package: adns
http://patchwork.ozlabs.org/patch/220849 new package: mlocate
http://patchwork.ozlabs.org/patch/221062 xlib_libpthread-stubs: needs -pthread when linking statically
http://patchwork.ozlabs.org/patch/221076 new package: iso-codes
http://patchwork.ozlabs.org/patch/221084 Adding a ModemManager package
http://patchwork.ozlabs.org/patch/222133 [1/1] forward a patch (powerpc) from uClibc 0.9.32.1 to 0.9.33.2
http://patchwork.ozlabs.org/patch/222384 polkit: bump to version 0.104
http://patchwork.ozlabs.org/patch/222743 [v3] Added local directory as soure of kernel code
http://patchwork.ozlabs.org/patch/224477 [Bug,6014] New: Building rootfs stops at copying device table when not using static tables
http://patchwork.ozlabs.org/patch/224479 [2/3] cpanminus: works with arm & mips
http://patchwork.ozlabs.org/patch/224541 [1/1] Updated systemd to version 197
http://patchwork.ozlabs.org/patch/225752 [v3,1/3] lua: remove built dependencies
http://patchwork.ozlabs.org/patch/225754 [v3,2/3] luainterpreter: create virtual package
http://patchwork.ozlabs.org/patch/225753 [v3,3/3] luajit: allow to build Lua extensions without lua
http://patchwork.ozlabs.org/patch/225799 change default location for local.mk to $(CONFIG_DIR)
http://patchwork.ozlabs.org/patch/226374 [4/5] libglib2: fix noMMU build
http://patchwork.ozlabs.org/patch/228809 [3/3] prcpucfg fixes for nspr aarch64
http://patchwork.ozlabs.org/patch/229620 new patch model improvements
http://patchwork.ozlabs.org/patch/230289 [v2] Enable ccache for cmake packages
http://patchwork.ozlabs.org/patch/230733 [4/4] Enable feature CONFIG_FEATURE_PIDFILE so that the syslog initscript actually works
http://patchwork.ozlabs.org/patch/231856 Install DTB as part of images install command
http://patchwork.ozlabs.org/patch/232024 [1/1] manual: add patch revision and versioning section
http://patchwork.ozlabs.org/patch/232077 [1/1] Fix the syslogd initscript pidfile handling - Fix name to pidfile - Enable CONFIG_FEATURE_PIDFILE
http://patchwork.ozlabs.org/patch/233131 pkg-download: take some more care of <PKG_>VERSION when METHOD is git
http://patchwork.ozlabs.org/patch/234527 [2/2] arch: remove support for SuperH 2 and SuperH 3
http://patchwork.ozlabs.org/patch/236409 udev: fix avr32 and microblaze build failures
http://patchwork.ozlabs.org/patch/236467 Extending buildroot functionality for creating board support packages (BSP) out of buildroot tree
http://patchwork.ozlabs.org/patch/236845 Problem with external toolchain sysroot and eclipse
http://patchwork.ozlabs.org/patch/237208 [RFC] BR2_KERNEL_HEADERS_TARGET: Add support for using target kernel for toolchain kernel headers.
http://patchwork.ozlabs.org/patch/237887 package: add toolchain dependency to inner-generic-package
http://patchwork.ozlabs.org/patch/238366 [RFC] permit menu customization
http://patchwork.ozlabs.org/patch/240358 Add package subversion
http://patchwork.ozlabs.org/patch/241102 linux: Fix User-Mode Linux build failures
http://patchwork.ozlabs.org/patch/241250 toolchain/gcc: Introduce BR2_ARCH_HAS_GCC_x_y_PLUS
http://patchwork.ozlabs.org/patch/241511 [1/1] ser2net: add default init script
http://patchwork.ozlabs.org/patch/242998 [1/2] rpi: improve documentation
http://patchwork.ozlabs.org/patch/242999 [2/2] rpi: rename board folder for consistency
http://patchwork.ozlabs.org/patch/243426 Fix bug with dependencies of *-rebuild and *-reconfigure
http://patchwork.ozlabs.org/patch/243427 [v2] Add support for plain URL in $(PKG)_PATCH variable
http://patchwork.ozlabs.org/patch/243442 [1/6] package infra: remove CPPFLAGS from CFLAGS
http://patchwork.ozlabs.org/patch/243445 [4/6] libcurl: bump to version 7.30.0
http://patchwork.ozlabs.org/patch/243649 Using Buildroot tool chain as external Toolchain
http://patchwork.ozlabs.org/patch/243725 Standardisation of $(BUILD)/.root name
http://patchwork.ozlabs.org/patch/244200 [2/3] fs: add uimage support w/ example for cpio
http://patchwork.ozlabs.org/patch/244201 [3/3] zedboard: add Avnet Zedboard support.
http://patchwork.ozlabs.org/patch/244409 [1/1] libtirpc: requires toolchain with threads support
http://patchwork.ozlabs.org/patch/244694 Makefile: Set default emulation for MIPS64/MIPS64el n64
http://patchwork.ozlabs.org/patch/245030 [10/12] luasec: New package
http://patchwork.ozlabs.org/patch/245031 [11/12] luasql: New package
http://patchwork.ozlabs.org/patch/245032 [12/12] orbit: New package
http://patchwork.ozlabs.org/patch/245241 [1/1] skeleton: add default login port to /etc/securetty
http://patchwork.ozlabs.org/patch/245242 [1/1] buildroot: Add POST_RSYNC_HOOKS support
http://patchwork.ozlabs.org/patch/246622 Shared libraries permissions prevent stripping
http://patchwork.ozlabs.org/patch/247051 Makefile: add variable print capabilities
http://patchwork.ozlabs.org/patch/247610 Makefile: defconfig: use BR2_DEFCONFIG only when the file exists
http://patchwork.ozlabs.org/patch/249635 UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot
http://patchwork.ozlabs.org/patch/249721 [PATCHv2] linux: Fix uImage with appended DTs generation
http://patchwork.ozlabs.org/patch/249855 UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot
http://patchwork.ozlabs.org/patch/249912 Makefile: change rsync used in overlays to always transfer files
http://patchwork.ozlabs.org/patch/252718 Unstripped binaries for debugging with gdbserver
http://patchwork.ozlabs.org/patch/253095 [v12,10/11] libav: add new package
http://patchwork.ozlabs.org/patch/253093 [v12,11/11] gst-libav: add libav plugin for gtreamer 1.x
http://patchwork.ozlabs.org/patch/253208 [1/1] "Change package tarball compression to xz"
http://patchwork.ozlabs.org/patch/253944 [1/1] Add package ola (open lighting architecture)
http://patchwork.ozlabs.org/patch/255486 ldconfig - unknown machine 40
http://patchwork.ozlabs.org/patch/255697 dhcpcd: unavailable for bfin and fix another bug
http://patchwork.ozlabs.org/patch/256303 system: only set the root password if it's not empty
http://patchwork.ozlabs.org/patch/256630 [v2] Makefile: Symlink lib32 to lib for MIPS64/n32
http://patchwork.ozlabs.org/patch/256744 tar: avoid ccache chicken and egg problem when bootstrapping tar
http://patchwork.ozlabs.org/patch/256768 system: add config item to set root password or not
http://patchwork.ozlabs.org/patch/257372 [1/3] infra: make possible to run 'make *-menuconfig' from a clean output dir
http://patchwork.ozlabs.org/patch/257374 [2/3] crosstool-ng: remove unneed explicit ccache dependency
http://patchwork.ozlabs.org/patch/257375 [3/3] sstrip: remove unneed explicit ccache dependency
http://patchwork.ozlabs.org/patch/257376 [1/3] qt{4, 5}: add an explicit choice to express Buildroot does not support their coexistence
http://patchwork.ozlabs.org/patch/257377 [2/3] manual: add faq entry explaining why Buildroot does not support Qt{4, 5} coexistence
http://patchwork.ozlabs.org/patch/257378 [3/3] opencv: bump version to 2.4.6
http://patchwork.ozlabs.org/patch/257846 [v2,1/2] linux: install firmware to staging.
http://patchwork.ozlabs.org/patch/257847 [v2,2/2] beagle-capes: new package
http://patchwork.ozlabs.org/patch/257987 Raspberry Pi SD-Card flasher script
http://patchwork.ozlabs.org/patch/258457 gcc: provide an option to enable mudflap support
http://patchwork.ozlabs.org/patch/258467 toolchain-internal: skip gcc-intermediate when possible
http://patchwork.ozlabs.org/patch/258698 Raspberry Pi - WiringPi Library Package
http://patchwork.ozlabs.org/patch/258723 toolchain: Add BR2_TOOLCHAIN_HAS_THREADS_NATIVE
http://patchwork.ozlabs.org/patch/260246 xzcat: treat as host prerequisite and build if needed
http://patchwork.ozlabs.org/patch/260435 [1/3] python-setuptools: bumped version to 0.8
http://patchwork.ozlabs.org/patch/260436 [2/3] python: added hidden openssl option to host python
http://patchwork.ozlabs.org/patch/260437 [3/3] python-pip: new package
http://patchwork.ozlabs.org/patch/261296 [1,of,6,v2] Config.in.legacy: update description
http://patchwork.ozlabs.org/patch/261297 [2,of,6,v2] linux: don't take HEAD as default for git repositories
http://patchwork.ozlabs.org/patch/261298 [3,of,6,v2] linux: add support for custom Mercurial repository
http://patchwork.ozlabs.org/patch/261299 [4,of,6,v2] u-boot: add support for custom Mercurial repository
http://patchwork.ozlabs.org/patch/261300 [5,of,6,v2] linux/uboot: line-up repository-related configuration options
http://patchwork.ozlabs.org/patch/261301 [6,of,6,v2] linux: mention 3.x.y kernels in 'custom version' help
http://patchwork.ozlabs.org/patch/262565 [v2,1/1] Change package tarball compression to xz whenever possible
http://patchwork.ozlabs.org/patch/262692 [v3] <pkg>-rsync: support user custom cmds
http://patchwork.ozlabs.org/patch/262971 directfb-lua: new package
http://patchwork.ozlabs.org/patch/263385 pacakge : add trace-cmd package
http://patchwork.ozlabs.org/patch/263444 toolchain-external: don't create gdb symlink when building host-gdb
http://patchwork.ozlabs.org/patch/263761 [v2] Fix building initramfs kernel with appended dtb
http://patchwork.ozlabs.org/patch/263767 libedit: really needs wchar support

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#1 lore raw
Quoted 9 lines · Thomas Petazzoni

http://patchwork.ozlabs.org/patch/181870 [1/9] firefox: host-python dependency needs --enable-unicodedata
http://patchwork.ozlabs.org/patch/181871 [2/9] firefox: valgrind dependency needs --enable-tls for debug build
http://patchwork.ozlabs.org/patch/181874 [3/9] firefox: sqlite dependency needs new compile-time options
http://patchwork.ozlabs.org/patch/181872 [4/9] firefox: installing default extensions needs host-xmlstarlet dependency
http://patchwork.ozlabs.org/patch/181875 [5/9] firefox: installing default extensions needs host-unzip dependency
http://patchwork.ozlabs.org/patch/181877 [6/9] firefox: Mozilla Web Browser
http://patchwork.ozlabs.org/patch/181876 [7/9] firefox: GNU gnash flash plugin needs agg dependency
http://patchwork.ozlabs.org/patch/181873 [8/9] firefox: GNU gnash flash plugin needs gconf dependency
http://patchwork.ozlabs.org/patch/181878 [9/9] firefox: GNU gnash flash, an open source Adobe Flash player & plugin

I'm proposing to drop those patches. The patches are from September 2012, and I asked Stefan Froberg in May 2013 whether he was still interested
(http://lists.busybox.net/pipermail/buildroot/2013-May/071410.html),
and I've got a private answer that said:

"""
Well, those patches were for Firefox version 11.0 so it's quite old already.

I have a patches for Firefox 16.0 & Firefox 18.0 done but as I understand it Firefox is never
going to be included in buildroot so I did not post them.

And I have now also unsubscripted from mailing list so I can't post them even if
someone would like to check them.

So, yeah. Those patches can be wiped out.

If someone from the list still want's them they can be found from
http://binarytouch.com/patches/
(I will put all the rest of my buildroot patches later there after I have completed my current project)
"""

So unless anyone objects and steps up to refresh and resubmit those patches, I'm proposing to mark those patches as rejected.

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw
In reply to Thomas Petazzoni
Quoted 1 line · Thomas Petazzoni

http://patchwork.ozlabs.org/patch/155498 New: add lava-test package

I managed to get this working with modifications and the python fixes (which are already in the tree).
However from what i've seen it doesn't seem useful for anything by itself, it's a testing framework with the builtins being pretty ubuntu-specific (and requiring a ton of other deps).
Not sure what to do about it, it's not an out-of-the-box experience, it requires extensive tweaking to do anything useful.

Quoted 1 line

http://patchwork.ozlabs.org/patch/165542 [V2] p910nd: Add p910nd lightweight printserver

I'll rebase and give this one a try.

Quoted 1 line

http://patchwork.ozlabs.org/patch/172171 avahi: only install default.script/S05avahi-setup.sh if not present in fs skeleton

I'm generally against initscript conditionals - after all who says it'll have the same sequence number or name in the skeleton? Post-build script IMHO.
Otherwise a global option "don't install initscripts" might fit, however i've been using the script just fine for ages now.

Quoted 1 line

http://patchwork.ozlabs.org/patch/178526 syslinux: fix host build with newer Linux headers

Version bump might be fitting, it's up to 6.01 now.

Quoted 2 lines

http://patchwork.ozlabs.org/patch/185522 eaccelerator
http://patchwork.ozlabs.org/patch/186837 Add config for PHP eaccelerator package. Signed-off-by: Dallas Clement <[email protected]>

Not really an embedded-y package, eaccelerator and similar packages like xcache are basically intermediate opcode caches for the php interpreter/files.
Basically you set aside an X amount of RAM (in the 2-digit MiB range usually) for that and successive hits get a good speed boost because they don't need to be re-interpreted again and again.
This is a feature included in the PHP 5.5.x release, however i doubt we'll be bumping soon to it, 5.4.x is a better fit for now since 5.3.x is getting unsupported status soon.
Widely used for big PHP deployments with many page hits - so i'm hmm about it and eventually it'll go away with PHP 5.5
And it's tied up to PHP 5.3.x so it will block a 5.4.x or 5.5.x update unless we use the main git branch (no release yet, upstream is somewhat dead).

Quoted 1 line

http://patchwork.ozlabs.org/patch/196141 uClibc: install libc.so even if BR2_PREFER_STATIC_LIB is enabled

We should really "mv BR2_PREFER_STATIC_LIB BR2_STATIC_BUILD" or so as you've mentioned before - you either want or don't (want) a static build.

Quoted 1 line

http://patchwork.ozlabs.org/patch/198127 automake version update 1.12.4

for-2013.12 i'll revisit bumping automake, at the moment i'd say no, and since there are newer versions "deferred" or "superseeded" would be appropiate.

Quoted 2 lines

http://patchwork.ozlabs.org/patch/243442 [1/6] package infra: remove CPPFLAGS from CFLAGS
http://patchwork.ozlabs.org/patch/243445 [4/6] libcurl: bump to version 7.30.0

These depend on the generic package cleanups and some autotools package audits (maybe fixes). I've deferred them already, they're on my TODO list and i'll send new appropiate patches when it's done, for-2013.12. libcurl security patches are already in the tree so there's no rush.

Regards.

#2 lore raw
In reply to Thomas Petazzoni

Thomas, All,

On 2013-07-31 19:18 +0200, Thomas Petazzoni spake thusly:

Quoted 11 lines · Thomas Petazzoni
Quoted 9 lines

http://patchwork.ozlabs.org/patch/181870 [1/9] firefox: host-python dependency needs --enable-unicodedata
http://patchwork.ozlabs.org/patch/181871 [2/9] firefox: valgrind dependency needs --enable-tls for debug build
http://patchwork.ozlabs.org/patch/181874 [3/9] firefox: sqlite dependency needs new compile-time options
http://patchwork.ozlabs.org/patch/181872 [4/9] firefox: installing default extensions needs host-xmlstarlet dependency
http://patchwork.ozlabs.org/patch/181875 [5/9] firefox: installing default extensions needs host-unzip dependency
http://patchwork.ozlabs.org/patch/181877 [6/9] firefox: Mozilla Web Browser
http://patchwork.ozlabs.org/patch/181876 [7/9] firefox: GNU gnash flash plugin needs agg dependency
http://patchwork.ozlabs.org/patch/181873 [8/9] firefox: GNU gnash flash plugin needs gconf dependency
http://patchwork.ozlabs.org/patch/181878 [9/9] firefox: GNU gnash flash, an open source Adobe Flash player & plugin

Quoted 1 line

I'm proposing to drop those patches.

Agreed.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#6 lore raw
In reply to Thomas Petazzoni

Hi,

On Wed, Jul 31, 2013 at 7:14 PM, Thomas Petazzoni
<[email protected]> wrote:

Very quick initial run-through:

Quoted 1 line

http://patchwork.ozlabs.org/patch/188525 Question about 64Bit kernel and 32Bit applications

Can be closed, that problem was fixed differently.

Quoted 1 line

http://patchwork.ozlabs.org/patch/201313 Passing arguments to the linker when external toolchain is used.

Can also be closed for the same reason.

Quoted 1 line

http://patchwork.ozlabs.org/patch/207717 dtb: provide option to install dtb to boot directory

At first sight, this feature is already present but with a slightly different implementation. Could you double-check?

Quoted 1 line

http://patchwork.ozlabs.org/patch/231856 Install DTB as part of images install command

Seems to have been acked by several people, can be applied as-is?

Quoted 1 line

http://patchwork.ozlabs.org/patch/241250 toolchain/gcc: Introduce BR2_ARCH_HAS_GCC_x_y_PLUS

Needs to be updated to latest buildroot, but has been acked by Arnout before, after two other iterations.

Quoted 2 lines

http://patchwork.ozlabs.org/patch/249635 UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot
http://patchwork.ozlabs.org/patch/249855 UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot

Former is the old one, can be closed.

Quoted 1 line

http://patchwork.ozlabs.org/patch/256744 tar: avoid ccache chicken and egg problem when bootstrapping tar

I'm going to test this.

Quoted 1 line

http://patchwork.ozlabs.org/patch/260246 xzcat: treat as host prerequisite and build if needed

This is one of mine, feedback would be welcome. I tested it and it works :)

Best regards,
Thomas

#10 lore raw
In reply to Thomas Petazzoni

Thomas, All,

On 2013-07-31 19:14 +0200, Thomas Petazzoni spake thusly:

Quoted 1 line

We currently have 228 pending patches in our patchwork

[--SNIP--]

Quoted 1 line

http://patchwork.ozlabs.org/patch/247051 Makefile: add variable print capabilities

That one I'm sponsoring. It applies with a fuzz of 1, so can get in.

It's usefull to dump the internal variable of Buildroot to check nothing has gone amiss.

I'm having a look at others.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#7 lore raw
In reply to Thomas De Schampheleire

Thomas, All,

On 2013-07-31 22:45 +0200, Thomas De Schampheleire spake thusly:

Quoted 4 lines
Quoted 2 lines

http://patchwork.ozlabs.org/patch/249635 UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot
http://patchwork.ozlabs.org/patch/249855 UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot

Former is the old one, can be closed.

Marked as "superseded", thanks.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#12 lore raw
In reply to Thomas Petazzoni

Hi all,

2013/7/31 Thomas Petazzoni <[email protected]>:

Quoted 2 lines

http://patchwork.ozlabs.org/patch/243426 Fix bug with dependencies of *-rebuild and *-reconfigure
http://patchwork.ozlabs.org/patch/172278 pkg-infra: limit -reconfigure and -rebuild actions

Both treat the same thing!
A "political decision" has to be made on this since it slightly changes the way some BR commands work.

Quoted 1 line

http://patchwork.ozlabs.org/patch/172506 [01/11] libgpg-error: add optional nls support

To be dropped, nobody needs it.

Quoted 1 line

http://patchwork.ozlabs.org/patch/189336 libglib2: Fix midori save file dialog not being rendered

AFAICS, this one is no longer needed.
It fix a glib-2.32 issue, and now we provide the 2.36 version.

Quoted 5 lines

http://patchwork.ozlabs.org/patch/200889 [04/33] igh-ethercat: disable drivers build with kernel 3.6
http://patchwork.ozlabs.org/patch/200896 [05/33] imagemagick: explicitly disable c++ support if no c++ compiler available
http://patchwork.ozlabs.org/patch/200909 [20/33] pkg-download.mk: add tarball check in the wget method
http://patchwork.ozlabs.org/patch/204804 flite: new package
http://patchwork.ozlabs.org/patch/204806 libcanfestival: new package

Still in my stack.
Postponed to the next release.

Quoted 2 lines

http://patchwork.ozlabs.org/patch/208801 [3/8] package/Makefile.in: update/fix HOST_PATH variable
http://patchwork.ozlabs.org/patch/208802 [4/8] package/pkg-cmake.mk: make sure $(HOST_PATH) is in the PATH at configure time

Still in my stack.
Part of some infra cleanup.
Postponed to the next release.

Quoted 4 lines

http://patchwork.ozlabs.org/patch/208803 [5/8] dependencies: build a host python2 if no suitable one can be found
http://patchwork.ozlabs.org/patch/208804 [6/8] scons: add host-python2-if-needed dependency
http://patchwork.ozlabs.org/patch/208805 [7/8] scons: ensure $(HOST_DIR)/usr/bin is in the PATH when invoking $(SCONS)
http://patchwork.ozlabs.org/patch/208806 [8/8] manual: add host python2 dependency section

Still in my stack.
Part of some infra cleanup.
If nobody but me cares about this, then I don't mind dropping them; I'll keep them locally.

Quoted 3 lines

http://patchwork.ozlabs.org/patch/214943 [1/1] Documentation update : add tips to build manual, add information about buildroot toolchain not being relocable and put some hints to use it, move the Beyond Buildroot section before FAQs and add content
http://patchwork.ozlabs.org/patch/216485 Docu: Add LIBFOO_EXTRACT_CMDS
http://patchwork.ozlabs.org/patch/232024 [1/1] manual: add patch revision and versioning section

Doc/manual: need review/respin/rebase imho. Can wait for the next release cycle.

Quoted 2 lines

http://patchwork.ozlabs.org/patch/230289 [v2] Enable ccache for cmake packages
http://patchwork.ozlabs.org/patch/243442 [1/6] package infra: remove CPPFLAGS from CFLAGS

Part of some cleanup I have in my stack and I'd like to do for the next release.

Quoted 1 line

http://patchwork.ozlabs.org/patch/244409 [1/1] libtirpc: requires toolchain with threads support

Fixes autobuilders, and is the v2 of a patch, including comments from the 1st submission.

Quoted 3 lines

http://patchwork.ozlabs.org/patch/182233 Depend autotools targets on host-ccache when BR2_CCACHE is enabled.
http://patchwork.ozlabs.org/patch/256744 tar: avoid ccache chicken and egg problem when bootstrapping tar
http://patchwork.ozlabs.org/patch/257372 [1/3] infra: make possible to run 'make *-menuconfig' from a clean output dir

ccache chicken-egg issue that need to be carefully handled.

Quoted 2 lines

http://patchwork.ozlabs.org/patch/257374 [2/3] crosstool-ng: remove unneed explicit ccache dependency
http://patchwork.ozlabs.org/patch/257375 [3/3] sstrip: remove unneed explicit ccache dependency

Few more ccache cleanups after the previous issue is fixed.

Quoted 3 lines

http://patchwork.ozlabs.org/patch/257376 [1/3] qt{4, 5}: add an explicit choice to express Buildroot does not support their coexistence
http://patchwork.ozlabs.org/patch/257377 [2/3] manual: add faq entry explaining why Buildroot does not support Qt{4, 5} coexistence
http://patchwork.ozlabs.org/patch/257378 [3/3] opencv: bump version to 2.4.6

Still in my stack.
I will rework them during the next release cycle.

Regards,

Signature · 1 line
Samuel
#13 lore raw

Samuel, All,

On 2013-08-01 00:13 +0200, Samuel Martin spake thusly:

Quoted 3 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/189336 libglib2: Fix midori save file dialog not being rendered

AFAICS, this one is no longer needed.
It fix a glib-2.32 issue, and now we provide the 2.36 version.

Marked as superseded, then. Thanks.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#22 lore raw
In reply to Thomas Petazzoni
Quoted 3 lines

http://patchwork.ozlabs.org/patch/172171 avahi: only install default.script/S05avahi-setup.sh if not present in fs skeleton

This issue has already been fixed a different way; patch can be discarded.

http://patchwork.ozlabs.org/patch/179493 relative DL_DIR okay?

Quoted 1 line

This issue has already been fixed a different way; patch can be discarded.

Quoted 3 lines

http://patchwork.ozlabs.org/patch/198234 group file: define groups expected by udev

This patch is still good as-is.

Quoted 3 lines

http://patchwork.ozlabs.org/patch/249912 Makefile: change rsync used in overlays to always transfer files

The patch still applies, with no fuzz but some shifted lines. The problem described still exists, and is still fixed by the patch.

http://patchwork.ozlabs.org/patch/165382 [1/1] ccache: expose control

Quoted 2 lines

interface via 'make ccache-options'

I've no strong objection, but I think that using a Makefile variable to access the ccache binary is cumbersome, as cumbersome as having to export a BUILDROOT_CACHE_DIR to get ccache to point to the right directory.
Mercifully, buildroot avoids forcing us to define environment variables
for regular use - for everything except setting up ccache options, that is.
Because of this, I tend to patch ccache to change the last-ditch cache dir
value from "format("%s/.ccache", home_directory)" to the value set in the .config, which has a much better chance of being correct than $HOME/.ccache, but can still be overridden by exporting BUILDROOT_CACHE_DIR. Then output/host/usr/bin/ccache can be invoked directly to set max-size, stat-clearing, etc. without needing environment variables.

Danomi -
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130731/a8f893b6/attachment.html>

#3 lore raw
In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 10 lines · Yann E. MORIN
Quoted 10 lines
Quoted 9 lines

http://patchwork.ozlabs.org/patch/181870 [1/9] firefox: host-python dependency needs --enable-unicodedata
http://patchwork.ozlabs.org/patch/181871 [2/9] firefox: valgrind dependency needs --enable-tls for debug build
http://patchwork.ozlabs.org/patch/181874 [3/9] firefox: sqlite dependency needs new compile-time options
http://patchwork.ozlabs.org/patch/181872 [4/9] firefox: installing default extensions needs host-xmlstarlet dependency
http://patchwork.ozlabs.org/patch/181875 [5/9] firefox: installing default extensions needs host-unzip dependency
http://patchwork.ozlabs.org/patch/181877 [6/9] firefox: Mozilla Web Browser
http://patchwork.ozlabs.org/patch/181876 [7/9] firefox: GNU gnash flash plugin needs agg dependency
http://patchwork.ozlabs.org/patch/181873 [8/9] firefox: GNU gnash flash plugin needs gconf dependency
http://patchwork.ozlabs.org/patch/181878 [9/9] firefox: GNU gnash flash, an open source Adobe Flash player & plugin

Quoted 3 lines
Quoted 1 line

I'm proposing to drop those patches.

Agreed.

Done, thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#5 lore raw
In reply to Gustavo Zacarias

Dear Gustavo Zacarias,

Quoted 11 lines · Gustavo Zacarias
Quoted 1 line · Thomas Petazzoni

http://patchwork.ozlabs.org/patch/155498 New: add lava-test package

I managed to get this working with modifications and the python fixes (which are already in the tree).
However from what i've seen it doesn't seem useful for anything by itself, it's a testing framework with the builtins being pretty ubuntu-specific (and requiring a ton of other deps).
Not sure what to do about it, it's not an out-of-the-box experience, it requires extensive tweaking to do anything useful.

So I'm proposing to drop this patch. There isn't much interest from the current Buildroot contributors, and the original submitter hasn't pushed the patch forward that much.

Quoted 3 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/165542 [V2] p910nd: Add p910nd lightweight printserver

I'll rebase and give this one a try.

Good, patch delegated to you.

Quoted 7 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/172171 avahi: only install default.script/S05avahi-setup.sh if not present in fs skeleton

I'm generally against initscript conditionals - after all who says it'll have the same sequence number or name in the skeleton? Post-build script IMHO.
Otherwise a global option "don't install initscripts" might fit, however i've been using the script just fine for ages now.

In fact, I realize the patch here is not a patch against Buildroot, it's just a diff I had done between two udhcpc scripts (the one installed by Avahi and the one installed by Busybox), and recently, through commit 0c229f70ea270069e981bfb59e3aea80b21bbcfb, Peter merged the two. So I'll mark this patch as rejected.

Quoted 3 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/178526 syslinux: fix host build with newer Linux headers

Version bump might be fitting, it's up to 6.01 now.

Indeed. So let's keep this patch around as a reminder to do something about syslinux bump.

Quoted 17 lines
Quoted 2 lines

http://patchwork.ozlabs.org/patch/185522 eaccelerator
http://patchwork.ozlabs.org/patch/186837 Add config for PHP eaccelerator package. Signed-off-by: Dallas Clement <[email protected]>

Not really an embedded-y package, eaccelerator and similar packages like xcache are basically intermediate opcode caches for the php interpreter/files.
Basically you set aside an X amount of RAM (in the 2-digit MiB range usually) for that and successive hits get a good speed boost because they don't need to be re-interpreted again and again.
This is a feature included in the PHP 5.5.x release, however i doubt we'll be bumping soon to it, 5.4.x is a better fit for now since 5.3.x is getting unsupported status soon.
Widely used for big PHP deployments with many page hits - so i'm hmm about it and eventually it'll go away with PHP 5.5
And it's tied up to PHP 5.3.x so it will block a 5.4.x or 5.5.x update unless we use the main git branch (no release yet, upstream is somewhat dead).

I marked the first as Superseded. For the second one, I replied to the patch submitter to see if he's still interested.

Quoted 4 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/196141 uClibc: install libc.so even if BR2_PREFER_STATIC_LIB is enabled

We should really "mv BR2_PREFER_STATIC_LIB BR2_STATIC_BUILD" or so as you've mentioned before - you either want or don't (want) a static build.

Agreed. Keeping this around for now until the static lib mess gets fixed. I might be tackling this for 2013.11.

Quoted 5 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/198127 automake version update 1.12.4

for-2013.12 i'll revisit bumping automake, at the moment i'd say no, and since there are newer versions "deferred" or "superseeded" would be appropiate.

Shouldn't we keep it around as a reminder to do something about automake?

Quoted 7 lines
Quoted 2 lines

http://patchwork.ozlabs.org/patch/243442 [1/6] package infra: remove CPPFLAGS from CFLAGS
http://patchwork.ozlabs.org/patch/243445 [4/6] libcurl: bump to version 7.30.0

These depend on the generic package cleanups and some autotools package audits (maybe fixes). I've deferred them already, they're on my TODO list and i'll send new appropiate patches when it's done, for-2013.12. libcurl security patches are already in the tree so there's no rush.

Ok, thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#8 lore raw
In reply to Thomas De Schampheleire

Dear Thomas De Schampheleire,

Quoted 3 lines · Thomas De Schampheleire
Quoted 1 line

http://patchwork.ozlabs.org/patch/188525 Question about 64Bit kernel and 32Bit applications

Can be closed, that problem was fixed differently.

Done.

Quoted 3 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/201313 Passing arguments to the linker when external toolchain is used.

Can also be closed for the same reason.

Done.

Quoted 4 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/207717 dtb: provide option to install dtb to boot directory

At first sight, this feature is already present but with a slightly different implementation. Could you double-check?

Yes, I need to have a look today at several DTB/uImage/initramfs patches against linux.mk, I'll try to have a look at that one.

Quoted 3 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/231856 Install DTB as part of images install command

Seems to have been acked by several people, can be applied as-is?

Agreed.

Quoted 4 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/241250 toolchain/gcc: Introduce BR2_ARCH_HAS_GCC_x_y_PLUS

Needs to be updated to latest buildroot, but has been acked by Arnout before, after two other iterations.

I'd be inclined to post-pone that for 2013.11, but I can merge it as soon as -next opens.

Quoted 4 lines
Quoted 2 lines

http://patchwork.ozlabs.org/patch/249635 UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot
http://patchwork.ozlabs.org/patch/249855 UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot

Former is the old one, can be closed.

Apparently someone marked 249635 as superseded in the mean time.

Quoted 3 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/256744 tar: avoid ccache chicken and egg problem when bootstrapping tar

I'm going to test this.

Ok.

Quoted 3 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/260246 xzcat: treat as host prerequisite and build if needed

This is one of mine, feedback would be welcome. I tested it and it works :)

The only part I'm not entirely happy with is:

- DL_TOOLS="$(sort $(DL_TOOLS_DEPENDENCIES))" \
+ DL_TOOLS="$(sort $(filter-out $(XZCAT),$(DL_TOOLS_DEPENDENCIES)))" \

This looks like very special-case filtering. It sounds odd to add xzcat to DL_TOOLS_DEPENDENCIES to later remove it when DL_TOOLS_DEPENDENCIES is used. I think I'd prefer something along the lines of (but it'd be great if a temporary variable could be used for the $(firstword ...) thing) :

package/pkg-generic.mk +4 -0
index b8eaa98..435a1c6 100644
@@ -539,7 +539,11 @@ else ifeq ($$($(2)_SITE_METHOD),hg)
 DL_TOOLS_DEPENDENCIES += hg
 endif # SITE_METHOD
 
+# Do not add xzcat to the list of required dependencies, as it gets
+# built automatically if it isn't found.
+ifneq ($(firstword $(INFLATE$(suffix $($(2)_SOURCE)))),$(XZCAT))
 DL_TOOLS_DEPENDENCIES += $(firstword $(INFLATE$(suffix $($(2)_SOURCE))))
+endif
 
 endif # $(2)_KCONFIG_VAR
 endef # inner-generic-package

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#11 lore raw
In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 8 lines · Yann E. MORIN

Thomas, All,

On 2013-07-31 19:14 +0200, Thomas Petazzoni spake thusly:

Quoted 1 line

We currently have 228 pending patches in our patchwork

[--SNIP--]

Quoted 1 line

http://patchwork.ozlabs.org/patch/247051 Makefile: add variable print capabilities

That one I'm sponsoring. It applies with a fuzz of 1, so can get in.

Ok, applied, thanks.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#23 lore raw
In reply to Danomi Manchego

Dear Danomi Manchego,

Quoted 5 lines · Danomi Manchego
Quoted 3 lines

http://patchwork.ozlabs.org/patch/172171 avahi: only install default.script/S05avahi-setup.sh if not present in fs skeleton

This issue has already been fixed a different way; patch can be discarded.

Yep, I've done as part as Gustavo review of the patches.

Quoted 3 lines

http://patchwork.ozlabs.org/patch/179493 relative DL_DIR okay?

This issue has already been fixed a different way; patch can be discarded.

Ok, thanks.

Quoted 4 lines
Quoted 2 lines

http://patchwork.ozlabs.org/patch/198234 group file: define groups expected by udev

This patch is still good as-is.

Patch applied.

Quoted 5 lines
Quoted 2 lines

http://patchwork.ozlabs.org/patch/249912 Makefile: change rsync used in overlays to always transfer files

The patch still applies, with no fuzz but some shifted lines. The problem described still exists, and is still fixed by the patch.

It looks good, but I'd like to have someone ACK or test the patch. Yann, Gustavo, Arnout?

Quoted 5 lines

http://patchwork.ozlabs.org/patch/165382 [1/1] ccache: expose control

Quoted 1 line

interface via 'make ccache-options'

I've no strong objection, but I think that using a Makefile variable to access the ccache binary is cumbersome

Agreed.

Quoted 11 lines

, as cumbersome as having to export
a BUILDROOT_CACHE_DIR to get ccache to point to the right directory.
Mercifully, buildroot avoids forcing us to define environment variables
for regular use - for everything except setting up ccache options, that is.
Because of this, I tend to patch ccache to change the last-ditch cache dir
value from "format("%s/.ccache", home_directory)" to the value set in the .config, which has a much better chance of being correct than $HOME/.ccache, but can still be overridden by exporting BUILDROOT_CACHE_DIR. Then output/host/usr/bin/ccache can be invoked directly to set max-size, stat-clearing, etc. without needing environment variables.

So the problem is that one cannot simply do

  $(O)/host/usr/bin/ccache --max-size=5G

because the BUILDROOT_CACHE_DIR is passed as an environment variable, and defined by the Buildroot Makefile, so if you want to interact manually with ccache, you'd have to manually pass BUILDROOT_CACHE_DIR.

This explains why the patch was proposing this CACHE_OPTIONS idea, I guess. I don't have much other ideas here, though.

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#25 lore raw
In reply to Thomas Petazzoni
Quoted 2 lines · Thomas Petazzoni

http://patchwork.ozlabs.org/patch/165674 [RFC,1/2] Add configuration item for custom JavaScript install path
http://patchwork.ozlabs.org/patch/165675 [RFC,2/2] Use JavaScript install path from configuration during package installation

These can be discarded now, as I have no intention of working on them further.

Quoted 1 line

http://patchwork.ozlabs.org/patch/213384 [RFC] Fix avr32 build using internal toolchain

No longer relevant, as uClibc 0.9.31 support has now been removed from Buildroot. Can be discarded.

Quoted 1 line

http://patchwork.ozlabs.org/patch/236409 udev: fix avr32 and microblaze build failures

I haven't noticed any avr32/microblaze udev autobuild failures for a while... I suggest that this patch be discarded.

Quoted 1 line

http://patchwork.ozlabs.org/patch/238366 [RFC] permit menu customization

This doesn't adequately solve the problem that it sets out to solve; can be discarded. (Although I do think this is still an area in which Buildroot could be improved.)

Simon.

#26 lore raw

Dear Simon Dawson,

Quoted 6 lines · Simon Dawson
Quoted 2 lines · Thomas Petazzoni

http://patchwork.ozlabs.org/patch/165674 [RFC,1/2] Add configuration item for custom JavaScript install path
http://patchwork.ozlabs.org/patch/165675 [RFC,2/2] Use JavaScript install path from configuration during package installation

These can be discarded now, as I have no intention of working on them further.

Thanks, done.

Quoted 4 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/213384 [RFC] Fix avr32 build using internal toolchain

No longer relevant, as uClibc 0.9.31 support has now been removed from Buildroot. Can be discarded.

Done.

Quoted 4 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/236409 udev: fix avr32 and microblaze build failures

I haven't noticed any avr32/microblaze udev autobuild failures for a while... I suggest that this patch be discarded.

Most likely we have upgraded the avr32 and microblaze toolchains since then, and that's why we're not seeing the issues anymore. I've discarded the patch.

Quoted 5 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/238366 [RFC] permit menu customization

This doesn't adequately solve the problem that it sets out to solve; can be discarded. (Although I do think this is still an area in which Buildroot could be improved.)

I agree it's an area in which Buildroot could be improved. I've dropped the patch for now, as you suggested.

Thanks for this review!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#27 lore raw
In reply to Thomas Petazzoni

Hello,

Thanks to all the people who participated to this thread.

Quoted 2 lines · Thomas Petazzoni

We currently have 228 pending patches in our patchwork at
http://patchwork.ozlabs.org/project/buildroot/list/. Many patches are

As of now, we're down to 198 patches. Do not hesitate to continue to comment on patches, or adopt some of them. Even though I'll release -rc1 tomorrow, I'll continue to take 'invasive' patches since I'll open -next immediately after -rc1 opens.

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#14 lore raw
In reply to Samuel Martin

Dear Samuel Martin,

Quoted 7 lines · Samuel Martin

2013/7/31 Thomas Petazzoni <[email protected]>:

Quoted 2 lines

http://patchwork.ozlabs.org/patch/243426 Fix bug with dependencies of *-rebuild and *-reconfigure
http://patchwork.ozlabs.org/patch/172278 pkg-infra: limit -reconfigure and -rebuild actions

Both treat the same thing!
A "political decision" has to be made on this since it slightly changes the way some BR commands work.

Can we have a decision on those ones?

On my side, I kind of like the fact that 'make blabla-rebuild' both rebuilds the blabla package and regenerates the root filesystem. It avoids the need for 'make blabla-rebuild && make'. However, it's true that it's inconsistent with 'make blabla-dirclean', which just removes the build directory, and therefore requires a 'make blabla-dirclean && make' if you want to completely rebuild a package from scratch.

Quoted 2 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/172506 [01/11] libgpg-error: add optional nls support

To be dropped, nobody needs it.

Done.

Quoted 7 lines
Quoted 5 lines

http://patchwork.ozlabs.org/patch/200889 [04/33] igh-ethercat: disable drivers build with kernel 3.6
http://patchwork.ozlabs.org/patch/200896 [05/33] imagemagick: explicitly disable c++ support if no c++ compiler available
http://patchwork.ozlabs.org/patch/200909 [20/33] pkg-download.mk: add tarball check in the wget method
http://patchwork.ozlabs.org/patch/204804 flite: new package
http://patchwork.ozlabs.org/patch/204806 libcanfestival: new package

Still in my stack.
Postponed to the next release.

Does this mean I can mark them as 'Deferred' in patchwork, trusting you to resubmit them later? Or should I keep them around in patchwork just to remind us (you and the community) that they need to be finalized and merged?

Quoted 5 lines
Quoted 2 lines

http://patchwork.ozlabs.org/patch/208801 [3/8] package/Makefile.in: update/fix HOST_PATH variable
http://patchwork.ozlabs.org/patch/208802 [4/8] package/pkg-cmake.mk: make sure $(HOST_PATH) is in the PATH at configure time

Still in my stack.
Part of some infra cleanup.
Postponed to the next release.

Same question as above.

Quoted 9 lines
Quoted 5 lines

http://patchwork.ozlabs.org/patch/208803 [5/8] dependencies: build a host python2 if no suitable one can be found
http://patchwork.ozlabs.org/patch/208804 [6/8] scons: add host-python2-if-needed dependency
http://patchwork.ozlabs.org/patch/208805 [7/8] scons: ensure $(HOST_DIR)/usr/bin is in the PATH when invoking $(SCONS)
http://patchwork.ozlabs.org/patch/208806 [8/8] manual: add host python2 dependency section

Still in my stack.
Part of some infra cleanup.
If nobody but me cares about this, then I don't mind dropping them; I'll keep them locally.

Same question as above.

Quoted 4 lines
Quoted 3 lines

http://patchwork.ozlabs.org/patch/214943 [1/1] Documentation update : add tips to build manual, add information about buildroot toolchain not being relocable and put some hints to use it, move the Beyond Buildroot section before FAQs and add content
http://patchwork.ozlabs.org/patch/216485 Docu: Add LIBFOO_EXTRACT_CMDS
http://patchwork.ozlabs.org/patch/232024 [1/1] manual: add patch revision and versioning section

Doc/manual: need review/respin/rebase imho. Can wait for the next release cycle.

Documentation stuff can be merged after -rc1, so it'd be great to clean that up now and get it merged during the -rc cycle.

Quoted 3 lines
Quoted 2 lines

http://patchwork.ozlabs.org/patch/230289 [v2] Enable ccache for cmake packages
http://patchwork.ozlabs.org/patch/243442 [1/6] package infra: remove CPPFLAGS from CFLAGS

Part of some cleanup I have in my stack and I'd like to do for the next release.

Same question as above (should I mark as Deferred or keep in patchwork as a reminder).

Quoted 3 lines
Quoted 1 line

http://patchwork.ozlabs.org/patch/244409 [1/1] libtirpc: requires toolchain with threads support

Fixes autobuilders, and is the v2 of a patch, including comments from the 1st submission.

Ah, yes, I didn't like the fact of adding a thread dependency to libtirpc, but I think I should like it. This is really a bug fix, so can always be merged after -rc1 is released.

Quoted 8 lines
Quoted 3 lines

http://patchwork.ozlabs.org/patch/182233 Depend autotools targets on host-ccache when BR2_CCACHE is enabled.
http://patchwork.ozlabs.org/patch/256744 tar: avoid ccache chicken and egg problem when bootstrapping tar
http://patchwork.ozlabs.org/patch/257372 [1/3] infra: make possible to run 'make *-menuconfig' from a clean output dir

ccache chicken-egg issue that need to be carefully handled.

Quoted 2 lines

http://patchwork.ozlabs.org/patch/257374 [2/3] crosstool-ng: remove unneed explicit ccache dependency
http://patchwork.ozlabs.org/patch/257375 [3/3] sstrip: remove unneed explicit ccache dependency

Few more ccache cleanups after the previous issue is fixed.

Discussion started with Thomas De Schampheleire today about this.

Quoted 5 lines
Quoted 3 lines

http://patchwork.ozlabs.org/patch/257376 [1/3] qt{4, 5}: add an explicit choice to express Buildroot does not support their coexistence
http://patchwork.ozlabs.org/patch/257377 [2/3] manual: add faq entry explaining why Buildroot does not support Qt{4, 5} coexistence
http://patchwork.ozlabs.org/patch/257378 [3/3] opencv: bump version to 2.4.6

Still in my stack.
I will rework them during the next release cycle.

Same question as above. I'm not sure a FAQ entry is a good choice, maybe a

comment "qt5 is not available when qt4 is selected"
depends on BR2_PACKAGE_QT

comment "qt4 is not available when qt5 is selected"
depend son BR2_PACKAGE_QT5

is probably a better idea.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Reviewed-by
#24 lore raw
In reply to Thomas Petazzoni

Thomas, Danomi, All,

On 2013-08-01 08:13 +0200, Thomas Petazzoni spake thusly:

Quoted 9 lines · Danomi Manchego
Quoted 5 lines
Quoted 2 lines

http://patchwork.ozlabs.org/patch/249912 Makefile: change rsync used in overlays to always transfer files

The patch still applies, with no fuzz but some shifted lines. The problem described still exists, and is still fixed by the patch.

It looks good, but I'd like to have someone ACK or test the patch. Yann, Gustavo, Arnout?

I've looked at it, and it indeed seems to be a needed and beneficial change. I can't think of unexpected adverse side-effect, so I'd recommend we get it in, but probably in -next just to be extra safe.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#9 lore raw
In reply to Thomas Petazzoni

Thomas, All,

On 2013-08-01 07:59 +0200, Thomas Petazzoni spake thusly:

Quoted 7 lines · Thomas De Schampheleire
Quoted 4 lines
Quoted 2 lines

http://patchwork.ozlabs.org/patch/249635 UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot
http://patchwork.ozlabs.org/patch/249855 UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot

Former is the old one, can be closed.

Apparently someone marked 249635 as superseded in the mean time.

That would be me, but as I had email issues since around midnight (GMT+2) yesterday, up until late in the afternoon today [*], so my mail probably stayed in limbo and was not delivered before you looked at the patchwork.

That about 5 other millions french internet users had the same issue as me is of little comfort. :-(

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#15 lore raw
In reply to Thomas Petazzoni

Thomas, all,

2013/8/1 Thomas Petazzoni <[email protected]>:

Quoted 12 lines

Dear Samuel Martin,

Quoted 7 lines · Samuel Martin

2013/7/31 Thomas Petazzoni <[email protected]>:

Quoted 2 lines

http://patchwork.ozlabs.org/patch/243426 Fix bug with dependencies of *-rebuild and *-reconfigure
http://patchwork.ozlabs.org/patch/172278 pkg-infra: limit -reconfigure and -rebuild actions

Both treat the same thing!
A "political decision" has to be made on this since it slightly changes the way some BR commands work.

Quoted 8 lines

Can we have a decision on those ones?

On my side, I kind of like the fact that 'make blabla-rebuild' both rebuilds the blabla package and regenerates the root filesystem. It avoids the need for 'make blabla-rebuild && make'. However, it's true that it's inconsistent with 'make blabla-dirclean', which just removes the build directory, and therefore requires a 'make blabla-dirclean && make' if you want to completely rebuild a package from scratch.

IIRC, we talked about this during some BR dev days or patchwork-day session, and in the end we kept statu quo.

I'd rather be in favor of these patches, although I barely use the *-re{configure,build} targets;
anyway it's just one opinion among others.

Quoted 12 lines
Quoted 3 lines
Quoted 2 lines

http://patchwork.ozlabs.org/patch/172506 [01/11] libgpg-error: add optional nls support

To be dropped, nobody needs it.

Done.

Quoted 5 lines
Quoted 5 lines

http://patchwork.ozlabs.org/patch/200889 [04/33] igh-ethercat: disable drivers build with kernel 3.6
http://patchwork.ozlabs.org/patch/200896 [05/33] imagemagick: explicitly disable c++ support if no c++ compiler available
http://patchwork.ozlabs.org/patch/200909 [20/33] pkg-download.mk: add tarball check in the wget method
http://patchwork.ozlabs.org/patch/204804 flite: new package
http://patchwork.ozlabs.org/patch/204806 libcanfestival: new package

Quoted 7 lines
Quoted 2 lines

Still in my stack.
Postponed to the next release.

Does this mean I can mark them as 'Deferred' in patchwork, trusting you to resubmit them later? Or should I keep them around in patchwork just to remind us (you and the community) that they need to be finalized and merged?

Yes, I've just marked them as deferred.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

http://patchwork.ozlabs.org/patch/208801 [3/8] package/Makefile.in: update/fix HOST_PATH variable
http://patchwork.ozlabs.org/patch/208802 [4/8] package/pkg-cmake.mk: make sure $(HOST_PATH) is in the PATH at configure time

Still in my stack.
Part of some infra cleanup.
Postponed to the next release.

Same question as above.

done

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

http://patchwork.ozlabs.org/patch/208803 [5/8] dependencies: build a host python2 if no suitable one can be found
http://patchwork.ozlabs.org/patch/208804 [6/8] scons: add host-python2-if-needed dependency
http://patchwork.ozlabs.org/patch/208805 [7/8] scons: ensure $(HOST_DIR)/usr/bin is in the PATH when invoking $(SCONS)
http://patchwork.ozlabs.org/patch/208806 [8/8] manual: add host python2 dependency section

Quoted 6 lines
Quoted 4 lines

Still in my stack.
Part of some infra cleanup.
If nobody but me cares about this, then I don't mind dropping them; I'll keep them locally.

Same question as above.

done

Quoted 8 lines
Quoted 5 lines
Quoted 4 lines

http://patchwork.ozlabs.org/patch/214943 [1/1] Documentation update : add tips to build manual, add information about buildroot toolchain not being relocable and put some hints to use it, move the Beyond Buildroot section before FAQs and add content
http://patchwork.ozlabs.org/patch/216485 Docu: Add LIBFOO_EXTRACT_CMDS
http://patchwork.ozlabs.org/patch/232024 [1/1] manual: add patch revision and versioning section

Doc/manual: need review/respin/rebase imho. Can wait for the next release cycle.

Documentation stuff can be merged after -rc1, so it'd be great to clean that up now and get it merged during the -rc cycle.

Yes, I'll try to look at these patches shortly.

Quoted 7 lines
Quoted 4 lines
Quoted 3 lines

http://patchwork.ozlabs.org/patch/230289 [v2] Enable ccache for cmake packages
http://patchwork.ozlabs.org/patch/243442 [1/6] package infra: remove CPPFLAGS from CFLAGS

Part of some cleanup I have in my stack and I'd like to do for the next release.

Same question as above (should I mark as Deferred or keep in patchwork as a reminder).

Yes, please. Thomas, could you do it, I cannot since they are not mine.

Quoted 12 lines
Quoted 4 lines
Quoted 2 lines

http://patchwork.ozlabs.org/patch/244409 [1/1] libtirpc: requires toolchain with threads support

Fixes autobuilders, and is the v2 of a patch, including comments from the 1st submission.

Ah, yes, I didn't like the fact of adding a thread dependency to libtirpc, but I think I should like it. This is really a bug fix, so can always be merged after -rc1 is released.

Quoted 3 lines
Quoted 3 lines

http://patchwork.ozlabs.org/patch/182233 Depend autotools targets on host-ccache when BR2_CCACHE is enabled.
http://patchwork.ozlabs.org/patch/256744 tar: avoid ccache chicken and egg problem when bootstrapping tar
http://patchwork.ozlabs.org/patch/257372 [1/3] infra: make possible to run 'make *-menuconfig' from a clean output dir

Quoted 7 lines
Quoted 5 lines

ccache chicken-egg issue that need to be carefully handled.

Quoted 2 lines

http://patchwork.ozlabs.org/patch/257374 [2/3] crosstool-ng: remove unneed explicit ccache dependency
http://patchwork.ozlabs.org/patch/257375 [3/3] sstrip: remove unneed explicit ccache dependency

Few more ccache cleanups after the previous issue is fixed.

Discussion started with Thomas De Schampheleire today about this.

Indeed, I follow the discussion but cannot be more involved right now.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

http://patchwork.ozlabs.org/patch/257376 [1/3] qt{4, 5}: add an explicit choice to express Buildroot does not support their coexistence
http://patchwork.ozlabs.org/patch/257377 [2/3] manual: add faq entry explaining why Buildroot does not support Qt{4, 5} coexistence
http://patchwork.ozlabs.org/patch/257378 [3/3] opencv: bump version to 2.4.6

Still in my stack.
I will rework them during the next release cycle.

Same question as above.

done

Quoted 10 lines

I'm not sure a FAQ entry is a good choice,
maybe a

comment "qt5 is not available when qt4 is selected"
depends on BR2_PACKAGE_QT

comment "qt4 is not available when qt5 is selected"
depend son BR2_PACKAGE_QT5

is probably a better idea.

Fair enough, I'll integrate this change when I'll respin this series. Thx,

Regards,

Signature · 1 line
Samuel
#28 lore raw
In reply to Thomas Petazzoni

Hi,

On 2013-07-31 19:14, Thomas Petazzoni wrote:
[...]

Quoted 1 line

http://patchwork.ozlabs.org/patch/219795 lxc: new package

Not intrusive and works for me. Let's see if autobuilder throw anything.

[...]

Quoted 2 lines

http://patchwork.ozlabs.org/patch/243426 Fix bug with dependencies of *-rebuild and *-reconfigure

There is another discussion thread about this patch (I am also in favor of its integration).

Quoted 2 lines

http://patchwork.ozlabs.org/patch/243427 [v2] Add support for plain URL in $(PKG)_PATCH variable

Hmmm... reviewed by Yann and Markos. Could be merged, isn't?

[...]

Quoted 2 lines

http://patchwork.ozlabs.org/patch/243725 Standardisation of $(BUILD)/.root name

I have to send a last update of this patch

Signature · 3 lines
J?r?me Pouiller, Sysmic
Embedded Linux specialist
http://www.sysmic.fr
#16 lore raw
In reply to Samuel Martin
Quoted 24 lines · Samuel Martin

Thomas, all,

2013/8/1 Thomas Petazzoni <[email protected]>:

Quoted 12 lines

Dear Samuel Martin,

Quoted 7 lines · Samuel Martin

2013/7/31 Thomas Petazzoni <[email protected]>:

Quoted 2 lines

http://patchwork.ozlabs.org/patch/243426 Fix bug with dependencies of *-rebuild and *-reconfigure
http://patchwork.ozlabs.org/patch/172278 pkg-infra: limit -reconfigure and -rebuild actions

Both treat the same thing!
A "political decision" has to be made on this since it slightly changes the way some BR commands work.

Quoted 8 lines

Can we have a decision on those ones?

On my side, I kind of like the fact that 'make blabla-rebuild' both rebuilds the blabla package and regenerates the root filesystem. It avoids the need for 'make blabla-rebuild && make'. However, it's true that it's inconsistent with 'make blabla-dirclean', which just removes the build directory, and therefore requires a 'make blabla-dirclean && make' if you want to completely rebuild a package from scratch.

Quoted 7 lines

IIRC, we talked about this during some BR dev days or patchwork-day session, and in the end we kept statu quo.

I'd rather be in favor of these patches, although I barely use the *-re{configure,build} targets;
anyway it's just one opinion among others.

I am currently used to -reconfigure and -rebuild to rebuild also the rootfs, but I also agree it's inconsistent with the other targets. If we want to be strict, then foo-reconfigure can only configure, not build. And foo-rebuild can only build.
Hence, to get the original behavior of:
foo-reconfigure --> foo-reconfigure all
foo-rebuild --> foo-rebuild all

Is that understanding correct?
As long as we can document this properly, also in the ChangeLog, then I'm fine with this semantic change. Adding 'all' isn't the end of the world.

Best regards,
Thomas

#17 lore raw

Dear Thomas De Schampheleire,

Quoted 4 lines · Thomas De Schampheleire

I am currently used to -reconfigure and -rebuild to rebuild also the rootfs, but I also agree it's inconsistent with the other targets. If we want to be strict, then foo-reconfigure can only configure, not build. And foo-rebuild can only build.

Yerk, that's a bit ugly. foo-reconfigure removes the configure, build stamp files as well as the host, staging, images and target install stamp files. foo-rebuild does the same, except for the configure stamp file.

So, I would find it strange if foo-reconfigure only did the configure again and not the entire package build process. Same for foo-rebuild.

Remember, the use case for those is someone who is actively working on the source code of a package (mainly when using the OVERRIDE_SRCDIR thing or the local site method) and wants to be able to restart the build of the package, just as if he was running 'make && make install' in his package source code.

So the intention is really to have 'make foo-rebuild' do that 'make && make install' for the user, for the package <foo>.

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#18 lore raw
Quoted 17 lines · Thomas Petazzoni

Dear Thomas De Schampheleire,

Quoted 4 lines · Thomas De Schampheleire

I am currently used to -reconfigure and -rebuild to rebuild also the rootfs, but I also agree it's inconsistent with the other targets. If we want to be strict, then foo-reconfigure can only configure, not build. And foo-rebuild can only build.

Yerk, that's a bit ugly. foo-reconfigure removes the configure, build stamp files as well as the host, staging, images and target install stamp files. foo-rebuild does the same, except for the configure stamp file.

So, I would find it strange if foo-reconfigure only did the configure again and not the entire package build process. Same for foo-rebuild.

Quoted 8 lines

Remember, the use case for those is someone who is actively working on the source code of a package (mainly when using the OVERRIDE_SRCDIR thing or the local site method) and wants to be able to restart the build of the package, just as if he was running 'make && make install' in his package source code.

So the intention is really to have 'make foo-rebuild' do that 'make && make install' for the user, for the package <foo>.

As said, I don't have a problem with the existing reconfigure-does-it-all approach.
I may have misunderstood the objections of others: there is no objection against reconfigure doing also rebuild, only that reconfigure and rebuild also make the rootfs?

#19 lore raw

Dear Thomas De Schampheleire,

Quoted 8 lines · Thomas De Schampheleire
Quoted 2 lines

So the intention is really to have 'make foo-rebuild' do that 'make && make install' for the user, for the package <foo>.

As said, I don't have a problem with the existing reconfigure-does-it-all approach.
I may have misunderstood the objections of others: there is no objection against reconfigure doing also rebuild, only that reconfigure and rebuild also make the rootfs?

That's my understanding of what the objections are, yes.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#20 lore raw
Quoted 7 lines · Thomas Petazzoni

Dear Thomas De Schampheleire,

Quoted 3 lines · Thomas De Schampheleire
Quoted 2 lines

So the intention is really to have 'make foo-rebuild' do that 'make && make install' for the user, for the package <foo>.

Quoted 7 lines
Quoted 5 lines

As said, I don't have a problem with the existing reconfigure-does-it-all approach.
I may have misunderstood the objections of others: there is no objection against reconfigure doing also rebuild, only that reconfigure and rebuild also make the rootfs?

That's my understanding of what the objections are, yes.

Ok, in this case I'm fine with changing the situation to handle the objections, so that if you want to make the rootfs, you explicitly have to call the 'all' target.

This 'translation table' to mimic the old behavior is still correct, right:
foo-reconfigure --> foo-reconfigure all
foo-rebuild --> foo-rebuild all

Best regards,
Thomas

#29 lore raw
In reply to Thomas Petazzoni

Hi,

Quoted 1 line · Thomas Petazzoni

http://patchwork.ozlabs.org/patch/220720 Using external toolchain wrapper outside of buildroot

Fixed with another commit (74ae7af927)

Patrick

Signature · 15 lines
Dipl.-Inf. (FH) Patrick Ziegler

University Of Applied Sciences
Kaiserslautern

Amerikastrasse 1
D-66482 Zweibruecken
Germany

Phone:  +49 631 3724 5526
Mail:   patrick.ziegler at fh-kl.de
PGP KeyID 0xB4796B8C

http://www.fh-kl.de
http://www.fh-kl.de/fachbereiche/imst/iuk-knowhow.html
#30 lore raw

Dear Patrick Ziegler,

Quoted 5 lines · Patrick Ziegler
Quoted 1 line · Thomas Petazzoni

http://patchwork.ozlabs.org/patch/220720 Using external toolchain wrapper outside of buildroot

Fixed with another commit (74ae7af927)

Thanks, marked as Superseded!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#21 lore raw
In reply to Thomas De Schampheleire
Quoted 25 lines · Thomas De Schampheleire
Quoted 24 lines · Samuel Martin

Thomas, all,

2013/8/1 Thomas Petazzoni <[email protected]>:

Quoted 20 lines

Dear Samuel Martin,

Quoted 7 lines · Samuel Martin

2013/7/31 Thomas Petazzoni <[email protected]>:

Quoted 2 lines

http://patchwork.ozlabs.org/patch/243426 Fix bug with dependencies of *-rebuild and *-reconfigure
http://patchwork.ozlabs.org/patch/172278 pkg-infra: limit -reconfigure and -rebuild actions

Both treat the same thing!
A "political decision" has to be made on this since it slightly changes the way some BR commands work.

Can we have a decision on those ones?

On my side, I kind of like the fact that 'make blabla-rebuild' both rebuilds the blabla package and regenerates the root filesystem. It avoids the need for 'make blabla-rebuild && make'. However, it's true that it's inconsistent with 'make blabla-dirclean', which just removes the build directory, and therefore requires a 'make blabla-dirclean && make' if you want to completely rebuild a package from scratch.

Quoted 5 lines
Quoted 5 lines

IIRC, we talked about this during some BR dev days or patchwork-day session, and in the end we kept statu quo.

I'd rather be in favor of these patches, although I barely use the *-re{configure,build} targets;

I also don't use them because they're not convenient :-) I typically use

make foo-clean-for-rebuild foo

so for me the patch would be really convenient (except that I typically use several buildroot versions in parallel so I'll forget if I can use the -rebuild target or not).

Quoted 11 lines
Quoted 2 lines

anyway it's just one opinion among others.

I am currently used to -reconfigure and -rebuild to rebuild also the rootfs, but I also agree it's inconsistent with the other targets. If we want to be strict, then foo-reconfigure can only configure, not build. And foo-rebuild can only build.
Hence, to get the original behavior of:
foo-reconfigure --> foo-reconfigure all
foo-rebuild --> foo-rebuild all

Quoted 4 lines

Is that understanding correct?
As long as we can document this properly, also in the ChangeLog, then I'm fine with this semantic change. Adding 'all' isn't the end of the world.

BTW the report of the last developer meeting [1] says that we were
going to accept these patches.

Regards,
Arnout

[1] http://elinux.org/Buildroot:DeveloperDaysFOSDEM2013#Action_point_list

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#31 lore raw
In reply to Thomas Petazzoni

Thomas,

Quoted 16 lines · Thomas Petazzoni

Hello,

We currently have 228 pending patches in our patchwork at
http://patchwork.ozlabs.org/project/buildroot/list/. Many patches are old and should be adopted to be cleaned up and resubmitted, or maybe need to be rejected but after some community discussion.

In order to help reducing the backlog of patches, I'm pasting below the entire list of patches with their title and direct link to patchwork. What I'm interested in is people replying to this e-mail and giving their opinion about some of the patches (don't try to look at all of them, but at least a few of them). Opinions can be: we should reject, I'm interested in adopting the patch and refreshing it, the patch is interesting but needs this and that to be merged, etc.

Thanks for your help!

...

Quoted 1 line

http://patchwork.ozlabs.org/patch/230289 [v2] Enable ccache for cmake packages

This led to a fairly long discussion with Samuel, you and me on howit should be implemented.You suggested it should be done in the toolchain wrappers. Thedetails were not clear to me, but it was definitely nothing similar to this patch.

So probably it should be dropped from patchwork.

Note: the discussion is not fully visible in patchwork, see it here:
http://lists.busybox.net/pipermail/buildroot/2013-March/068306.html

FWIW, I'm not even using that patch. Instead I'm using the v1
(http://lists.busybox.net/pipermail/buildroot/2013-March/068306.html)
which added a stupid shell wrapper around TARGET_CC/_CXX. It's probably not very nice but it's simple and it just works.

Luca