Skip to contentSkip to conversation

pktcdvd: add struct pktcdvd_device.name to pr_err logging where possible

DISCUSSION Dan Carpenter 1 participant 1 message Aug 1, 2013 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hello Joe Perches,

This is a semi-automatic email about new static checker warnings.

The patch b5a0e979a657: "pktcdvd: add struct pktcdvd_device.name to pr_err logging where possible" from Aug 1, 2013, leads to the following Smatch complaint:

drivers/block/pktcdvd.c:2363 pkt_make_request()
error: we previously assumed 'pd' could be null (see line 2362)

drivers/block/pktcdvd.c
2361 pd = q->queuedata;

  2362		if (!pd) {
                    ^^^
Old check.
  2363			pkt_err(pd, "%s incorrect request queue\n",
                                ^^^

New dereference.
2364 bdevname(bio->bi_bdev, b));
2365 goto end_io;

regards,
dan carpenter