turbostat: Don't attempt to printf an off_t with %zx
PATCH 1/1 turbostat: Don't attempt to printf an off_t with %zx
turbostat uses the format %zx to print an off_t. However, %zx wants a size_t, not an off_t. On 32-bit targets, those refer to different types, potentially even with different sizes. Use %llx and a cast instead, since printf does not have a length modifier for off_t.
Without this patch, when compiling for a 32-bit target:
turbostat.c: In function 'get_msr':
turbostat.c:231:3: warning: format '%zx' expects argument of type 'size_t', but argument 4 has type 'off_t' [-Wformat]
Signed-off-by Josh Triplett <[email protected]>
--- tools/power/x86/turbostat/turbostat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/power/x86/turbostat/turbostat.c +1 -1
@@ -230,7 +230,7 @@ int get_msr(int cpu, off_t offset, unsigned long long *msr)close (fd);if (retval !=sizeof *msr) { -fprintf (stderr,"%s offset 0x%zx read failed\n" , pathname, offset); +fprintf (stderr,"%s offset 0x%llx read failed\n" , pathname, (unsigned long long )offset);return -1 ; }
Signature · 1 line
1.8.4.rc1