coredump: Add new %P variable in core_pattern
Subsystems (2)
PATCH RESEND 1/1 coredump: Add new %P variable in core_pattern
This adds a new %P variable to be used in core_pattern. This variable contains the global PID (PID in the init namespace) as %p contains the PID in the current namespace which isn't always what we want.
The main use for this is to make it easier to handle crashes that happened within a container. With that new variables it's possible to have the crashes dumped into the container or forwarded to the host with the right PID (from the host's point of view).
--- Documentation/sysctl/kernel.txt | 1 + fs/coredump.c | 5 +++++ 2 files changed, 6 insertions(+)
Documentation/sysctl/kernel.txt +1 -0
@@ -182,6 +182,7 @@ core_pattern is used to specify a core dumpfile pattern name. %<NUL> '%' is dropped %% output one '%' %p pid + %P global pid (init PID namespace) %u uid %g gid %d dump mode, matches PR_SET_DUMPABLE and
fs/coredump.c +5 -0
@@ -186,6 +186,11 @@ static int format_corename(struct core_name *cn, struct coredump_params *cprm) err =cn_printf (cn,"%d" ,task_tgid_vnr (current));break ; +/* global pid */ +case 'P' : + err =cn_printf (cn,"%d" , +task_tgid_nr (current)); +break ;/* uid */ case 'u' : err =cn_printf (cn,"%d" , cred->uid);
Signature · 1 line
1.8.1.2
Thanks Stéphane. There were no objections last time this was posted, right? Hopefully it can be applied this time.
-serge
Quoted 52 lines · Stéphane Graber
This adds a new %P variable to be used in
core_pattern. This variable contains the global PID (PID in the init namespace) as %p contains the PID in the current namespace which isn't always what we want.The main use for this is to make it easier to handle crashes that happened within a container. With that new variables it's possible to have the crashes dumped into the container or forwarded to the host with the right PID (from the host's point of view).
Reported-by Hans Feldt <[email protected]>Cc Alexander Viro <[email protected]>Cc Eric W. Biederman <[email protected]>Cc Andy Whitcroft <[email protected]>Acked-by Serge E. Hallyn <[email protected]>Signed-off-by Stéphane Graber <[email protected]>--- Documentation/sysctl/kernel.txt | 1 + fs/coredump.c | 5 +++++ 2 files changed, 6 insertions(+)Documentation/sysctl/kernel.txt +1
-0@@ -182,6 +182,7 @@ core_pattern is used to specify a core dumpfile pattern name. %<NUL> '%' is dropped %% output one '%' %p pid + %P global pid (init PID namespace) %u uid %g gid %d dump mode, matches PR_SET_DUMPABLE andfs/coredump.c +5
-0@@ -186,6 +186,11 @@ static int format_corename(struct core_name *cn, struct coredump_params *cprm) err =cn_printf (cn,"%d" ,task_tgid_vnr (current));break ; +/* global pid */ +case 'P' : + err =cn_printf (cn,"%d" , +task_tgid_nr (current)); +break ;/* uid */ case 'u' : err =cn_printf (cn,"%d" , cred->uid);Signature · 1 line
1.8.1.2