snd_tea575x: precedence bug in fmr2_tea575x_get_pins()

PATCH New Dan Carpenter 1 participant 1 message Aug 22, 2013

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2013-08-22 17:07 UTC #0 lore raw

PATCH 1/1 snd_tea575x: precedence bug in fmr2_tea575x_get_pins()

The "|" operation has higher precedence that "?:" so this couldn't return both flags set at once as intended.

Signed-off-by Dan Carpenter <[email protected]>

---
Static checker stuff. Untested.

drivers/media/radio/radio-sf16fmr2.c +2 -2

index 9c09904..72af59d 100644
@@ -74,8 +74,8 @@ static u8 fmr2_tea575x_get_pins(struct snd_tea575x *tea)
 	struct fmr2 *fmr2 = tea->private_data;
 	u8 bits = inb(fmr2->io);
 
-	return  (bits & STR_DATA) ? TEA575X_DATA : 0 |
-		(bits & STR_MOST) ? TEA575X_MOST : 0;
+	return  ((bits & STR_DATA) ? TEA575X_DATA : 0) |
+		((bits & STR_MOST) ? TEA575X_MOST : 0);
 }
 
 static void fmr2_tea575x_set_direction(struct snd_tea575x *tea, bool output)