Skip to contentSkip to conversation

mtd: ndfc: silence an underflow static checker warning

PATCH Dan Carpenter 1 participant 1 message Aug 23, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

"cs" is an index into the ndfc_ctrl[]. There is a sanity check which does:

	if (cs >= NDFC_MAX_CS) {

It doesn't check for underflows and that upsets my static checker.

drivers/mtd/nand/ndfc.c +2 -1
index 8e148f1..cd78b81 100644
@@ -201,8 +201,9 @@ static int ndfc_probe(struct platform_device *ofdev)
 {
 	struct ndfc_controller *ndfc;
 	const __be32 *reg;
+	unsigned int cs;
 	u32 ccr;
-	int err, len, cs;
+	int err, len;
 
 	/* Read the reg property to get the chip select */
 	reg = of_get_property(ofdev->dev.of_node, "reg", &len);