Skip to contentSkip to conversation

drm/prime: double lock typo

PATCH In review Dan Carpenter 2 participants 2 messages Aug 23, 2013

Subsystems (3)
DRM drivers DRM misc Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/prime: double lock typo

There is a typo so deadlocks on error instead of unlocking.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/drm_prime.c +1 -1
index 7ae2bfc..276d470 100644
@@ -552,7 +552,7 @@ fail:
 	 */
 	drm_gem_handle_delete(file_priv, *handle);
 out_unlock:
-	mutex_lock(&dev->object_name_lock);
+	mutex_unlock(&dev->object_name_lock);
 out_put:
 	dma_buf_put(dma_buf);
 	mutex_unlock(&file_priv->prime.lock);
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Dan Carpenter

There is a typo so deadlocks on error instead of unlocking.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/drm_prime.c +0 -0
index 7ae2bfc..276d470 100644

drivers/gpu/drm/drm_prime.c fail: · line 555

Quoted 5 lines
drivers/gpu/drm/drm_prime.c +1 -1
@@ -552,7 +552,7 @@ fail:
 	 */
 	drm_gem_handle_delete(file_priv, *handle);
 out_unlock:
-	mutex_lock(&dev->object_name_lock);
+	mutex_unlock(&dev->object_name_lock);

Duh. Unfortunately exercising error paths is pretty hard :( So thanks for catching this.

Reviewed-by Daniel Vetter <[email protected]>
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch