Skip to contentSkip to conversation

pinctrl: mvebu: testing the wrong variable

PATCH In review Dan Carpenter 3 participants 3 messages Aug 26, 2013 – Aug 28, 2013

Subsystems (3)
Kernel janitors Pin control Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 pinctrl: mvebu: testing the wrong variable

We wanted to test "*map" here instead of "map".

Signed-off-by Dan Carpenter <[email protected]>
drivers/pinctrl/mvebu/pinctrl-mvebu.c +1 -1
index bb7ddb1..ad43359 100644
@@ -430,7 +430,7 @@ static int mvebu_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
 	}
 
 	*map = kmalloc(nmaps * sizeof(struct pinctrl_map), GFP_KERNEL);
-	if (map = NULL) {
+	if (*map = NULL) {
 		dev_err(pctl->dev,
 			"cannot allocate pinctrl_map memory for %s\n",
 			np->name);