Skip to contentSkip to conversation

add exFAT driver

PATCH In review Benjamin Valentin 8 participants 23 messages Aug 30, 2013 – Sep 26, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add exFAT driver

Samsung released their exFAT (and FAT12/16/32) driver under the GPLv2, it is based on the in-kernel FAT driver and can be obtained from [1]. This patch adds version 1.2.4 of the exfat driver, sans the ifdefs for older kernel versions and ported to Linux 3.11.

[1] http://opensource.samsung.com search for exfat

original authors: Joosun Hahn
Sung-Kwan Kim

---
 drivers/staging/Kconfig               |    2 +
 drivers/staging/Makefile              |    1 +
 drivers/staging/exfat/Kconfig         |   25 +
 drivers/staging/exfat/Makefile        |   10 +
 drivers/staging/exfat/TODO            |    3 +
 drivers/staging/exfat/exfat.c         | 4941 +++++++++++++++++++++++++++++++++
 drivers/staging/exfat/exfat.h         |  613 ++++
 drivers/staging/exfat/exfat_api.c     |  458 +++
 drivers/staging/exfat/exfat_api.h     |  164 ++
 drivers/staging/exfat/exfat_blkdev.c  |  155 ++
 drivers/staging/exfat/exfat_blkdev.h  |   45 +
 drivers/staging/exfat/exfat_cache.c   |  741 +++++
 drivers/staging/exfat/exfat_cache.h   |   62 +
 drivers/staging/exfat/exfat_data.c    |   39 +
 drivers/staging/exfat/exfat_data.h    |   48 +
 drivers/staging/exfat/exfat_global.c  |  118 +
 drivers/staging/exfat/exfat_global.h  |  126 +
 drivers/staging/exfat/exfat_nls.c     |  353 +++
 drivers/staging/exfat/exfat_nls.h     |   69 +
 drivers/staging/exfat/exfat_oal.c     |  156 ++
 drivers/staging/exfat/exfat_oal.h     |   48 +
 drivers/staging/exfat/exfat_part.h    |   56 +
 drivers/staging/exfat/exfat_super.c   | 2009 ++++++++++++++
 drivers/staging/exfat/exfat_super.h   |  153 +
 drivers/staging/exfat/exfat_upcase.c  |  389 +++
 drivers/staging/exfat/exfat_version.h |    1 +
 26 files changed, 10785 insertions(+)
 create mode 100644 drivers/staging/exfat/Kconfig
 create mode 100644 drivers/staging/exfat/Makefile
 create mode 100644 drivers/staging/exfat/TODO
 create mode 100644 drivers/staging/exfat/exfat.c
 create mode 100644 drivers/staging/exfat/exfat.h
 create mode 100644 drivers/staging/exfat/exfat_api.c
 create mode 100644 drivers/staging/exfat/exfat_api.h
 create mode 100644 drivers/staging/exfat/exfat_blkdev.c
 create mode 100644 drivers/staging/exfat/exfat_blkdev.h
 create mode 100644 drivers/staging/exfat/exfat_cache.c
 create mode 100644 drivers/staging/exfat/exfat_cache.h
 create mode 100644 drivers/staging/exfat/exfat_data.c
 create mode 100644 drivers/staging/exfat/exfat_data.h
 create mode 100644 drivers/staging/exfat/exfat_global.c
 create mode 100644 drivers/staging/exfat/exfat_global.h
 create mode 100644 drivers/staging/exfat/exfat_nls.c
 create mode 100644 drivers/staging/exfat/exfat_nls.h
 create mode 100644 drivers/staging/exfat/exfat_oal.c
 create mode 100644 drivers/staging/exfat/exfat_oal.h
 create mode 100644 drivers/staging/exfat/exfat_part.h
 create mode 100644 drivers/staging/exfat/exfat_super.c
 create mode 100644 drivers/staging/exfat/exfat_super.h
 create mode 100644 drivers/staging/exfat/exfat_upcase.c
 create mode 100644 drivers/staging/exfat/exfat_version.h
drivers/staging/Kconfig +2 -0
index 57d8b34..d4c3b4b 100644
@@ -142,4 +142,6 @@ source "drivers/staging/lustre/Kconfig"
 
 source "drivers/staging/btmtk_usb/Kconfig"
 
+source "drivers/staging/exfat/Kconfig"
+
 endif # STAGING
drivers/staging/Makefile +1 -0
index 429321f..370e314 100644
@@ -63,3 +63,4 @@ obj-$(CONFIG_GOLDFISH)		+= goldfish/
 obj-$(CONFIG_USB_DWC2)		+= dwc2/
 obj-$(CONFIG_LUSTRE_FS)		+= lustre/
 obj-$(CONFIG_USB_BTMTK)		+= btmtk_usb/
+obj-$(CONFIG_EXFAT_FS)		+= exfat/
drivers/staging/exfat/Kconfig new file +25 -0
new file mode 100644
index 0000000..1f91227
@@ -0,0 +1,25 @@
+config EXFAT_FS
+	tristate "exFAT fs support"
+	select NLS
+	help
+	  This adds the exFAT file system
+
+if EXFAT_FS
+
+config EXFAT_LITTLE_ENDIAN
+	bool "Little Endian Mode"
+	default y
+
+config EXFAT_DISCARD
+	bool "enable discard"
+	default y
+
+config EXFAT_KERNEL_DEBUG
+	bool "enable debugging"
+	default y
+
+config EXFAT_DEBUG_MSG
+	bool "print debug messages"
+	default n
+
+endif # EXFAT_FS
drivers/staging/exfat/Makefile new file +10 -0
new file mode 100644
index 0000000..d7fabfa
@@ -0,0 +1,10 @@
+#
+# Makefile for the Linux fat filesystem support.
+#
+
+obj-$(CONFIG_EXFAT_FS) += exfat_core.o exfat_fs.o
+
+exfat_fs-y	:= exfat_super.o
+
+exfat_core-y	:= exfat.o exfat_api.o exfat_blkdev.o exfat_cache.o \
+			   exfat_data.o exfat_global.o exfat_nls.o exfat_oal.o exfat_upcase.o
drivers/staging/exfat/TODO new file +3 -0
new file mode 100644
index 0000000..707310a
@@ -0,0 +1,3 @@
+* fix coding style
+* remove dead code
+* merge with existing FAT implementation
drivers/staging/exfat/exfat.c new file +4941 -0

2,952 lines not on this page · raw message

drivers/staging/exfat/exfat.h new file +613 -0

613 lines not on this page · raw message

drivers/staging/exfat/exfat_api.c new file +458 -0

458 lines not on this page · raw message

drivers/staging/exfat/exfat_api.h new file +164 -0

164 lines not on this page · raw message

drivers/staging/exfat/exfat_blkdev.c new file +155 -0

155 lines not on this page · raw message

drivers/staging/exfat/exfat_blkdev.h new file +45 -0

45 lines not on this page · raw message

drivers/staging/exfat/exfat_cache.c new file +741 -0

741 lines not on this page · raw message

drivers/staging/exfat/exfat_cache.h new file +62 -0

62 lines not on this page · raw message

drivers/staging/exfat/exfat_data.c new file +39 -0
new file mode 100644
index 0000000..8c5dd88

Lines of this file are not shown. View the raw message.

drivers/staging/exfat/exfat_data.h new file +48 -0

48 lines not on this page · raw message

drivers/staging/exfat/exfat_global.c new file +118 -0

118 lines not on this page · raw message

drivers/staging/exfat/exfat_global.h new file +126 -0

126 lines not on this page · raw message

drivers/staging/exfat/exfat_nls.c new file +353 -0

353 lines not on this page · raw message

drivers/staging/exfat/exfat_nls.h new file +69 -0

69 lines not on this page · raw message

drivers/staging/exfat/exfat_oal.c new file +156 -0

156 lines not on this page · raw message

drivers/staging/exfat/exfat_oal.h new file +48 -0

48 lines not on this page · raw message

drivers/staging/exfat/exfat_part.h new file +56 -0

56 lines not on this page · raw message

drivers/staging/exfat/exfat_super.c new file +2009 -0

2,009 lines not on this page · raw message

drivers/staging/exfat/exfat_super.h new file +153 -0

153 lines not on this page · raw message

drivers/staging/exfat/exfat_upcase.c new file +389 -0

389 lines not on this page · raw message

drivers/staging/exfat/exfat_version.h new file +1 -0
new file mode 100644
index 0000000..ab6ce18

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
1.8.1.2

Part of the diff is not shown here. View the raw message.

#1 lore raw
Quoted 11 lines · Benjamin Valentin

Samsung released their exFAT (and FAT12/16/32) driver under the GPLv2, it is based on the in-kernel FAT driver and can be obtained from [1]. This patch adds version 1.2.4 of the exfat driver, sans the ifdefs for older kernel versions and ported to Linux 3.11.

[1] http://opensource.samsung.com search for exfat

original authors: Joosun Hahn
Sung-Kwan Kim

Why original authors don't participate in submission of driver?

Anyway, it makes sense to prepare patch set instead of one huge patch. Could you, please, prepare patch set?

And you should add linux-fsdevel list in CC for any discussion about file system drivers.

Thanks,
Vyacheslav Dubeyko.

#2 lore raw
In reply to Benjamin Valentin
Quoted 11 lines · Benjamin Valentin

Samsung released their exFAT (and FAT12/16/32) driver under the GPLv2, it is based on the in-kernel FAT driver and can be obtained from [1]. This patch adds version 1.2.4 of the exfat driver, sans the ifdefs for older kernel versions and ported to Linux 3.11.

[1] http://opensource.samsung.com search for exfat

original authors: Joosun Hahn
Sung-Kwan Kim

For staging drivers I need a maintainer that is going to take the time to shephard it into the core kernel tree. See other TODO files for how that person is defined. Are you going to be willing to do this?

If so, can you please resend it with those changes to the TODO file, and add a MAINTAINERS file entry?

Also, I would really like to get a signed-off-by: from the Samsung authors for this patch, can you do that as well please?

thanks,

greg k-h

#3 lore raw

Am Fri, 30 Aug 2013 08:42:05 -0700
schrieb Greg Kroah-Hartman <[email protected]>:

Quoted 3 lines

For staging drivers I need a maintainer that is going to take the time to shephard it into the core kernel tree. See other TODO files for how that person is defined. Are you going to be willing to do this?

I can see what I can do.

I've cleaned up the code a bit, especially where it would redefine kernel functions. [1] Should I submit the end result, one file per patch, or begin with the original code and submit patches on top of that?

Also, the driver would define it's own data types like

    typedef unsigned int            UINT32;

I've replaced that with u32, etc as the naming implied the bit size would matter. (And it probably does for the on-disk file system structures, but they are used for everything) Is there any disadvantage to this over using the standard C types?

Quoted 2 lines

Also, I would really like to get a signed-off-by: from the Samsung authors for this patch, can you do that as well please?

I've tried reaching them by their last public e-mail addresses I could find, but they would either bounce or I got no reply.

[1] https://github.com/benpicco/linux_exfat-staging/commits/exfat

#4 lore raw
Quoted 7 lines · Benjamin Valentin

Am Fri, 30 Aug 2013 08:42:05 -0700
schrieb Greg Kroah-Hartman <[email protected]>:

Quoted 3 lines

For staging drivers I need a maintainer that is going to take the time to shephard it into the core kernel tree. See other TODO files for how that person is defined. Are you going to be willing to do this?

Quoted 6 lines

I can see what I can do.

I've cleaned up the code a bit, especially where it would redefine kernel functions. [1] Should I submit the end result, one file per patch, or begin with the original code and submit patches on top of that?

For staging code:
1. It must pass compile.
2. you have an TODO file with things to do to clean it up to the standard quality of the kernel.

#5 lore raw
In reply to Benjamin Valentin
Quoted 8 lines · Benjamin Valentin

Am Fri, 30 Aug 2013 08:42:05 -0700
schrieb Greg Kroah-Hartman <[email protected]>:

Quoted 3 lines

For staging drivers I need a maintainer that is going to take the time to shephard it into the core kernel tree. See other TODO files for how that person is defined. Are you going to be willing to do this?

I can see what I can do.

Great.

Quoted 4 lines

I've cleaned up the code a bit, especially where it would redefine kernel functions. [1] Should I submit the end result, one file per patch, or begin with the original code and submit patches on top of that?

Probably start with the original submission from Samsung, with their
signed-off-by: lines, and then add patches afterward that from you with your fixes / cleanups. That shows the development effort and gives everyone the proper credit/blame :)

Quoted 7 lines

Also, the driver would define it's own data types like

    typedef unsigned int            UINT32;

I've replaced that with u32, etc as the naming implied the bit size would matter. (And it probably does for the on-disk file system structures, but they are used for everything) Is there any disadvantage to this over using the standard C types?

Those _are_ the standard kernel C types, so that's the correct thing to do.

Quoted 5 lines
Quoted 2 lines

Also, I would really like to get a signed-off-by: from the Samsung authors for this patch, can you do that as well please?

I've tried reaching them by their last public e-mail addresses I could find, but they would either bounce or I got no reply.

Who did you contact at Samsung? I'll be visiting there in a week so I can try to track some people done in person. I really want their
signed-off-by: on the patch, as it is their code to start with, and it's a bit rude to not get their approval for the code to be merged.

thanks,

greg k-h

#6 lore raw
Quoted 4 lines · Greg Kroah-Hartman

Who did you contact at Samsung? I'll be visiting there in a week so I can try to track some people done in person. I really want their
signed-off-by: on the patch, as it is their code to start with, and it's a bit rude to not get their approval for the code to be merged.

It's arguably rude, but it's fine under the certificate of origin.

Signature · 1 line
Matthew Garrett | [email protected]
#7 lore raw
Quoted 8 lines · Matthew Garrett
Quoted 4 lines · Greg Kroah-Hartman

Who did you contact at Samsung? I'll be visiting there in a week so I can try to track some people done in person. I really want their
signed-off-by: on the patch, as it is their code to start with, and it's a bit rude to not get their approval for the code to be merged.

It's arguably rude, but it's fine under the certificate of origin.

Oh, I totally agree, just trying to be nice here. If a company objects to having their code included in the tree, we should always take that into consideration, especially given the ability for others to maintain it. We've done this for years, nothing new here at all.

thanks,

greg k-h

#8 lore raw

Am 25.09.2013 20:45, schrieb Greg Kroah-Hartman:

Quoted 8 lines · Matthew Garrett
Quoted 7 lines · Greg Kroah-Hartman
Quoted 5 lines

Who did you contact at Samsung? I'll be visiting there in a week so I can try to track some people done in person. I really want their
signed-off-by: on the patch, as it is their code to start with, and it's a bit rude to not get their approval for the code to be merged.

Quoted 6 lines
Quoted 1 line

It's arguably rude, but it's fine under the certificate of origin.

Oh, I totally agree, just trying to be nice here. If a company objects to having their code included in the tree, we should always take that into consideration, especially given the ability for others to maintain it. We've done this for years, nothing new here at all.

Maybe a silly question, but isn't exFAT protected by some MS owned patents which might drive Linux users into the hand of MS lawyers as already happened with FAT? It would make me wonder if not. Maybe you could ask Samsung about that too, when you are there.

Regards,

Alexander Holler

#9 lore raw
Quoted 16 lines · Alexander Holler

Am 25.09.2013 20:45, schrieb Greg Kroah-Hartman:

Quoted 8 lines · Matthew Garrett
Quoted 7 lines · Greg Kroah-Hartman
Quoted 5 lines

Who did you contact at Samsung? I'll be visiting there in a week so I can try to track some people done in person. I really want their
signed-off-by: on the patch, as it is their code to start with, and it's a bit rude to not get their approval for the code to be merged.

Quoted 6 lines
Quoted 1 line

It's arguably rude, but it's fine under the certificate of origin.

Oh, I totally agree, just trying to be nice here. If a company objects to having their code included in the tree, we should always take that into consideration, especially given the ability for others to maintain it. We've done this for years, nothing new here at all.

Quoted 4 lines

Maybe a silly question, but isn't exFAT protected by some MS owned patents which might drive Linux users into the hand of MS lawyers as already happened with FAT? It would make me wonder if not. Maybe you could ask Samsung about that too, when you are there.

Because Samsung released the code under the GPLv2, and their lawyers understand what that means, should answer any question you might have about this.

thanks,

greg k-h

#10 lore raw

Am 25.09.2013 22:21, schrieb Greg Kroah-Hartman:

Quoted 7 lines · Alexander Holler
Quoted 5 lines

Maybe a silly question, but isn't exFAT protected by some MS owned patents which might drive Linux users into the hand of MS lawyers as already happened with FAT? It would make me wonder if not. Maybe you could ask Samsung about that too, when you are there.

Quoted 5 lines

Because Samsung released the code under the GPLv2, and their lawyers understand what that means, should answer any question you might have about this.

thanks,

I'll have to thank for the clarification.

Alexander Holler

#11 lore raw
In reply to Greg Kroah-Hartman

Hi,

Quoted 5 lines · Greg Kroah-Hartman
Quoted 4 lines · Alexander Holler

Maybe a silly question, but isn't exFAT protected by some MS owned patents which might drive Linux users into the hand of MS lawyers as already happened with FAT?

Yes, it is. You cannot use exFAT without a Microsoft patent license (unless you live in countries without software patents perhaps).

Quoted 5 lines
Quoted 1 line

It would make me wonder if not. Maybe you could ask Samsung about that too, when you are there.

Because Samsung released the code under the GPLv2, and their lawyers understand what that means, should answer any question you might have about this.

Sorry but you have no idea what you are talking about. Samsung modified the GPL-ed FAT driver to make it work with exFAT. Therefore their exFAT driver was GPL as a derived work. They got caught and had to release the source code.

It has NOTHING to do with what their lawyers understand, etc, and if you are really going to be visiting Samsung and if they are willing to talk to you about it you will be retracting what you wrote above in a hurry... Sorry I cannot say more but I strongly suggest NOT to use this "GPL-ed exFAT driver" under any circumstances unless you get a patent license from Microsoft first.

Best regards,

Anton

Quoted 3 lines

thanks,

greg k-h

Signature · 3 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge
J.J. Thomson Avenue, Cambridge, CB3 0RB, UK
#12 lore raw

Am 25.09.2013 23:44, schrieb Anton Altaparmakov:

Quoted 10 lines

Hi,

Quoted 5 lines · Greg Kroah-Hartman
Quoted 4 lines · Alexander Holler

Maybe a silly question, but isn't exFAT protected by some MS owned patents which might drive Linux users into the hand of MS lawyers as already happened with FAT?

Yes, it is. You cannot use exFAT without a Microsoft patent license (unless you live in countries without software patents perhaps).

That part about software patents is a farce. Here in Germany (and as I understood in whole Europe), software patents should not exist. But the FAT patent got approved by our Bungesgerichtshof, which is something like the Federal Supreme court in the US.

Regards,

Alexander Holler

#13 lore raw
In reply to Anton Altaparmakov
Quoted 11 lines · Anton Altaparmakov

Hi,

Quoted 5 lines · Greg Kroah-Hartman
Quoted 4 lines · Alexander Holler

Maybe a silly question, but isn't exFAT protected by some MS owned patents which might drive Linux users into the hand of MS lawyers as already happened with FAT?

Yes, it is. You cannot use exFAT without a Microsoft patent license (unless you live in countries without software patents perhaps).

Given that you that you are not a Microsoft representative, nor a Samsung employee, I don't understand how you can make such a definitive statement.

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

It would make me wonder if not. Maybe you could ask Samsung about that too, when you are there.

Because Samsung released the code under the GPLv2, and their lawyers understand what that means, should answer any question you might have about this.

Sorry but you have no idea what you are talking about.

Ah, that's a lovely way to engage in a conversation.

Quoted 3 lines

Samsung modified the GPL-ed FAT driver to make it work with exFAT. Therefore their exFAT driver was GPL as a derived work. They got caught and had to release the source code.

And now you claim to be a Samsung representative again, I think your country has some bad liable laws you might wish to watch out for...

This isn't going to go very far, so I'll just not respond anymore, it's not going to be productive, and given that I don't see your name on the code here, I don't see why I need to.

Please stick to technical discussions about the code on the kernel mailing lists. Legal discussions can be left up to the lawyers, of which we are not.

greg k-h

#14 lore raw

Am 26.09.2013 00:10, schrieb Greg Kroah-Hartman:

Quoted 3 lines

Please stick to technical discussions about the code on the kernel mailing lists. Legal discussions can be left up to the lawyers, of which we are not.

Hmm, but I would like to know if someone has to fear getting owned by Microsoft if he would use that driver.

Giving the rumours about Linux companies having to pay Microsoft and giving the fact that all of those licencees seem to don't have to speak about what Microsoft claims patents for and for what they have to pay, I obviously think adding that driver to Linux and thus making exFAT more general accepted is a very bad idea.

Of course, I'm not a lawyer too, but as a responsible Linux developer, I should at least be able to warn other parities when they approach me and want to use exFAT. Doing such without the maybe necessary license might drive small companies into the ground because most of them are unable to even think about having the money needed to talk with Microsoft lawyers in front of a court.

Regards,

Alexander Holler

#15 lore raw
Quoted 8 lines · Alexander Holler

Am 26.09.2013 00:10, schrieb Greg Kroah-Hartman:

Quoted 3 lines

Please stick to technical discussions about the code on the kernel mailing lists. Legal discussions can be left up to the lawyers, of which we are not.

Hmm, but I would like to know if someone has to fear getting owned by Microsoft if he would use that driver.

Nobody should ever assume that any piece of code they receive is free of third party patent claims, no matter where the code came from.

Signature · 1 line
Matthew Garrett | [email protected]
#16 lore raw
In reply to Alexander Holler

Hi,

Quoted 14 lines · Alexander Holler

Am 26.09.2013 00:10, schrieb Greg Kroah-Hartman:

Quoted 3 lines

Please stick to technical discussions about the code on the kernel mailing lists. Legal discussions can be left up to the lawyers, of which we are not.

Hmm, but I would like to know if someone has to fear getting owned by Microsoft if he would use that driver.

Giving the rumours about Linux companies having to pay Microsoft and giving the fact that all of those licencees seem to don't have to speak about what Microsoft claims patents for and for what they have to pay, I obviously think adding that driver to Linux and thus making exFAT more general accepted is a very bad idea.

Quoted 6 lines

Of course, I'm not a lawyer too, but as a responsible Linux developer, I should at least be able to warn other parities when they approach me and want to use exFAT. Doing such without the maybe necessary license might drive small companies into the ground because most of them are unable to even think about having the money needed to talk with Microsoft lawyers in front of a court.

Exactly. That is all I was trying to do. Warn people/companies not to use the driver because they may get sued for using it. As the below Microsoft exFAT licensing page says at the bottom:

<quote>
Please note that open source or other publicly available implementations of exFAT do not include an IP license from Microsoft. For licensing information, please contact [email protected]. </quote>

Above is from bottom of:

http://www.microsoft.com/en-us/legal/intellectualproperty/IPLicensing/Programs/exFATFileSystem.aspx

Best regards,

Anton

Signature · 3 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge
J.J. Thomson Avenue, Cambridge, CB3 0RB, UK
#17 lore raw

Anton, I already told you politely in a private email that you are being offtopic. This is professional email list for programmers. Most of us are forbidden to discuss laws except with our corporate legal dept. None of us are lawyers. We're not qualified to read any of your links or interpret how they apply to anyone. We can't help you or respond to you.

In other words, shut the fuck up. Let's not continue this thread.

regards,
dan carpenter

#18 lore raw

Am 26.09.2013 12:41, schrieb Dan Carpenter:

Quoted 8 lines

Anton, I already told you politely in a private email that you are being offtopic. This is professional email list for programmers. Most of us are forbidden to discuss laws except with our corporate legal dept. None of us are lawyers. We're not qualified to read any of your links or interpret how they apply to anyone. We can't help you or respond to you.

In other words, shut the fuck up. Let's not continue this thread.

First my first name is Alexander and not Anton, and second I haven't respond to any mail on that topic after I received your private mail.

And third, "the fuck" just describes the topic perfectly.

Regards,

Alexander Holler

#19 lore raw
Quoted 8 lines · Alexander Holler

Am 26.09.2013 12:41, schrieb Dan Carpenter:

Quoted 7 lines

Anton, I already told you politely in a private email that you are being offtopic. This is professional email list for programmers. Most of us are forbidden to discuss laws except with our corporate legal dept. None of us are lawyers. We're not qualified to read any of your links or interpret how they apply to anyone. We can't help you or respond to you.

Quoted 5 lines
Quoted 1 line

In other words, shut the fuck up. Let's not continue this thread.

First my first name is Alexander and not Anton, and second I haven't respond to any mail on that topic after I received your private mail.

No, Alexander, you're cool. The email was meant specifically for Aton. :P

regards,
dan carpenter

#20 lore raw
In reply to Greg Kroah-Hartman

Hi,

Quoted 8 lines · Greg Kroah-Hartman
Quoted 7 lines · Anton Altaparmakov
Quoted 5 lines · Greg Kroah-Hartman
Quoted 4 lines · Alexander Holler

Maybe a silly question, but isn't exFAT protected by some MS owned patents which might drive Linux users into the hand of MS lawyers as already happened with FAT?

Quoted 6 lines
Quoted 2 lines

Yes, it is. You cannot use exFAT without a Microsoft patent license (unless you live in countries without software patents perhaps).

Given that you that you are not a Microsoft representative, nor a Samsung employee, I don't understand how you can make such a definitive statement.

Have you actually read the source code that was released?

May I quote just one bit:

from exfat_1.2.4/exfat.c (available from http://opensource.samsung.com - just search for exfat) at the top:

/* Some of the source code in this file came from "linux/fs/fat/misc.c". */ /*
* linux/fs/fat/misc.c
*
* Written 1992,1993 by Werner Almesberger
* 22/11/2000 - Fixed fat_date_unix2dos for dates earlier than 01/01/1980
* and date_dos2unix for date==0 by Igor Zhbanov([email protected])
*/

That is somewhat conclusively a derivative work is it not?

Also, have a read of this article:

http://www.phoronix.com/scan.php?page=news_item&px=MTQzODQ

Which explains further who made them open source it after they saw the leaked code on github.

So even without resorting to knowledge I may not discuss it is pretty conclusive that what I said is correct as anyone driving google can find for themselves as I pointed out above...

Quoted 10 lines
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

It would make me wonder if not. Maybe you could ask Samsung about that too, when you are there.

Because Samsung released the code under the GPLv2, and their lawyers understand what that means, should answer any question you might have about this.

Sorry but you have no idea what you are talking about.

Ah, that's a lovely way to engage in a conversation.

I did say sorry! (-;

Quoted 6 lines
Quoted 3 lines

Samsung modified the GPL-ed FAT driver to make it work with exFAT. Therefore their exFAT driver was GPL as a derived work. They got caught and had to release the source code.

And now you claim to be a Samsung representative again, I think your country has some bad liable laws you might wish to watch out for...

I am not claiming anything and least of all to be representing Samsung!!!

Libel implies untruth and as you can see above I am only stating what anyone can readily find on google.

Quoted 7 lines

This isn't going to go very far, so I'll just not respond anymore, it's not going to be productive, and given that I don't see your name on the code here, I don't see why I need to.

Please stick to technical discussions about the code on the kernel mailing lists. Legal discussions can be left up to the lawyers, of which we are not.

I agree, but then please stop making public assertions that people can use the exfat driver legally. You just yourself said you are not a lawyer so I do not understand how you can make your assertion!

If anyone cares, here is Microsoft's exFAT licensing page which I strongly recommend you read before you use that driver:

http://www.microsoft.com/en-us/legal/intellectualproperty/IPLicensing/Programs/exFATFileSystem.aspx

Also if you search google for "exFAT patent" you can find some that way but there are also others that are not found that way but that are clearly essential for any exFAT implementation (according to the technical review I did of them). I am not sure whether I am allowed to give a list or not so I will refrain from doing so.

Best regards,

Anton

Signature · 3 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge
J.J. Thomson Avenue, Cambridge, CB3 0RB, UK
#21 lore raw
In reply to Greg Kroah-Hartman

Am Wed, 25 Sep 2013 10:27:04 -0700
schrieb Greg Kroah-Hartman <[email protected]>:

Quoted 10 lines
Quoted 5 lines
Quoted 2 lines

Also, I would really like to get a signed-off-by: from the Samsung authors for this patch, can you do that as well please?

I've tried reaching them by their last public e-mail addresses I could find, but they would either bounce or I got no reply.

Who did you contact at Samsung? I'll be visiting there in a week so I can try to track some people done in person. I really want their
signed-off-by: on the patch, as it is their code to start with, and it's a bit rude to not get their approval for the code to be merged.

I didn't really know who to contact at Samsung, so I've searched the web for Joosun Hahn and Sung-Kwan Kim. They both had addresses from the Memory & Storage Architecture Lab at Seoul National University, but they seem no longer active.
I've also tried the inquiry form on the Samsung web page, but got no reply.

It'd be great if you could get Samsung to work on this too, I guess they weren't originally so keen on mainlining it when it took the Software Freedom Conservancy to get them to release the code [1], but now that it's out in the open they might as well take the benefits from mainline inclusion.

[1] http://sfconservancy.org/news/2013/aug/16/exfat-samsung/

#22 lore raw
Quoted 14 lines · Benjamin Valentin

Am Wed, 25 Sep 2013 10:27:04 -0700
schrieb Greg Kroah-Hartman <[email protected]>:

Quoted 10 lines
Quoted 5 lines
Quoted 2 lines

Also, I would really like to get a signed-off-by: from the Samsung authors for this patch, can you do that as well please?

I've tried reaching them by their last public e-mail addresses I could find, but they would either bounce or I got no reply.

Who did you contact at Samsung? I'll be visiting there in a week so I can try to track some people done in person. I really want their
signed-off-by: on the patch, as it is their code to start with, and it's a bit rude to not get their approval for the code to be merged.

Quoted 6 lines

I didn't really know who to contact at Samsung, so I've searched the web for Joosun Hahn and Sung-Kwan Kim. They both had addresses from the Memory & Storage Architecture Lab at Seoul National University, but they seem no longer active.
I've also tried the inquiry form on the Samsung web page, but got no reply.

Ok, I'll try to track the people responsible for this down when I visit. In the mean time, you can continue to work on cleaning up the code :)

thanks,

greg k-h