Skip to contentSkip to conversation

virtio_pci: fix level interrupts with irqfd

PATCH New Michael S. Tsirkin 1 participant 1 message Sep 1, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio_pci: fix level interrupts with irqfd

commit 62c96360ae7f2c7a8b029277fbb7cb082fdef7fd
virtio-pci: fix level interrupts
only helps systems without irqfd: on systems with irqfd support we passed in flag requesting irqfd even when msix is disabled.

As a result, for level interrupts we didn't install an fd handler so unmasking an fd had no effect.

Fix this up.

---
 hw/virtio/virtio-pci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
hw/virtio/virtio-pci.c +1 -2
index d37037e..41b96ce 100644
@@ -799,8 +799,7 @@ static int virtio_pci_set_guest_notifiers(DeviceState *d, int nvqs, bool assign)
             break;
         }
 
-        r = virtio_pci_set_guest_notifier(d, n, assign,
-                                          kvm_msi_via_irqfd_enabled());
+        r = virtio_pci_set_guest_notifier(d, n, assign, with_irqfd);
         if (r < 0) {
             goto assign_error;
         }
Signature · 1 line
MST