big-endian updates for ARM
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 56 lines · Dave Martin
Quoted 18 lines · Ben Dooks
With the last ack added, the following series is ready to be pulled.
The following changes since commit
fa8218def1b1a16f0a410e2c1c767b4738cc81fa:Merge tag 'regmap-v3.11-rc7' of
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap
(2013-08-27 10:10:30 -0700)are available in the git repository at:
git://git.baserock.org/delta/linux.git baserock/311-rc7/be/core-v3for you to fetch changes up to
5217543fe4605fa91065acf5141d88949cd3da1e:ARM: signal:
sigreturn_codesshould be endian neutral to work in BE8
(2013-09-02 11:53:53 +0100)Quoted 15 lines
----------------------------------------------------------------
Ben Dooks (19):
ARM: fixARCH_IXP4xxusage ofARCH_SUPPORTS_BIG_ENDIAN
ARM: asm: AddARM_BE8()assembly helper
ARM:fixup_pv_tablebug whenCPU_ENDIAN_BE8
ARM: set BE8 if LE in head code
ARM: pl01x debug code endian fix
ARM: twd: data endian fix
ARM:smp_scu: data endian fixes
highbank: enable big-endian
fix highbank
mvebu: support running big-endian
vexpress: add big endian support
ARM: alignment: correctly decode instructions in BE8 mode.
ARM: traps: use<asm/opcodes.h> to get correct instruction orderAs I repoerted in [1], this is patch broken for
CONFIG_THUMB2_KERNELdue to a typo:
arch/arm/kernel/traps.c: In function 'do_undefinstr':arch/arm/kernel/traps.c:411:5: error: 'instr2' undeclared (first use in this function)instr2 = __mem_to_opcode_thumb16(((u16 *)pc)[1]); ^ arch/arm/kernel/traps.c:411:5: note: each undeclared identifier is reported only once for each function it appears in arch/arm/kernel/traps.c:410:9: warning: unused variable 'inst2' [-Wunused-variable] u16 inst2; ^make[1]: *** [
arch/arm/kernel/traps.o] Error 1The following should be enough to fix it:
arch/arm/kernel/traps.c +0
-0
arch/arm/kernel/traps.c asmlinkage void __exception do_undefinstr(struct pt_regs *regs) · line 413
Quoted 8 lines
arch/arm/kernel/traps.c +1
-1@@ -407,7 +407,7 @@ asmlinkage void __exception do_undefinstr(struct pt_regs *regs)if (thumb_mode (regs)) { instr =__mem_to_opcode_thumb16 (((u16 *)pc)[0 ]);if (is_wide_instruction (instr)) { -u16 inst2; +u16 instr2; instr2 =__mem_to_opcode_thumb16 (((u16 *)pc)[1 ]); instr =__opcode_thumb32_compose (instr, instr2); }
Sorry, I thought that had been fixed, thanks for reminding me.
I have fixed it and now on:
git://git.baserock.org/delta/linux baserock/311-rc7/be/core-v4
Signature · 2 lines
Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius
Dear Ben Dooks,
Quoted 5 lines · Ben Dooks
Sorry, I thought that had been fixed, thanks for reminding me.
I have fixed it and now on:
git://git.baserock.org/delta/linux baserock/311-rc7/be/core-v4
Can you resend a proper pull request for this core-v4 branch? There has been two fixes since the v3, the Acked-by from one of the mach-mvebu maintainers, and my Tested-by.
Also, as indicated on IRC, I confirm that this patch set also works on Armada 370. It doesn't work on one particular Armada 370 board that I have, but it's using an old bootloader that may be the cause of the issue. The BE kernel works fine on the two other Armada 370 boards I've tested.
Thanks!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
Quoted 6 lines · Thomas Petazzoni
Dear Ben Dooks,
Quoted 2 lines · Ben Dooks
Sorry, I thought that had been fixed, thanks for reminding me.
Quoted 7 lines
Quoted 3 lines
I have fixed it and now on:
git://git.baserock.org/delta/linux baserock/311-rc7/be/core-v4Can you resend a proper pull request for this core-v4 branch? There has been two fixes since the v3, the Acked-by from one of the mach-mvebu maintainers, and my Tested-by.
that was just a confirmation for Dave to test. I will sort out a new pull request later.
Quoted 9 lines
Also, as indicated on IRC, I confirm that this patch set also works on Armada 370. It doesn't work on one particular Armada 370 board that I have, but it's using an old bootloader that may be the cause of the issue. The BE kernel works fine on the two other Armada 370 boards I've tested.
Thanks!
Thomas
Signature · 2 lines
Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius
Dear Ben Dooks,
Quoted 10 lines · Ben Dooks
Quoted 7 lines
Quoted 3 lines
I have fixed it and now on:
git://git.baserock.org/delta/linux baserock/311-rc7/be/core-v4Can you resend a proper pull request for this core-v4 branch? There has been two fixes since the v3, the Acked-by from one of the mach-mvebu maintainers, and my Tested-by.
that was just a confirmation for Dave to test. I will sort out a new pull request later.
Excellent, thanks!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
Quoted 12 lines · Thomas Petazzoni
Dear Ben Dooks,
Quoted 8 lines · Ben Dooks
Quoted 7 lines
Quoted 3 lines
I have fixed it and now on:
git://git.baserock.org/delta/linux baserock/311-rc7/be/core-v4Can you resend a proper pull request for this core-v4 branch? There has been two fixes since the v3, the Acked-by from one of the mach-mvebu maintainers, and my Tested-by.
Quoted 6 lines
Quoted 2 lines
that was just a confirmation for Dave to test. I will sort out a new pull request later.
Excellent, thanks!
Thomas
Out of interest, should all patches in the series have the Tested-by line added to them, or just the top-level pull request?
Signature · 2 lines
Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius
Dear Ben Dooks,
Quoted 2 lines · Ben Dooks
Out of interest, should all patches in the series have the Tested-by line added to them, or just the top-level pull request?
I believe the Tested-by normall goes to the individual patches. However, my testing on Armada XP obviously didn't exercise all the patches (I haven't tested modules, I haven't used the bpf_jit thing, I haven't tested the twd, smp_scu and pl01x fixes, etc.).
Thanks,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com