Skip to contentSkip to conversation

usb: host: Faraday fotg210-hcd driver

DISCUSSION Dave Jones 2 participants 6 messages Sep 3, 2013 1 message not in the archive USB

lore
Share & tools
lore

Dave Jones

author
#1 lore raw
In reply to a message not in the archive
Quoted 22 lines · Linux Kernel
Gitweb:     http://git.kernel.org/linus/;a=commit;h=1dd3d123239179fad5de5dc00a6e0014a1918fde
Commit:     1dd3d123239179fad5de5dc00a6e0014a1918fde
Parent:     10e232c597ac757e7f8600649f7e872e86de190f
Author:     Yuan-Hsin Chen <[email protected]>
AuthorDate: Wed Jun 19 19:53:04 2013 +0000
Committer:  Greg Kroah-Hartman <[email protected]>
CommitDate: Wed Jul 24 16:04:53 2013 -0700

usb: host: Faraday fotg210-hcd driver

FOTG210 is an OTG controller which can be configured as an USB2.0 host. FOTG210 host is an ehci-like controller with some differences. First, register layout of FOTG210 is incompatible with EHCI. Furthermore, FOTG210 is lack of siTDs which means iTDs are used for both HS and FS ISO transfer.

(quoted diff) +2 -0
+config USB_FOTG210_HCD
+	tristate "FOTG210 HCD support"

Review

Quoted 10 lines
(quoted diff) +10 -0
+	depends on USB
+	default N
+	---help---
+	  Faraday FOTG210 is an OTG controller which can be configured as
+	  an USB2.0 host. It is designed to meet USB2.0 EHCI specification
+	  with minor modification.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called fotg210-hcd.
+

Shouldn't this depend on USB_OTG ?
Seems odd to have OTG related options presented to me when I have that unset.

Dave

maintainer
#2 lore raw
Quoted 21 lines · Dave Jones
Quoted 19 lines · Linux Kernel
Gitweb:     http://git.kernel.org/linus/;a=commit;h=1dd3d123239179fad5de5dc00a6e0014a1918fde
Commit:     1dd3d123239179fad5de5dc00a6e0014a1918fde
Parent:     10e232c597ac757e7f8600649f7e872e86de190f
Author:     Yuan-Hsin Chen <[email protected]>
AuthorDate: Wed Jun 19 19:53:04 2013 +0000
Committer:  Greg Kroah-Hartman <[email protected]>
CommitDate: Wed Jul 24 16:04:53 2013 -0700

usb: host: Faraday fotg210-hcd driver

FOTG210 is an OTG controller which can be configured as an USB2.0 host. FOTG210 host is an ehci-like controller with some differences. First, register layout of FOTG210 is incompatible with EHCI. Furthermore, FOTG210 is lack of siTDs which means iTDs are used for both HS and FS ISO transfer.

Quoted 15 lines

Review

Quoted 12 lines
(quoted diff) +12 -0
+config USB_FOTG210_HCD
+	tristate "FOTG210 HCD support"
+	depends on USB
+	default N
+	---help---
+	  Faraday FOTG210 is an OTG controller which can be configured as
+	  an USB2.0 host. It is designed to meet USB2.0 EHCI specification
+	  with minor modification.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called fotg210-hcd.
+

Shouldn't this depend on USB_OTG ?
Seems odd to have OTG related options presented to me when I have that unset.

It's a USB Host controller, so it should be built if you have that option set. The fact that it can do OTG isn't an issue here, from what I can tell.

thanks,

greg k-h

author
#3 lore raw
Quoted 13 lines · Greg KH
Quoted 13 lines
Quoted 12 lines
(quoted diff) +12 -0
+config USB_FOTG210_HCD
+	tristate "FOTG210 HCD support"
+	depends on USB
+	default N
+	---help---
+	  Faraday FOTG210 is an OTG controller which can be configured as
+	  an USB2.0 host. It is designed to meet USB2.0 EHCI specification
+	  with minor modification.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called fotg210-hcd.
+
Quoted 6 lines
Quoted 2 lines

Shouldn't this depend on USB_OTG ?
Seems odd to have OTG related options presented to me when I have that unset.

It's a USB Host controller, so it should be built if you have that option set. The fact that it can do OTG isn't an issue here, from what I can tell.

Ok. It still likely needs a 'depends on $ARCH (arm?) | COMPILE_TEST' though.

Dave

PS: What happened with this driver ?

This patch landed twice in your tree, once in 1dd3d123239179fad5de5dc00a6e0014a1918fde from Yuan-Hsin Chen <[email protected]> and then in 7d50195f6c5005d6ae7a789d9a7f0a94d104ee96 from Feng-Hsin Chiang <[email protected]>

Given the former address seems to be broken, perhaps all those mentions of it in the faraday sources need updating ?

----- The following addresses had permanent fatal errors ----- <[email protected]>

    (reason: 553 5.1.3 <[email protected]>... Check FTC account failure!<2>)

----- Transcript of session follows -----
... while talking to mailhost1.faraday-tech.com.:

Quoted 1 line
Quoted 1 line
Quoted 1 line

DATA

<<< 553 5.1.3 <[email protected]>... Check FTC account failure!<2> 550 5.1.1 <[email protected]>... User unknown
<<< 503 5.0.0 Need RCPT (recipient)

maintainer
#4 lore raw
Quoted 15 lines · Dave Jones
Quoted 13 lines · Greg KH
Quoted 13 lines
Quoted 12 lines
(quoted diff) +12 -0
+config USB_FOTG210_HCD
+	tristate "FOTG210 HCD support"
+	depends on USB
+	default N
+	---help---
+	  Faraday FOTG210 is an OTG controller which can be configured as
+	  an USB2.0 host. It is designed to meet USB2.0 EHCI specification
+	  with minor modification.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called fotg210-hcd.
+
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Shouldn't this depend on USB_OTG ?
Seems odd to have OTG related options presented to me when I have that unset.

It's a USB Host controller, so it should be built if you have that option set. The fact that it can do OTG isn't an issue here, from what I can tell.

Ok. It still likely needs a 'depends on $ARCH (arm?) | COMPILE_TEST' though.

Probably, yes.

Quoted 7 lines

PS: What happened with this driver ?

This patch landed twice in your tree, once in 1dd3d123239179fad5de5dc00a6e0014a1918fde from Yuan-Hsin Chen <[email protected]> and then in 7d50195f6c5005d6ae7a789d9a7f0a94d104ee96 from Feng-Hsin Chiang <[email protected]>

Given the former address seems to be broken, perhaps all those mentions of it in the faraday sources need updating ?

I thought they had all been fixed up. The first version was dropped because the maintainer no longer worked for the company (as you found out), so I needed a new developer to step up and support it.

thanks,

greg k-h

author
#5 lore raw
Quoted 7 lines · Greg KH
Quoted 5 lines · Dave Jones

PS: What happened with this driver ?

This patch landed twice in your tree, once in 1dd3d123239179fad5de5dc00a6e0014a1918fde from Yuan-Hsin Chen <[email protected]> and then in 7d50195f6c5005d6ae7a789d9a7f0a94d104ee96 from Feng-Hsin Chiang <[email protected]>

Quoted 6 lines
Quoted 2 lines

Given the former address seems to be broken, perhaps all those mentions of it in the faraday sources need updating ?

I thought they had all been fixed up. The first version was dropped because the maintainer no longer worked for the company (as you found out), so I needed a new developer to step up and support it.

He's still mentioned in a bunch of MODULE_AUTHOR's.
While it seems sort of rude to delete mention of someones work, having a dead email address seems bad form too. Perhaps the patch below ?

Dave

Update the MODULE_AUTHOR field of the Faraday OTG drivers to reflect current maintainers email address.

drivers/usb/gadget/fotg210-udc.c +1 -1
index 32db2ee..bbbfd19 100644
@@ -1214,6 +1214,6 @@ static struct platform_driver fotg210_driver = {
 
 module_platform_driver(fotg210_driver);
 
-MODULE_AUTHOR("Yuan-Hsin Chen <[email protected]>");
+MODULE_AUTHOR("Yuan-Hsin Chen, Feng-Hsin Chiang <[email protected]>");
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION(DRIVER_DESC);
drivers/usb/gadget/fusb300_udc.c +1 -1
index f1dd6da..b278abe 100644
@@ -22,7 +22,7 @@
 
 MODULE_DESCRIPTION("FUSB300  USB gadget driver");
 MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Yuan Hsin Chen <[email protected]>");
+MODULE_AUTHOR("Yuan-Hsin Chen, Feng-Hsin Chiang <[email protected]>");
 MODULE_ALIAS("platform:fusb300_udc");
 
 #define DRIVER_VERSION	"20 October 2010"
maintainer
#6 lore raw
Quoted 11 lines · Dave Jones
Quoted 10 lines · Greg KH
Quoted 7 lines · Dave Jones

PS: What happened with this driver ?

This patch landed twice in your tree, once in 1dd3d123239179fad5de5dc00a6e0014a1918fde from Yuan-Hsin Chen <[email protected]> and then in 7d50195f6c5005d6ae7a789d9a7f0a94d104ee96 from Feng-Hsin Chiang <[email protected]>

Given the former address seems to be broken, perhaps all those mentions of it in the faraday sources need updating ?

Quoted 7 lines
Quoted 3 lines

I thought they had all been fixed up. The first version was dropped because the maintainer no longer worked for the company (as you found out), so I needed a new developer to step up and support it.

He's still mentioned in a bunch of MODULE_AUTHOR's.
While it seems sort of rude to delete mention of someones work, having a dead email address seems bad form too. Perhaps the patch below ?

That looks good, I'll queue it up, thanks.

greg k-h