amd64_edac: Add ECC decoding support for newer F15h models
Quoted 10 lines · Linux Kernel
Gitweb: http://git.kernel.org/linus/;a=commit;h=18b94f66f9537003cee30d475d79a57c58f1e1d8 Commit: 18b94f66f9537003cee30d475d79a57c58f1e1d8 Parent: 7d64ac6422092adbbdaa279ab32f9d4c90a84558 Author: Aravind Gopalakrishnan <[email protected]> AuthorDate: Fri Aug 9 11:54:49 2013 -0500 Committer: Borislav Petkov <[email protected]> CommitDate: Mon Aug 12 16:00:10 2013 +0200
amd64_edac: Add ECC decoding support for newer F15h models
Review
Quoted 5 lines
(quoted diff) +5
-0+static int f15_m30h_match_to_this_node(struct amd64_pvt *pvt, unsigned range, + u64 sys_addr, int *chan_sel) +{ + ... + u8 channel, alias_channel, leg_mmio_hole, dct_sel, dct_offset_en;
^^^^^^^^^^
Review
Quoted 9 lines
(quoted diff) +9
-0+ + .... + + channel = f15_m30h_determine_channel(pvt, sys_addr, intlv_en, + num_dcts_intlv, dct_sel); + + /* Verify we stay within the MAX number of channels allowed */ + if (channel > 4 || channel < 0) + return -EINVAL;
Channel will never be < 0, as it's unsigned.
Dave
Quoted 1 line · Dave Jones
Channel will never be < 0, as it's unsigned.
Yes, Aravind, please take care of this.
Thanks.
Signature · 2 lines
Regards/Gruss, Boris.