perf: potential underflow in perf_sample_ustack_size()
Subsystems (2)
PATCH 1/1 perf: potential underflow in perf_sample_ustack_size()
The code here is trying to ensure that we don't have a "header_size + stack_size" which is more than USHRT_MAX. I changed the overflow check a little to make it more clear.
My concern here is that if "header_size + sizeof(u64)" is very large then we could end up with underflow doing the subtraction and end up with a "stack_size" larger than intended.
I don't know perf well enough to say if this is possible.
kernel/events/core.c +3 -1
@@ -4217,11 +4217,13 @@ perf_sample_ustack_size(u16 stack_size, u16 header_size, header_size +=2 *sizeof (u64);/* Do we fit in with the current stack dump size? */ -if ((u16) (header_size + stack_size) < header_size) { +if (header_size >USHRT_MAX - stack_size) {/* * If we overflow the maximum size for the sample, * we customize the stack dump size to fit in. */ +if (header_size +sizeof (u64) >USHRT_MAX ) +return 0 ; stack_size =USHRT_MAX - header_size -sizeof (u64); stack_size =round_up (stack_size,sizeof (u64)); }
Quoted 17 lines · Dan Carpenter
The code here is trying to ensure that we don't have a "
header_size+stack_size" which is more thanUSHRT_MAX. I changed the overflow check a little to make it more clear.My concern here is that if "
header_size+ sizeof(u64)" is very large then we could end up with underflow doing the subtraction and end up with a "stack_size" larger than intended.I don't know perf well enough to say if this is possible.
Signed-off-by Dan Carpenter <[email protected]>kernel/events/core.c +0
-0
kernel/events/core.c perf_sample_ustack_size(u16 stack_size, u16 header_size, · line 4220
Quoted 5 lines
kernel/events/core.c +1
-1@@ -4217,11 +4217,13 @@ perf_sample_ustack_size(u16 stack_size, u16 header_size, header_size +=2 *sizeof (u64);/* Do we fit in with the current stack dump size? */ -if ((u16) (header_size + stack_size) < header_size) { +if (header_size >USHRT_MAX - stack_size) {
hum, the original check looks clear enough to me
kernel/events/core.c perf_sample_ustack_size(u16 stack_size, u16 header_size, · line 4226
Quoted 6 lines
kernel/events/core.c +2
-0/* * If we overflow the maximum size for the sample, * we customize the stack dump size to fit in. */ +if (header_size +sizeof (u64) >USHRT_MAX ) +return 0 ;
ok, I wonder if we could practically reach header size this big, but it's safer to check
thanks,
jirka
Quoted 3 lines
kernel/events/core.c +0
-0stack_size =USHRT_MAX - header_size -sizeof (u64); stack_size =round_up (stack_size,sizeof (u64)); }