Skip to contentSkip to conversation

ARM: shmobile: Add r8a7790 thermal sensor DT device

PATCH New Magnus Damm 3 participants 6 messages Sep 25, 2013 – Oct 21, 2013

Subsystems (5)
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

PATCH 1/1 ARM: shmobile: Add r8a7790 thermal sensor DT device

From: Magnus Damm <[email protected]>

Hook up the single channel thermal sensor via DT
on r8a7790. The information used by the platform
device has been verified against the data sheet.

---

Written against renesas-devel-20130925

 arch/arm/boot/dts/r8a7790.dtsi         |    7 +++++++
 arch/arm/mach-shmobile/clock-r8a7790.c |    1 +
 2 files changed, 8 insertions(+)
arch/arm/boot/dts/r8a7790.dtsi +7 -0
@@ -87,6 +87,13 @@
 		interrupts = <1 9 0xf04>;
 	};
 
+	thermal at e61f0000 {
+		compatible = "renesas,rcar-thermal";
+		reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>;
+		interrupt-parent = <&gic>;
+		interrupts = <0 69 4>;
+	};
+
 	gpio0: gpio at ffc40000 {
 		compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar";
 		reg = <0 0xffc40000 0 0x2c>;
arch/arm/mach-shmobile/clock-r8a7790.c +1 -0
@@ -272,6 +272,7 @@ static struct clk_lookup lookups[] = {
 	CLKDEV_DEV_ID("sh-sci.8", &mstp_clks[MSTP717]),
 	CLKDEV_DEV_ID("sh-sci.9", &mstp_clks[MSTP716]),
 	CLKDEV_DEV_ID("r8a7790-ether", &mstp_clks[MSTP813]),
+	CLKDEV_DEV_ID("e61f0000.thermal", &mstp_clks[MSTP522]),
 	CLKDEV_DEV_ID("rcar_thermal", &mstp_clks[MSTP522]),
 	CLKDEV_DEV_ID("ee200000.mmcif", &mstp_clks[MSTP315]),
 	CLKDEV_DEV_ID("sh_mmcif.0", &mstp_clks[MSTP315]),
#1 lore raw

PATCH 1/1 ARM: shmobile: Add r8a7790 thermal sensor DT device

Quoted 7 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Hook up the single channel thermal sensor via DT
on r8a7790. The information used by the platform
device has been verified against the data sheet.

Hi Magnus,

I would prefer if this was split into two patches. An SoC patch that updates clock-r8a7790.c. And a DT patch which updates r8a7790.dtsi.

Thanks

Quoted 39 lines

---

Written against renesas-devel-20130925

 arch/arm/boot/dts/r8a7790.dtsi         |    7 +++++++
 arch/arm/mach-shmobile/clock-r8a7790.c |    1 +
 2 files changed, 8 insertions(+)
arch/arm/boot/dts/r8a7790.dtsi +7 -0
@@ -87,6 +87,13 @@
 		interrupts = <1 9 0xf04>;
 	};
 
+	thermal at e61f0000 {
+		compatible = "renesas,rcar-thermal";
+		reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>;
+		interrupt-parent = <&gic>;
+		interrupts = <0 69 4>;
+	};
+
 	gpio0: gpio at ffc40000 {
 		compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar";
 		reg = <0 0xffc40000 0 0x2c>;
arch/arm/mach-shmobile/clock-r8a7790.c +1 -1
@@ -272,6 +272,7 @@ static struct clk_lookup lookups[] = {
 	CLKDEV_DEV_ID("sh-sci.8", &mstp_clks[MSTP717]),
 	CLKDEV_DEV_ID("sh-sci.9", &mstp_clks[MSTP716]),
 	CLKDEV_DEV_ID("r8a7790-ether", &mstp_clks[MSTP813]),
+	CLKDEV_DEV_ID("e61f0000.thermal", &mstp_clks[MSTP522]),
 	CLKDEV_DEV_ID("rcar_thermal", &mstp_clks[MSTP522]),
 	CLKDEV_DEV_ID("ee200000.mmcif", &mstp_clks[MSTP315]),
 	CLKDEV_DEV_ID("sh_mmcif.0", &mstp_clks[MSTP315]),
--

To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#2 lore raw

PATCH 1/1 ARM: shmobile: Add r8a7790 thermal sensor DT device

Quoted 7 lines · Simon Horman
Quoted 6 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Hook up the single channel thermal sensor via DT
on r8a7790. The information used by the platform
device has been verified against the data sheet.

Quoted 7 lines
Quoted 1 line

Hi Magnus,

I would prefer if this was split into two patches. An SoC patch that updates clock-r8a7790.c. And a DT patch which updates r8a7790.dtsi.

Sure, that's fine with me. I will do that from now on.

I believe that common clock framework will allow us to handle all within a single dtsi patch.

Cheers,

/ magnus

#3 lore raw

PATCH 1/1 ARM: shmobile: Add r8a7790 thermal sensor DT device

Quoted 10 lines · Magnus Damm
Quoted 9 lines · Simon Horman
Quoted 7 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Hook up the single channel thermal sensor via DT
on r8a7790. The information used by the platform
device has been verified against the data sheet.

Quoted 7 lines
Quoted 5 lines

Hi Magnus,

I would prefer if this was split into two patches. An SoC patch that updates clock-r8a7790.c. And a DT patch which updates r8a7790.dtsi.

Sure, that's fine with me. I will do that from now on.

Thanks. I'm trying to reduce dependencies/conflicts between branches. I'm not sure how well it will pan out. But that is my aim at the moment.

Quoted 2 lines

I believe that common clock framework will allow us to handle all within a single dtsi patch.

Excellent.

#4 lore raw

PATCH 1/1 ARM: shmobile: Add r8a7790 thermal sensor DT device

Hi Simon, Magnus

Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
Quoted 5 lines

Hook up the single channel thermal sensor via DT
on r8a7790. The information used by the platform
device has been verified against the data sheet.

Hi Magnus,

I would prefer if this was split into two patches. An SoC patch that updates clock-r8a7790.c. And a DT patch which updates r8a7790.dtsi.

Quoted 8 lines
Quoted 1 line

Sure, that's fine with me. I will do that from now on.

Thanks. I'm trying to reduce dependencies/conflicts between branches. I'm not sure how well it will pan out. But that is my aim at the moment.

Quoted 2 lines

I believe that common clock framework will allow us to handle all within a single dtsi patch.

About thermal on H2/M2 (= Gen2),
I am concerned about whether Gen1/Gen2 thermal chip have a compatible, since H2 datasheet v0.05 <-> v0.6 seems have different register mapping, and M2 is very different from Gen1.
Now, I'm confirming about it

Best regards
---
Kuninori Morimoto

#5 lore raw

PATCH 1/1 ARM: shmobile: Add r8a7790 thermal sensor DT device

Hi Simon, Magnus

Quoted 18 lines
Quoted 18 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

Hook up the single channel thermal sensor via DT
on r8a7790. The information used by the platform
device has been verified against the data sheet.

Quoted 7 lines
Quoted 5 lines

Hi Magnus,

I would prefer if this was split into two patches. An SoC patch that updates clock-r8a7790.c. And a DT patch which updates r8a7790.dtsi.

Sure, that's fine with me. I will do that from now on.

Thanks. I'm trying to reduce dependencies/conflicts between branches. I'm not sure how well it will pan out. But that is my aim at the moment.

Quoted 8 lines
Quoted 2 lines
Quoted 2 lines

I believe that common clock framework will allow us to handle all within a single dtsi patch.

About thermal on H2/M2 (= Gen2),
I am concerned about whether Gen1/Gen2 thermal chip have a compatible, since H2 datasheet v0.05 <-> v0.6 seems have different register mapping, and M2 is very different from Gen1.
Now, I'm confirming about it

Sorry, It seems my mistake.
H2 thermal seems no problem.

Best regards
---
Kuninori Morimoto