ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio
PATCH 1/1 ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio
As defined in the DT, clkout2 is not allowed to change the pll inside si5351.
This patch inverts the properties of the clkout{1,2} so that clkout2 may be defined as the external clock of the audio device in the Cubox.
Signed-off-by Jean-Francois Moine <[email protected]>
--- arch/arm/boot/dts/dove-cubox.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/dove-cubox.dts +2 -2
@@ -101,16 +101,16 @@ clkout1 { reg = <1>; - silabs,drive-strength = <8>; silabs,multisynth-source = <1>; silabs,clock-source = <0>; - silabs,pll-master; }; clkout2 { reg = <2>; + silabs,drive-strength = <8>; silabs,multisynth-source = <1>; silabs,clock-source = <0>; + silabs,pll-master; }; }; };
Quoted 16 lines · Jean-Francois Moine
As defined in the DT, clkout2 is not allowed to change the pll inside si5351.
This patch inverts the properties of the clkout{1,2} so that clkout2 may be defined as the external clock of the audio device in the Cubox.
Signed-off-by Jean-Francois Moine <[email protected]>--- arch/arm/boot/dts/dove-cubox.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/dove-cubox.dts +0
-0
arch/arm/boot/dts/dove-cubox.dts line 106
Quoted 8 lines
arch/arm/boot/dts/dove-cubox.dts +0
-2@@ -101,16 +101,16 @@ clkout1 { reg = <1>; - silabs,drive-strength = <8>; silabs,multisynth-source = <1>; silabs,clock-source = <0>; - silabs,pll-master; };
Jean-Francois,
thanks for the patch! If we have no use for clkout1 at all on CuBox, we can also remove the above completely.
For this or an updated patch which removes clkout1 completely:
Quoted 10 lines
arch/arm/boot/dts/dove-cubox.dts +2
-0clkout2 { reg = <2>; + silabs,drive-strength = <8>; silabs,multisynth-source = <1>; silabs,clock-source = <0>; + silabs,pll-master; }; }; };