Skip to contentSkip to conversation

ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio

PATCH Superseded Jean-Francois Moine 2 participants 2 messages Oct 4, 2013 Device tree bindings

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio

As defined in the DT, clkout2 is not allowed to change the pll inside si5351.

This patch inverts the properties of the clkout{1,2} so that clkout2 may be defined as the external clock of the audio device in the Cubox.

---
 arch/arm/boot/dts/dove-cubox.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/dove-cubox.dts +2 -2
index 022646e..5d1ece1 100644
@@ -101,16 +101,16 @@
 
 		clkout1 {
 			reg = <1>;
-			silabs,drive-strength = <8>;
 			silabs,multisynth-source = <1>;
 			silabs,clock-source = <0>;
-			silabs,pll-master;
 		};
 
 		clkout2 {
 			reg = <2>;
+			silabs,drive-strength = <8>;
 			silabs,multisynth-source = <1>;
 			silabs,clock-source = <0>;
+			silabs,pll-master;
 		};
 	};
 };
Acked-by on v1 1/1
#1 lore raw
Quoted 16 lines · Jean-Francois Moine

As defined in the DT, clkout2 is not allowed to change the pll inside si5351.

This patch inverts the properties of the clkout{1,2} so that clkout2 may be defined as the external clock of the audio device in the Cubox.

---
  arch/arm/boot/dts/dove-cubox.dts | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/dove-cubox.dts +0 -0
index 022646e..5d1ece1 100644

arch/arm/boot/dts/dove-cubox.dts line 106

Quoted 8 lines
arch/arm/boot/dts/dove-cubox.dts +0 -2
@@ -101,16 +101,16 @@
 
  		clkout1 {
  			reg = <1>;
-			silabs,drive-strength = <8>;
  			silabs,multisynth-source = <1>;
  			silabs,clock-source = <0>;
-			silabs,pll-master;
  		};

Jean-Francois,

thanks for the patch! If we have no use for clkout1 at all on CuBox, we can also remove the above completely.

For this or an updated patch which removes clkout1 completely:

Quoted 10 lines
arch/arm/boot/dts/dove-cubox.dts +2 -0
  		clkout2 {
  			reg = <2>;
+			silabs,drive-strength = <8>;
  			silabs,multisynth-source = <1>;
  			silabs,clock-source = <0>;
+			silabs,pll-master;
  		};
  	};
  };