checkpatch.pl: Check for the FSF mailing address
PATCH 1/1 checkpatch.pl: Check for the FSF mailing address
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
---
Inspired by Greg's standard response to omit the paragraph "unless you want to track the movements of the FSF's office for the next 40 years."
scripts/checkpatch.pl | 10 ++++++++++ 1 file changed, 10 insertions(+)
scripts/checkpatch.pl +10 -0
@@ -1859,6 +1859,16 @@ sub process { $rpt_cleaners = 1; } +# Check for FSF mailing addresses. + if ($rawline =~ /You should have received a copy/ || + $rawline =~ /write to the Free Software/ || + $rawline =~ /59 Temple Place/ || + $rawline =~ /51 Franklin Street/) { + my $herevet = "$here\n" . cat_vet($rawline) . "\n"; + ERROR("FSF_MAILING_ADDRESS", + "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet) + } + # check for Kconfig help text having a real description # Only applies when adding the entry originally, after that we do not have # sufficient context to determine whether it is indeed long enough.
Signature · 1 line
1.8.4.rc3
Joe Perches
maintainerQuoted 3 lines · Josh Triplett
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
[]
scripts/checkpatch.pl
Quoted 1 line
scripts/checkpatch.pl +0
-0
[]
scripts/checkpatch.pl sub process { · line 1863
Quoted 6 lines
scripts/checkpatch.pl +2
-0@@ -1859,6 +1859,16 @@ sub process { $rpt_cleaners = 1; } +# Check for FSF mailing addresses. + if ($rawline =~ /You should have received a copy/ ||
There are over 9,000 of these in the tree.
scripts/checkpatch.pl sub process { · line 1864
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /write to the Free Software/ ||
Over 7,000
scripts/checkpatch.pl sub process { · line 1865
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /59 Temple Place/ ||
Over 3,500
scripts/checkpatch.pl sub process { · line 1866
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /51 Franklin Street/) {
Over 1,500
scripts/checkpatch.pl sub process { · line 1869
Quoted 3 lines
scripts/checkpatch.pl +3
-0+ my $herevet = "$here\n" . cat_vet($rawline) . "\n"; + ERROR("FSF_MAILING_ADDRESS", + "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
Is this really a useful ERROR condition?
Maybe a CHK --strict test or a warning instead?
Quoted 20 lines · Joe Perches
Quoted 3 lines · Josh Triplett
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
[]
scripts/checkpatch.pl
Quoted 1 line
scripts/checkpatch.pl +0
-0[]
scripts/checkpatch.pl sub process { · line 1863
Quoted 6 lines
scripts/checkpatch.pl +2
-0@@ -1859,6 +1859,16 @@ sub process { $rpt_cleaners = 1; } +# Check for FSF mailing addresses. + if ($rawline =~ /You should have received a copy/ ||There are over 9,000 of these in the tree.
scripts/checkpatch.pl sub process { · line 1864
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /write to the Free Software/ ||Over 7,000
Quoted 7 lines
scripts/checkpatch.pl sub process { · line 1865
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /59 Temple Place/ ||Over 3,500
scripts/checkpatch.pl sub process { · line 1866
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /51 Franklin Street/) {Over 1,500
And there shouldn't be any more added. (Also, case in point, note that the FSF is no longer at "59 Temple Place".)
Quoted 6 lines
scripts/checkpatch.pl sub process { · line 1869
Quoted 3 lines
scripts/checkpatch.pl +3
-0+ my $herevet = "$here\n" . cat_vet($rawline) . "\n"; + ERROR("FSF_MAILING_ADDRESS", + "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)Is this really a useful ERROR condition?
Maybe a CHK --strict test or a warning instead?
How about making it a hard ERROR in patch mode, making "59 Temple Place" an error in any mode, and making the other lines only warnings in file mode?
Note that I made it an error because for many maintainers it's an automatic patch rejection.
- Josh Triplett
Greg Kroah-Hartman
Acked-byQuoted 20 lines · Joe Perches
Quoted 3 lines · Josh Triplett
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
[]
scripts/checkpatch.pl
Quoted 1 line
scripts/checkpatch.pl +0
-0[]
scripts/checkpatch.pl sub process { · line 1863
Quoted 6 lines
scripts/checkpatch.pl +2
-0@@ -1859,6 +1859,16 @@ sub process { $rpt_cleaners = 1; } +# Check for FSF mailing addresses. + if ($rawline =~ /You should have received a copy/ ||There are over 9,000 of these in the tree.
scripts/checkpatch.pl sub process { · line 1864
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /write to the Free Software/ ||Over 7,000
Quoted 7 lines
scripts/checkpatch.pl sub process { · line 1865
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /59 Temple Place/ ||Over 3,500
scripts/checkpatch.pl sub process { · line 1866
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /51 Franklin Street/) {Over 1,500
Then we should remove them all. I know some FSF members have tried to do a sweep of the kernel tree at times to at least get rid of the old physical address, but it looks like that didn't work very well.
I don't want to see this get worse over time, Josh, thanks for doing this checkpatch patch.
Joe Perches
maintainerQuoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Joe Perches
Quoted 3 lines · Josh Triplett
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
[]
scripts/checkpatch.pl
Quoted 1 line
scripts/checkpatch.pl +0
-0[]
scripts/checkpatch.pl sub process { · line 1863
Quoted 2 lines
scripts/checkpatch.pl +2
-0+# Check for FSF mailing addresses. + if ($rawline =~ /You should have received a copy/ ||There are over 9,000 of these in the tree.
Quoted 8 lines
Quoted 6 lines
scripts/checkpatch.pl sub process { · line 1864
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /write to the Free Software/ ||Over 7,000
scripts/checkpatch.pl sub process { · line 1865
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /59 Temple Place/ ||Over 3,500
scripts/checkpatch.pl sub process { · line 1866
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /51 Franklin Street/) {Over 1,500
Then we should remove them all.
[]
Quoted 2 lines
I don't want to see this get worse over time, Josh, thanks for doing this checkpatch patch.
What about the warranty disclaimer?
This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
Quoted 24 lines · Joe Perches
Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Joe Perches
Quoted 3 lines · Josh Triplett
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
[]
scripts/checkpatch.pl
Quoted 1 line
scripts/checkpatch.pl +0
-0[]
scripts/checkpatch.pl sub process { · line 1863
Quoted 2 lines
scripts/checkpatch.pl +2
-0+# Check for FSF mailing addresses. + if ($rawline =~ /You should have received a copy/ ||There are over 9,000 of these in the tree.
Quoted 8 lines
Quoted 6 lines
scripts/checkpatch.pl sub process { · line 1864
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /write to the Free Software/ ||Over 7,000
scripts/checkpatch.pl sub process { · line 1865
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /59 Temple Place/ ||Over 3,500
scripts/checkpatch.pl sub process { · line 1866
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /51 Franklin Street/) {Over 1,500
Then we should remove them all.
[]
Quoted 2 lines
I don't want to see this get worse over time, Josh, thanks for doing this checkpatch patch.
Quoted 6 lines
What about the warranty disclaimer?
This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
As an individual file is not the sum of the "program", I would argue that it is not needed, but some companies like to feel better by adding it. So I really don't mind either way, as it would involve arguing with lawyers about this type of thing, and I do enough of that already that I don't go out of my way to do it more...
thanks,
greg k-h
Quoted 5 lines · Greg Kroah-Hartman
As an individual file is not the sum of the "program", I would argue that it is not needed, but some companies like to feel better by adding it. So I really don't mind either way, as it would involve arguing with lawyers about this type of thing, and I do enough of that already that I don't go out of my way to do it more...
What about a short sentence pointing at 'COPYING' instead?
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--Quoted 8 lines · Borislav Petkov
Quoted 5 lines · Greg Kroah-Hartman
As an individual file is not the sum of the "program", I would argue that it is not needed, but some companies like to feel better by adding it. So I really don't mind either way, as it would involve arguing with lawyers about this type of thing, and I do enough of that already that I don't go out of my way to do it more...
What about a short sentence pointing at 'COPYING' instead?
Why? What would that do?
Listen, all we really need is a short one or two line "this file is released under the FOO license" in the file. The SPDX project has the shortend tags that can be used for it, and someone should be marking up the whole kernel with them soon, which will be good.
Otherwise, it's up to the contributor, what they want to have in the file. But wrong addresses isn't ok, I'm sure we can all agree about that.
thanks,
greg k-h
Quoted 11 lines · Greg Kroah-Hartman
Quoted 8 lines · Borislav Petkov
Quoted 5 lines · Greg Kroah-Hartman
As an individual file is not the sum of the "program", I would argue that it is not needed, but some companies like to feel better by adding it. So I really don't mind either way, as it would involve arguing with lawyers about this type of thing, and I do enough of that already that I don't go out of my way to do it more...
What about a short sentence pointing at 'COPYING' instead?
Why? What would that do?
Save us the short one or two lines "this file is ..."
Quoted 2 lines
Listen, all we really need is a short one or two line "this file is released under the FOO license" in the file. The SPDX project has the
All I'm suggesting is that it might be even simpler to add
"See COPYING in the kernel source repository for the license of this file."
or a similar text as COPYING contains the full text of the license. Basically a pointer to it.
This has the added advantage to your short line that it points to the exact license text and lawyers are happy.
<snip stuff we agree about anyway>
Thanks.
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--Quoted 27 lines · Joe Perches
Quoted 3 lines · Greg Kroah-Hartman
Quoted 2 lines · Joe Perches
Quoted 1 line · Josh Triplett
Kernel maintainers reject new instances of the GPL boilerplate
paragraph
Quoted 1 line
Quoted 1 line
Quoted 1 line
directing people to write to the FSF for a copy of the GPL,
since the
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
FSF has moved in the past and may do so again.
[]
scripts/checkpatch.pl
Quoted 1 line
scripts/checkpatch.pl +0
-0[]
scripts/checkpatch.pl
Quoted 2 lines
scripts/checkpatch.pl +2
-0+# Check for FSF mailing addresses. + if ($rawline =~ /You should have received acopy/ ||
Quoted 9 lines
Quoted 7 lines
There are over 9,000 of these in the tree.
scripts/checkpatch.pl sub process { · line 1864
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /write to the Free Software/ ||Over 7,000
scripts/checkpatch.pl sub process { · line 1865
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /59 Temple Place/ ||Over 3,500
scripts/checkpatch.pl sub process { · line 1866
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /51 Franklin Street/) {Over 1,500
Then we should remove them all.
[]
Quoted 2 lines
I don't want to see this get worse over time, Josh, thanks for doing this checkpatch patch.
Quoted 6 lines
What about the warranty disclaimer?
This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
It's a historical artifact with little if any legal meaning, but lawyers love ass-covering so they'll never tell you to remove a raincoat just beacause you live in a desert?
A) It's still in the top level license file (and if you're using a distro that has its own collective boilerplate).
If having it in the program's license file isn't enough, why would having it at the top of some files help? (Would having it block copied before every single function be enough? How about between every line of code? THIS line has no warantee. THIS line has no warantee either.)
B) If you have deep enough pockets to be a target they'll go after you with a spurious patent suit, not a spurious liability suit.
C) Does your blog have a liability disclaimer? When you visit a website like google.com, does it present you with a liability disclaimer on each page? (You can navigate to site terms if you try hard enough, but "oh no please don't sue us for this thing you never gave us any money for and volunteered to use in the first place" is not the first thing that comes to mind.)
D) Please show me the high profile lawsuit that made people start doing this. We started signed-off-by after SCO filed suit, where's the suit that made people do this? I just pulled my copy of Lawrence Graham's "Legal Battles that Shaped the Computer Industry" off the shelf and neither "Warantee" nor "Disclaimer" are listed in the index.
As far as I can tell current usage is one of those anklets that keep sharks away on dry land. ("But there are no sharks around here." "See, it's working!" Complete security blanket.)
ORIGINAL usage seems to have been an attempt at coming up with more legal boilerplate to look big in the early 80's back before the Apple vs Franklin decision extended copyright to cover binaries in 1983. When I got a copy of Zork for my commodore 64 in 1982 of course Infocom had a card in the box full of big words, saber rattling with meaningless legal boilerplate to scare people into "don't copy that floppy" when it wasn't actually illegal to do so yet. (This evolved into the "shrinkwrap license" nonsense a few years later; by breaking the shrinkwrap you agree to the license in the box which you can't read without breaking the shrinkwrap, oh yeah THAT instance of "informed consent" will hold up in court. Yet software manufacturers did it widely for many years before the DMCA made it even sort of greyish. Impressive looking legal documents that would never hold up in court are as old as the hills...)
No lawyer will ever tell you _not_ to gratuitously cover your ass, especially if everybody _else_ is carrying crosses to ward off vampires and fully prepared for the coming zombie apocalypse. But where is an example of this ever having been a real threat on the level of spurious patent suits?
Where are the lawsuits against qmail, whose author famously refused to license his code at all for over a decade, and when he did get explicit about it he didn't bother with a warantee disclaimer:
http://cr.yp.to/qmail/dist.html
Or how about libtomcrypt (at the heart of things like the dropbear ssh implementation) which has a dual license:
https://github.com/libtom/libtomcrypt/blob/master/LICENSE
There are hundreds of such packages out there, and we happily use 'em. Anyone come up with a warantee lawsuit against someone without a disclaimer? Anyone? Bueller? Bueller?
(tl;dr I strongly suspect _one_ Linus Blanket is enough for the tree. The one in COPYING.)
Rob
(I'd love to be corrected on this, I've been looking for years. Nobody knows, they just keep doing it "just in case". Things like http://www.contractstandards.com/contract-structure/representations-and-warranties/software-warranty say "Under common law an implied warranty is applied to the sale of real property and goods." but there's no _sale_ of a free download, and even that goes on in the next paragraph to say nobody ever does this in software, I.E. it's NOT common there. And don't get me started on the places that can't distinguish between a contract and a license...)
(Oh, did I mention that the lawyers at the Software Freedom Law Center were of the opinion that changing the legal boilerplate at the top of the files AT ALL, even to correct inaccurate information, was a violation of GPLv2? See "the last straw" in https://lwn.net/Articles/202120/ except, like patents, it's apparently ok to do if you don't know about it so don't read it! Sigh...)
Quoted 18 lines · Borislav Petkov
Quoted 11 lines · Greg Kroah-Hartman
Quoted 8 lines · Borislav Petkov
Quoted 5 lines · Greg Kroah-Hartman
As an individual file is not the sum of the "program", I would argue that it is not needed, but some companies like to feel better by adding it. So I really don't mind either way, as it would involve arguing with lawyers about this type of thing, and I do enough of that already that I don't go out of my way to do it more...
What about a short sentence pointing at 'COPYING' instead?
Why? What would that do?
Save us the short one or two lines "this file is ..."
Quoted 2 lines
Listen, all we really need is a short one or two line "this file is released under the FOO license" in the file. The SPDX project has the
Quoted 6 lines
All I'm suggesting is that it might be even simpler to add
"See COPYING in the kernel source repository for the license of this file."
or a similar text as COPYING contains the full text of the license. Basically a pointer to it.
You can do that, but I know a whole lot of lawyers who will not like that, as you aren't being explicit about what the license of the file is, and relying on something else.
Remember, Linux kernel source files are licensed with all sorts of different licenses, all of which are compatable and default to GPL when used as a whole, but can be different on their own.
Quoted 2 lines
This has the added advantage to your short line that it points to the exact license text and lawyers are happy.
Lawyers, just like kernel developers, are never happy, it's not in their nature...
greg k-h
Quoted 3 lines · Greg Kroah-Hartman
You can do that, but I know a whole lot of lawyers who will not like that, as you aren't being explicit about what the license of the file is, and relying on something else.
I was afraid that some legal-profession-mumbo-jumbo would require the explicit stating of the license in *every* goddam file. Oh well...
Quoted 3 lines
Remember, Linux kernel source files are licensed with all sorts of different licenses, all of which are compatable and default to GPL when used as a whole, but can be different on their own.
Right.
Quoted 2 lines
Lawyers, just like kernel developers, are never happy, it's not in their nature...
Why am I not surprised?! :-)
Thanks.
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--Quoted 24 lines · Joe Perches
Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Joe Perches
Quoted 3 lines · Josh Triplett
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
[]
scripts/checkpatch.pl
Quoted 1 line
scripts/checkpatch.pl +0
-0[]
scripts/checkpatch.pl sub process { · line 1863
Quoted 2 lines
scripts/checkpatch.pl +2
-0+# Check for FSF mailing addresses. + if ($rawline =~ /You should have received a copy/ ||There are over 9,000 of these in the tree.
Quoted 8 lines
Quoted 6 lines
scripts/checkpatch.pl sub process { · line 1864
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /write to the Free Software/ ||Over 7,000
scripts/checkpatch.pl sub process { · line 1865
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /59 Temple Place/ ||Over 3,500
scripts/checkpatch.pl sub process { · line 1866
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /51 Franklin Street/) {Over 1,500
Then we should remove them all.
[]
Quoted 2 lines
I don't want to see this get worse over time, Josh, thanks for doing this checkpatch patch.
Quoted 6 lines
What about the warranty disclaimer?
This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
That one doesn't cause any logistical problems the way the FSF's mailing address does, and legal departments may be uncomfortable omitting it, so I don't think it makes sense for checkpatch to flag it.
- Josh Triplett
Quoted 29 lines · Greg Kroah-Hartman
Quoted 20 lines · Joe Perches
Quoted 3 lines · Josh Triplett
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
[]
scripts/checkpatch.pl
Quoted 1 line
scripts/checkpatch.pl +0
-0[]
scripts/checkpatch.pl sub process { · line 1863
Quoted 6 lines
scripts/checkpatch.pl +2
-0@@ -1859,6 +1859,16 @@ sub process { $rpt_cleaners = 1; } +# Check for FSF mailing addresses. + if ($rawline =~ /You should have received a copy/ ||There are over 9,000 of these in the tree.
scripts/checkpatch.pl sub process { · line 1864
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /write to the Free Software/ ||Over 7,000
Quoted 7 lines
scripts/checkpatch.pl sub process { · line 1865
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /59 Temple Place/ ||Over 3,500
scripts/checkpatch.pl sub process { · line 1866
Quoted 1 line
scripts/checkpatch.pl +1
-0+ $rawline =~ /51 Franklin Street/) {Over 1,500
Quoted 8 lines
Then we should remove them all. I know some FSF members have tried to do a sweep of the kernel tree at times to at least get rid of the old physical address, but it looks like that didn't work very well.
I don't want to see this get worse over time, Josh, thanks for doing this checkpatch patch.
Thanks, Greg!
Given this ack, any objections to merging the patch in its current form?
- Josh Triplett
Joe Perches
maintainerQuoted 6 lines · Josh Triplett
Quoted 5 lines · Greg Kroah-Hartman
Quoted 4 lines · Joe Perches
Quoted 3 lines · Josh Triplett
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
[]
Quoted 1 line
any objections to merging the patch in its current form?
Your own suggestion that this be applied only to patches hasn't been implemented.
This patch emits an ERROR not a WARN or CHK.
It encourages people to modify files that may not need modification and there hasn't been any agreement that this is complete.
Quoted 4 lines · Joe Perches
Quoted 3 lines · Josh Triplett
Quoted 2 lines · Greg Kroah-Hartman
Quoted 1 line · Joe Perches
On Sat, 2013-10-05 at 11:43 -0700, Josh Triplett wrote:
Quoted 8 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
[]
Quoted 1 line
any objections to merging the patch in its current form?
Your own suggestion that this be applied only to
patches hasn't been implemented.
Given Greg's comment that we want to eliminate the existing instances, I wanted to make sure implementing that change still makes sense.
I can easily enough make checkpatch emit an ERROR for patches and a WARN or CHK for existing files, if that's the consensus.
- Josh Triplett
Joe Perches
maintainerQuoted 11 lines · Josh Triplett
Quoted 10 lines · Joe Perches
Quoted 6 lines · Josh Triplett
Quoted 5 lines · Greg Kroah-Hartman
Quoted 4 lines · Joe Perches
Quoted 3 lines · Josh Triplett
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
[]
Quoted 1 line
any objections to merging the patch in its current form?
Quoted 8 lines
Quoted 2 lines
Your own suggestion that this be applied only to
patches hasn't been implemented.Given Greg's comment that we want to eliminate the existing instances, I wanted to make sure implementing that change still makes sense.
I can easily enough make checkpatch emit an ERROR for patches and a WARN or CHK for existing files, if that's the consensus.
Hi Josh
Most of the time, action is at least as useful as consensus.
If you do the runtime --file check, please use this form:
my $msg_type = \&WARN;
$msg_type = \&CHK if ($file);
&{$msg_type}("FSF_MESSAGE",
etc...)(that form matches the trigraph test)
Use whatever ERROR/WARN/CHK you think appropriate.
PATCH v2 1/1 checkpatch.pl: Check for the FSF mailing address
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
Make this an error for new code, but just a --strict CHK in --file mode; anyone interested in doing tree-wide cleanups of this form can enable this test explicitly.
---
v2: Make this a CHK in --file mode, using a code pattern suggested by
Joe Perches.
scripts/checkpatch.pl | 12 ++++++++++++ 1 file changed, 12 insertions(+)
scripts/checkpatch.pl +12 -0
@@ -1859,6 +1859,18 @@ sub process { $rpt_cleaners = 1; } +# Check for FSF mailing addresses. + if ($rawline =~ /You should have received a copy/ || + $rawline =~ /write to the Free Software/ || + $rawline =~ /59 Temple Place/ || + $rawline =~ /51 Franklin Street/) { + my $herevet = "$here\n" . cat_vet($rawline) . "\n"; + my $msg_type = \&ERROR; + $msg_type = \&CHK if ($file); + &{$msg_type}("FSF_MAILING_ADDRESS", + "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet) + } + # check for Kconfig help text having a real description # Only applies when adding the entry originally, after that we do not have # sufficient context to determine whether it is indeed long enough.
Signature · 1 line
1.8.4.rc3
Quoted 9 lines · Josh Triplett
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
Make this an error for new code, but just a --strict CHK in --file mode; anyone interested in doing tree-wide cleanups of this form can enable this test explicitly.
Signed-off-by Josh Triplett <[email protected]>
(Adding Andrew Morton)
Quoted 30 lines · Josh Triplett
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again.
Make this an error for new code, but just a --strict CHK in --file mode; anyone interested in doing tree-wide cleanups of this form can enable this test explicitly.
Signed-off-by Josh Triplett <[email protected]>---
v2: Make this a CHK in --file mode, using a code pattern suggested by
Joe Perches.scripts/checkpatch.pl | 12 ++++++++++++ 1 file changed, 12 insertions(+)scripts/checkpatch.pl +5
-0@@ -1859,6 +1859,18 @@ sub process { $rpt_cleaners = 1; } +# Check for FSF mailing addresses. + if ($rawline =~ /You should have received a copy/ || + $rawline =~ /write to the Free Software/ || + $rawline =~ /59 Temple Place/ || + $rawline =~ /51 Franklin Street/) {
scripts/checkpatch.pl sub process { · line 1876
Quoted 10 lines
scripts/checkpatch.pl +7
-0+ my $herevet = "$here\n" . cat_vet($rawline) . "\n"; + my $msg_type = \&ERROR; + $msg_type = \&CHK if ($file); + &{$msg_type}("FSF_MAILING_ADDRESS", + "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet) + } + # check for Kconfig help text having a real description # Only applies when adding the entry originally, after that we do not have # sufficient context to determine whether it is indeed long enough.