USB: cyberjack: fix buggy integer overflow test

PATCH New Dan Carpenter 1 participant 1 message Oct 6, 2013

Subsystems (3)

USB Kernel janitors USB serial

lore

Share & tools

lore

Dan Carpenter

author

2013-10-06 00:32 UTC #0 lore raw

PATCH 1/1 USB: cyberjack: fix buggy integer overflow test

"old_rdtodo" and "size" are short type. They are type promoted to int and the condition is never true.

Signed-off-by Dan Carpenter <[email protected]>

drivers/usb/serial/cyberjack.c +1 -1

index 7814262..6e1b69d 100644
@@ -279,7 +279,7 @@ static void cyberjack_read_int_callback(struct urb *urb)
 
 		old_rdtodo = priv->rdtodo;
 
-		if (old_rdtodo + size < old_rdtodo) {
+		if (old_rdtodo > SHRT_MAX - size) {
 			dev_dbg(dev, "To many bulk_in urbs to do.\n");
 			spin_unlock(&priv->lock);
 			goto resubmit;