yam: remove a no-op in yam_ioctl()

PATCH Applied Dan Carpenter 2 participants 2 messages Oct 14, 2013 – Oct 17, 2013

Subsystems (3)

Networking Network drivers Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2013-10-14 12:46 UTC #0 lore raw

PATCH 1/1 yam: remove a no-op in yam_ioctl()

We overwrite the ->bitrate with the user supplied information on the next line.

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/hamradio/yam.c +0 -1

index 0721e72..5af1c3e 100644
@@ -975,7 +975,6 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 			return -EINVAL;		/* Cannot change this parameter when up */
 		if ((ym = kmalloc(sizeof(struct yamdrv_ioctl_mcs), GFP_KERNEL)) = NULL)
 			return -ENOBUFS;
-		ym->bitrate = 9600;
 		if (copy_from_user(ym, ifr->ifr_data, sizeof(struct yamdrv_ioctl_mcs))) {
 			kfree(ym);
 			return -EFAULT;

David Miller

maintainer Applied

2013-10-17 19:54 UTC #1 lore raw

From: Dan Carpenter <[email protected]>
Date: Mon, 14 Oct 2013 15:46:15 +0300

Quoted 4 lines

We overwrite the ->bitrate with the user supplied information on the next line.
Signed-off-by Dan Carpenter <[email protected]>

Applied.