hwmon: (w83793) Clean up a signedness issue

PATCH Applied Dan Carpenter 2 participants 2 messages Oct 19, 2013

Subsystems (3)

Kernel janitors Hardware monitoring W83793 hardware monitoring driver

lore

Share & tools

lore

Dan Carpenter

author

2013-10-19 09:12 UTC #0 lore raw

PATCH 1/1 hwmon: (w83793) Clean up a signedness issue

We cap the upper bound of "mtimeout" but since it's signed we should check for negative values as well. The mistake is harmless. But I have changed it to unsigned as a cleanup.

Signed-off-by Dan Carpenter <[email protected]>

drivers/hwmon/w83793.c +2 -1

index b6470ec..9d63d71 100644
@@ -1199,7 +1199,8 @@ static void w83793_init_client(struct i2c_client *client)
 
 static int watchdog_set_timeout(struct w83793_data *data, int timeout)
 {
-	int ret, mtimeout;
+	unsigned int mtimeout;
+	int ret;
 
 	mtimeout = DIV_ROUND_UP(timeout, 60);

Guenter Roeck

maintainer Applied

2013-10-19 16:06 UTC #1 lore raw

Quoted 6 lines · Dan Carpenter

We cap the upper bound of "mtimeout" but since it's signed we should check for negative values as well. The mistake is harmless. But I have changed it to unsigned as a cleanup.
Signed-off-by Dan Carpenter <[email protected]>

Applied to -next.

Thanks,
Guenter