Skip to contentSkip to conversation

net: tftpsrv: Get correct client MAC address

PATCH New Andrew Ruder 1 participant 1 message Oct 23, 2013 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: tftpsrv: Get correct client MAC address

NetServerEther was not being cleared in the tftp server code, so the destination MAC address would be whatever the last destination MAC address was.

Scenario:
U-Boot:
dhcp
tftpsrv
Host:
Send device WRQ
Device:
Responds with ACK to dhcp server mac address with host ip address

By clearing NetServerEther, we force a lookup of the host MAC address to go with the associated host IP.

---
 net/tftp.c | 3 +++
 1 file changed, 3 insertions(+)
net/tftp.c +3 -0
index 6d333d5..002052a 100644
@@ -849,6 +849,9 @@ TftpStartServer(void)
 
 	TftpState = STATE_RECV_WRQ;
 	net_set_udp_handler(TftpHandler);
+
+	/* zero out server ether in case the server ip has changed */
+	memset(NetServerEther, 0, 6);
 }
 #endif /* CONFIG_CMD_TFTPSRV */
 
Signature · 1 line
1.8.4.rc3