Skip to contentSkip to conversation

megaraid_sas: make the log message about rescanning more informative.

PATCH In review Jasper Spaans 3 participants 3 messages Oct 25, 2013 – Mar 13, 2014

Subsystems (2)
SCSI Megaraid SCSI/SAS drivers
lore
Share & tools
lore

Jasper Spaans

author
#0 lore raw

PATCH 1/1 megaraid_sas: make the log message about rescanning more informative.

Hi,

I was working on one of our servers, and saw the following interesting message in dmesg:

[20961024.720972] scanning ...

This scared me somewhat. Please find a patch to make it easier to see where this message is coming from.

Cheers,
Jasper

---
 drivers/scsi/megaraid/megaraid_sas_base.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/megaraid/megaraid_sas_base.c +1 -1
index 1f0ca68..3457289 100644
@@ -5461,7 +5461,7 @@ megasas_aen_polling(struct work_struct *work)
 	}
 
 	if (doscan) {
-		printk(KERN_INFO "scanning ...\n");
+		printk(KERN_INFO "Rescanning MegaRAID devices ...\n");
 		megasas_get_pd_list(instance);
 		for (i = 0; i < MEGASAS_MAX_PD_CHANNELS; i++) {
 			for (j = 0; j < MEGASAS_MAX_DEV_PER_CHANNEL; j++) {
Signature · 9 lines
1.7.9.5


-- 
 /\____/\   ir. Jasper Spaans // Lead Developer www.FoxDetACT.com
 \   (_)/   Fox-IT - For a more secure society!
  \    X    T: +31-15-2847999       
   \  / \   M: +31-6-41588725
    \/      KvK Haaglanden 27301624
Acked-by on v1 1/1
#1 lore raw
Quoted 41 lines

-----Original Message-----
From: Jasper Spaans [mailto:[email protected]]
Sent: Friday, October 25, 2013 5:53 PM
To: DL-MegaRAID Linux
Cc: [email protected]
Subject: [PATCH] megaraid_sas: make the log message about rescanning more informative.

Hi,

I was working on one of our servers, and saw the following interesting message in dmesg:

[20961024.720972] scanning ...

This scared me somewhat. Please find a patch to make it easier to see where this message is coming from.

Cheers,
Jasper

---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/megaraid/megaraid_sas_base.c +1 -1
index 1f0ca68..3457289 100644
@@ -5461,7 +5461,7 @@ megasas_aen_polling(struct work_struct *work)
 	}
 
 	if (doscan) {
-		printk(KERN_INFO "scanning ...\n");
+		printk(KERN_INFO "Rescanning MegaRAID devices ...\n");
 		megasas_get_pd_list(instance);
 		for (i = 0; i < MEGASAS_MAX_PD_CHANNELS; i++) {
 			for (j = 0; j < MEGASAS_MAX_DEV_PER_CHANNEL;
Quoted 3 lines

j++) {
--
1.7.9.5

Acked-by Sumit Saxena <[email protected]>

Sumit

Quoted 8 lines

--

/\____/\   ir. Jasper Spaans // Lead Developer www.FoxDetACT.com
\   (_)/   Fox-IT - For a more secure society!
 \    X    T: +31-15-2847999
  \  / \   M: +31-6-41588725
   \/      KvK Haaglanden 27301624
maintainer
#2 lore raw
Quoted 34 lines · Sumit
Quoted 34 lines

-----Original Message-----
From: Jasper Spaans [mailto:[email protected]]
Sent: Friday, October 25, 2013 5:53 PM
To: DL-MegaRAID Linux
Cc: [email protected]
Subject: [PATCH] megaraid_sas: make the log message about rescanning more informative.

Hi,

I was working on one of our servers, and saw the following interesting message in dmesg:

[20961024.720972] scanning ...

This scared me somewhat. Please find a patch to make it easier to see where this message is coming from.

Cheers,
Jasper

---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/megaraid/megaraid_sas_base.c +0 -0
index 1f0ca68..3457289 100644
@@ -5461,7 +5461,7 @@ megasas_aen_polling(struct work_struct *work)
 	}
Quoted 10 lines
Quoted 9 lines
drivers/scsi/megaraid/megaraid_sas_base.c +1 -1
 	if (doscan) {
-		printk(KERN_INFO "scanning ...\n");
+		printk(KERN_INFO "Rescanning MegaRAID devices ...\n");
 		megasas_get_pd_list(instance);
 		for (i = 0; i < MEGASAS_MAX_PD_CHANNELS; i++) {
 			for (j = 0; j < MEGASAS_MAX_DEV_PER_CHANNEL;

j++) {
--
1.7.9.5

Acked-by Sumit Saxena <[email protected]>

I'd prefer consistency for this: Most of the messages in this driver have a megasas: prefix ... but there are quite a large number that don't (and which probably should have). If this is necessary, please use the standard driver prefix.

Thanks,

James