kbuild: replace unbounded sprintf call in modpost
PATCH 1/1 kbuild: replace unbounded sprintf call in modpost
The modpost tool could overflow its stack buffer if someone was running with an insane shell environment. Regardless, it's technically a bug, so this fixes it to truncate the string instead of seg-faulting.
Found by Coverity.
Signed-off-by Kees Cook <[email protected]>
--- scripts/mod/sumversion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/mod/sumversion.c +1 -1
@@ -416,7 +416,7 @@ void get_src_version(const char *modname, char sum[], unsigned sumlen) basename =strrchr (modname,'/' ) +1 ; else basename = modname; -sprintf (filelist,"%s/%.*s.mod" , modverdir, +snprintf (filelist,sizeof (filelist),"%s/%.*s.mod" , modverdir, (int )strlen (basename) -2 , basename); file =grab_file (filelist, &len);
Signature · 6 lines
1.7.9.5 -- Kees Cook Chrome OS Security
Quoted 7 lines · Kees Cook
The modpost tool could overflow its stack buffer if someone was running with an insane shell environment. Regardless, it's technically a bug, so this fixes it to truncate the string instead of seg-faulting.
Found by Coverity.
Signed-off-by Kees Cook <[email protected]>
Applied to kbuild.git#kbuild.
Michal