compat_ioctl: fix an underflow issue (harmless)
Subsystems (2)
PATCH 1/1 compat_ioctl: fix an underflow issue (harmless)
We cap "nmsgs" at I2C_RDRW_IOCTL_MAX_MSGS (42) but the current code allows negative values. It's harmless but it makes my static checker upset so I've made nsmgs unsigned.
Signed-off-by Dan Carpenter <[email protected]>
fs/compat_ioctl.c +2 -1
@@ -680,7 +680,8 @@ static int do_i2c_rdwr_ioctl(unsigned int fd, unsigned int cmd,struct i2c_msg __user *tmsgs;struct i2c_msg32 __user *umsgs;compat_caddr_t datap; -int nmsgs, i; +u32 nmsgs; +int i;if (get_user (nmsgs, &udata->nmsgs))return -EFAULT ;