dmaengine: s3c24xx-dma: make phy->irq signed for error handling
Subsystems (3)
PATCH 1/1 dmaengine: s3c24xx-dma: make phy->irq signed for error handling
There is a bug in s3c24xx_dma_probe() where we do:
phy->irq = platform_get_irq(pdev, i);
if (phy->irq < 0) {The problem is that "phy->irq" is unsigned so the error handling doesn't work. I have changed it to signed.
Signed-off-by Dan Carpenter <[email protected]>
drivers/dma/s3c24xx-dma.c +1 -1
@@ -192,7 +192,7 @@ struct s3c24xx_dma_phy {unsigned int id;bool valid;void __iomem *base; -unsigned int irq; +int irq;struct clk *clk;spinlock_t lock;struct s3c24xx_dma_chan *serving;