dma: pl330: off by one in pl330_probe()

PATCH In review Dan Carpenter 2 participants 2 messages Nov 8, 2013 – Nov 13, 2013

Subsystems (2)

Kernel janitors dmaengine

lore

Share & tools

lore

Dan Carpenter

author

2013-11-08 09:50 UTC #0 lore raw

PATCH 1/2 dma: pl330: off by one in pl330_probe()

There are only AMBA_NR_IRQS (2) elements in adev->irq[]. This code maybe works if the there is a zero directly after the array.

Signed-off-by Dan Carpenter <[email protected]>

drivers/dma/pl330.c +1 -1

index 4b2583c..4af4b0c 100644
@@ -2926,7 +2926,7 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
 
 	amba_set_drvdata(adev, pdmac);
 
-	for (i = 0; i <= AMBA_NR_IRQS; i++) {
+	for (i = 0; i < AMBA_NR_IRQS; i++) {
 		irq = adev->irq[i];
 		if (irq) {
 			ret = devm_request_irq(&adev->dev, irq,

Vinod Koul

2013-11-13 13:32 UTC #1 lore raw

Quoted 2 lines · Dan Carpenter

There are only AMBA_NR_IRQS (2) elements in adev->irq[]. This code maybe works if the there is a zero directly after the array.

Applied both

Thanks
~Vinod

Quoted 16 lines

Signed-off-by Dan Carpenter <[email protected]>

drivers/dma/pl330.c +1 -1

index 4b2583c..4af4b0c 100644
@@ -2926,7 +2926,7 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
 
 	amba_set_drvdata(adev, pdmac);
 
-	for (i = 0; i <= AMBA_NR_IRQS; i++) {
+	for (i = 0; i < AMBA_NR_IRQS; i++) {
 		irq = adev->irq[i];
 		if (irq) {
 			ret = devm_request_irq(&adev->dev, irq,