Skip to contentSkip to conversation

Commit 2108f4c4 causes a warning in 10 ARM boards

U-Boot Albert ARIBAUD 2 participants 3 messages Nov 9, 2013

lore
Share & tools
lore
#0 lore raw

Hi Rob,

Commit 2108f4c4 ("config: consolidate CONFIG_SYS_HZ definition") causes the following boards:

	omap730p2_cs3boot omap730p2_cs0boot scb9328 palmtc balloon3
	mini2440 zipitz2 palmld omap730p2 omap3_zoom2 mx1ads

to emit this warning:

	time.c:12:2: warning: #warning "CONFIG_SYS_HZ must be 1000 and
	should not be defined by platforms" [-Wcpp]

Rob, can you look into it?

Tom: I am preparing a PR from ARM to u-boot; ARM build will obviously fail for these 10 boards unless a fix is applied to u-boot/master before I submit my PR.

Amicalement,

Signature · 1 line
Albert.
#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 10 lines · Albert ARIBAUD

Hi Rob,

Commit 2108f4c4 ("config: consolidate CONFIG_SYS_HZ definition") causes the following boards:

	omap730p2_cs3boot omap730p2_cs0boot scb9328 palmtc balloon3
	mini2440 zipitz2 palmld omap730p2 omap3_zoom2 mx1ads

to emit this warning:

Quoted 8 lines
	time.c:12:2: warning: #warning "CONFIG_SYS_HZ must be 1000 and
	should not be defined by platforms" [-Wcpp]

Rob, can you look into it?

Tom: I am preparing a PR from ARM to u-boot; ARM build will obviously fail for these 10 boards unless a fix is applied to u-boot/master before I submit my PR.

This is intentional, as those boards have CONFIG_SYS_HZ wrong. For the PXA boards, Marek posted a patch that fixes them. For omap730p2* I plan to submit a patch to just yank them out. For the others, we need to find the board maintainer and get them to correct things, or pull them as well.

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSfigPAAoJENk4IS6UOR1WHHcP/Rrk0EF1wuEm8/pQAc1foJQk GWjVxXAZbz8UAKXLxroKUQlEzHyQZNc1kl3pBVF1txm9RaqAQsLNWu6Nro4lmPbE DQVX0/0Elkdq2ZXpW2yw58VwS2IzFvfmw4cx0NkHsRTWLtZ4ZnkTEPoYB4GMY/dJ LzuIw39OI1WhsbZDGvcbI+gT84ytymnahIFO48sd9+CA0UBJPbS8kjAJxKAIY1NK Dnj3JBIp85pANE8BbNf4ZVLt/1AJqAdI8NE3AABhCsQQUFi6bHVqRCrlb2ln9pdG IjvFTYCoQuYoo11XpPImfYEVYWSKLwwDctD6t2YV9qoZNz5KYqR5hNvlsgGIxR30 NHocVoOaAku0XgAXRpIzGqx+lV2dHSY0mgo8C/iY9cJsXe6CmLv8vFPs6K2L2AD8 TC/J0MVdx3x0fgVb1/dnt9ssLqcSGs3ohqnHopzuJlqau2lMJ8jRiwaGo8u9zoJQ 12ZdWkPeRo4varMUC7a5R0ZQ87v5MrXxZaupqvqRg7usndQnhnNmvUoJVwYPjVmB DGqVBxQuOEkqHqoSJK3eCzo2E5+FBmumGgv53padIpTBhvVQuWZGjhhJRqakl1Yy sHMi3hdfz99oFvaYm7rgDwxSAarm1jq37Q1VveUmf7Zc1YRVDxITb9F9P6IVApdU la1SwdmHInTUzt5cjIWv
=/6uD
-----END PGP SIGNATURE-----

#2 lore raw

Hi Tom,

Quoted 23 lines · Tom Rini

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 10 lines · Albert ARIBAUD

Hi Rob,

Commit 2108f4c4 ("config: consolidate CONFIG_SYS_HZ definition") causes the following boards:

	omap730p2_cs3boot omap730p2_cs0boot scb9328 palmtc balloon3
	mini2440 zipitz2 palmld omap730p2 omap3_zoom2 mx1ads

to emit this warning:

Quoted 8 lines
	time.c:12:2: warning: #warning "CONFIG_SYS_HZ must be 1000 and
	should not be defined by platforms" [-Wcpp]

Rob, can you look into it?

Tom: I am preparing a PR from ARM to u-boot; ARM build will obviously fail for these 10 boards unless a fix is applied to u-boot/master before I submit my PR.

Quoted 5 lines

This is intentional, as those boards have CONFIG_SYS_HZ wrong. For the PXA boards, Marek posted a patch that fixes them. For omap730p2* I plan to submit a patch to just yank them out. For the others, we need to find the board maintainer and get them to correct things, or pull them as well.

OK -- sorry for the noise, then.

Amicalement,

Signature · 1 line
Albert.