arm: omap3: Enable clocks for peripherals only if they are used
PATCH 1/1 arm: omap3: Enable clocks for peripherals only if they are used
Enable clocks for the peripherals only if they are used
--- arch/arm/cpu/armv7/omap3/clock.c | 2 -- arch/arm/include/asm/arch-omap3/clock.h | 2 -- 2 files changed, 4 deletions(-)
arch/arm/cpu/armv7/omap3/clock.c +0 -2
@@ -730,8 +730,6 @@ void per_clocks_enable(void)sr32 (&prcm_base->fclken_cam,0 ,32 ,FCK_CAM_ON );sr32 (&prcm_base->iclken_cam,0 ,32 ,ICK_CAM_ON ); } -sr32 (&prcm_base->fclken_per,0 ,32 ,FCK_PER_ON ); -sr32 (&prcm_base->iclken_per,0 ,32 ,ICK_PER_ON );sdelay (1000 ); }
arch/arm/include/asm/arch-omap3/clock.h +0 -2
@@ -27,8 +27,6 @@#define ICK_DSS_ON 0x00000001#define FCK_CAM_ON 0x00000001#define ICK_CAM_ON 0x00000001 -#define FCK_PER_ON 0x0003ffff -#define ICK_PER_ON 0x0003ffff/* Used to index into DPLL parameter tables */ typedef struct {
Signature · 1 line
1.8.1.2
PATCH 1/1 arm: omap3: Enable clocks for peripherals only if they are used
Hi Michael,
Quoted 13 lines · Michael Trimarchi
Enable clocks for the peripherals only if they are used
Signed-off-by Michael Trimarchi <[email protected]>--- arch/arm/cpu/armv7/omap3/clock.c | 2 -- arch/arm/include/asm/arch-omap3/clock.h | 2 -- 2 files changed, 4 deletions(-)arch/arm/cpu/armv7/omap3/clock.c +0
-0
arch/arm/cpu/armv7/omap3/clock.c void per_clocks_enable(void) · line 734
Quoted 5 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-2@@ -730,8 +730,6 @@ void per_clocks_enable(void)sr32 (&prcm_base->fclken_cam,0 ,32 ,FCK_CAM_ON );sr32 (&prcm_base->iclken_cam,0 ,32 ,ICK_CAM_ON ); } -sr32 (&prcm_base->fclken_per,0 ,32 ,FCK_PER_ON ); -sr32 (&prcm_base->iclken_per,0 ,32 ,ICK_PER_ON );
Hmmm...
Am I missing something or is this change breaks boards that currently rely on the peripheral clocks being enabled here?
Quoted 17 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-0sdelay (1000 ); }arch/arm/include/asm/arch-omap3/clock.h +0
-2@@ -27,8 +27,6 @@#define ICK_DSS_ON 0x00000001#define FCK_CAM_ON 0x00000001#define ICK_CAM_ON 0x00000001 -#define FCK_PER_ON 0x0003ffff -#define ICK_PER_ON 0x0003ffff/* Used to index into DPLL parameter tables */ typedef struct {
Signature · 2 lines
Regards, Igor.
PATCH 1/1 arm: omap3: Enable clocks for peripherals only if they are used
Hi Igor
Quoted 11 lines · Igor Grinberg
Hi Michael,
Quoted 8 lines · Michael Trimarchi
Enable clocks for the peripherals only if they are used
Signed-off-by Michael Trimarchi <[email protected]>--- arch/arm/cpu/armv7/omap3/clock.c | 2 -- arch/arm/include/asm/arch-omap3/clock.h | 2 -- 2 files changed, 4 deletions(-)
Quoted 15 lines
arch/arm/cpu/armv7/omap3/clock.c void per_clocks_enable(void) · line 734
Quoted 10 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-2@@ -730,8 +730,6 @@ void per_clocks_enable(void)sr32 (&prcm_base->fclken_cam,0 ,32 ,FCK_CAM_ON );sr32 (&prcm_base->iclken_cam,0 ,32 ,ICK_CAM_ON ); } -sr32 (&prcm_base->fclken_per,0 ,32 ,FCK_PER_ON ); -sr32 (&prcm_base->iclken_per,0 ,32 ,ICK_PER_ON );Hmmm...
Am I missing something or is this change breaks boards that currently rely on the peripheral clocks being enabled here?
This change break boards that are not correctly configured.
Michael
Quoted 21 lines
Quoted 9 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-0sdelay (1000 ); }arch/arm/include/asm/arch-omap3/clock.h +0
-0arch/arm/include/asm/arch-omap3/clock.h line 32
Quoted 8 lines
arch/arm/include/asm/arch-omap3/clock.h +0
-2@@ -27,8 +27,6 @@#define ICK_DSS_ON 0x00000001#define FCK_CAM_ON 0x00000001#define ICK_CAM_ON 0x00000001 -#define FCK_PER_ON 0x0003ffff -#define ICK_PER_ON 0x0003ffff/* Used to index into DPLL parameter tables */ typedef struct {--
Regards,
Igor.
Signature · 4 lines
| Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL |
PATCH 1/1 arm: omap3: Enable clocks for peripherals only if they are used
Hi Igor
Quoted 30 lines · Michael Trimarchi
Hi Igor
Quoted 11 lines · Igor Grinberg
Hi Michael,
Quoted 8 lines · Michael Trimarchi
Enable clocks for the peripherals only if they are used
Signed-off-by Michael Trimarchi <[email protected]>--- arch/arm/cpu/armv7/omap3/clock.c | 2 -- arch/arm/include/asm/arch-omap3/clock.h | 2 -- 2 files changed, 4 deletions(-)Quoted 15 lines
arch/arm/cpu/armv7/omap3/clock.c void per_clocks_enable(void) · line 734
Quoted 10 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-2@@ -730,8 +730,6 @@ void per_clocks_enable(void)sr32 (&prcm_base->fclken_cam,0 ,32 ,FCK_CAM_ON );sr32 (&prcm_base->iclken_cam,0 ,32 ,ICK_CAM_ON ); } -sr32 (&prcm_base->fclken_per,0 ,32 ,FCK_PER_ON ); -sr32 (&prcm_base->iclken_per,0 ,32 ,ICK_PER_ON );Hmmm...
Am I missing something or is this change breaks boards that currently rely on the peripheral clocks being enabled here?
Quoted 2 lines
This change break boards that are not correctly configured.
To be more clear, this change just enable clocks that are supposed to be used. Now that code was supposed to be removed long time ago.
Michael
Quoted 31 lines
Michael
Quoted 14 lines
Quoted 14 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-0sdelay (1000 ); }arch/arm/include/asm/arch-omap3/clock.h +0
-2@@ -27,8 +27,6 @@#define ICK_DSS_ON 0x00000001#define FCK_CAM_ON 0x00000001#define ICK_CAM_ON 0x00000001 -#define FCK_PER_ON 0x0003ffff -#define ICK_PER_ON 0x0003ffffQuoted 7 lines
arch/arm/include/asm/arch-omap3/clock.h line 32
Quoted 3 lines
arch/arm/include/asm/arch-omap3/clock.h +0
-0/* Used to index into DPLL parameter tables */ typedef struct {--
Regards,
Igor.--
| Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL |
PATCH 1/1 arm: omap3: Enable clocks for peripherals only if they are used
Hi Michael,
Quoted 11 lines · Michael Trimarchi
Hi Igor
Quoted 7 lines · Michael Trimarchi
Hi Igor
Quoted 4 lines · Igor Grinberg
Hi Michael,
Quoted 1 line · Michael Trimarchi
Enable clocks for the peripherals only if they are used
This is not exactly what the patch does, right?
I would expect a better description of what you do in the patch and what are the consequences of this patch.
May be some of the consequences can be avoided?
Quoted 23 lines
Quoted 23 lines
Quoted 22 lines
Quoted 12 lines
Signed-off-by Michael Trimarchi <[email protected]>--- arch/arm/cpu/armv7/omap3/clock.c | 2 -- arch/arm/include/asm/arch-omap3/clock.h | 2 -- 2 files changed, 4 deletions(-)arch/arm/cpu/armv7/omap3/clock.c +0
-0arch/arm/cpu/armv7/omap3/clock.c void per_clocks_enable(void) · line 734
Quoted 5 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-2@@ -730,8 +730,6 @@ void per_clocks_enable(void)sr32 (&prcm_base->fclken_cam,0 ,32 ,FCK_CAM_ON );sr32 (&prcm_base->iclken_cam,0 ,32 ,ICK_CAM_ON ); } -sr32 (&prcm_base->fclken_per,0 ,32 ,FCK_PER_ON ); -sr32 (&prcm_base->iclken_per,0 ,32 ,ICK_PER_ON );Hmmm...
Am I missing something or is this change breaks boards that currently rely on the peripheral clocks being enabled here?
Quoted 1 line
Quoted 1 line
This change break boards that are not correctly configured.
I don't agree on this one.
This change breaks boards that are _correctly_ configured prior to the patch.
As a consequence of this patch, there might be boards that are not correctly configured and thus broken.
In other words, this patch breaks boards that rely on those clocks being enabled.
Quoted 4 lines
Quoted 1 line
To be more clear, this change just enable clocks that are supposed to be used.
Well, if I read the patch correctly, it does not enable anything. It removes the unconditional configuration of some clocks...
Quoted 2 lines
Now that code was supposed to be removed long
time ago.
Were there any discussions on this meter?
Can you please point me to a discussion on this? Otherwise, the 'supposed' word here does not have a basis.
Quoted 35 lines
Michael
Quoted 31 lines
Michael
Quoted 14 lines
Quoted 14 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-0sdelay (1000 ); }arch/arm/include/asm/arch-omap3/clock.h +0
-2@@ -27,8 +27,6 @@#define ICK_DSS_ON 0x00000001#define FCK_CAM_ON 0x00000001#define ICK_CAM_ON 0x00000001 -#define FCK_PER_ON 0x0003ffff -#define ICK_PER_ON 0x0003ffffQuoted 7 lines
arch/arm/include/asm/arch-omap3/clock.h line 32
Quoted 3 lines
arch/arm/include/asm/arch-omap3/clock.h +0
-0/* Used to index into DPLL parameter tables */ typedef struct {--
Regards,
Igor.--
| Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL |
Signature · 2 lines
Regards, Igor.
PATCH 1/1 arm: omap3: Enable clocks for peripherals only if they are used
Hi
Quoted 10 lines · Igor Grinberg
Hi Michael,
Quoted 7 lines · Michael Trimarchi
Hi Igor
Quoted 3 lines · Michael Trimarchi
Hi Igor
On Tue, Nov 19, 2013 at 9:24 AM, Igor Grinberg <[email protected]> wrote:
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Hi Michael,
Quoted 1 line · Michael Trimarchi
Enable clocks for the peripherals only if they are used
This is not exactly what the patch does, right?
I would expect a better description of what you do in the patch and what are the consequences of this patch.
It does the right. If you open the files you can find that clock are enabled if the peripheral is used.
Quoted 2 lines
May be some of the consequences can be avoided?
Yes, this is correct. Most of the consequences come if you use gpio bank and you don't active them
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Quoted 22 lines
Quoted 12 lines
Signed-off-by Michael Trimarchi <[email protected]>--- arch/arm/cpu/armv7/omap3/clock.c | 2 -- arch/arm/include/asm/arch-omap3/clock.h | 2 -- 2 files changed, 4 deletions(-)arch/arm/cpu/armv7/omap3/clock.c +0
-0arch/arm/cpu/armv7/omap3/clock.c void per_clocks_enable(void) · line 734
Quoted 5 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-2@@ -730,8 +730,6 @@ void per_clocks_enable(void)sr32 (&prcm_base->fclken_cam,0 ,32 ,FCK_CAM_ON );sr32 (&prcm_base->iclken_cam,0 ,32 ,ICK_CAM_ON ); } -sr32 (&prcm_base->fclken_per,0 ,32 ,FCK_PER_ON ); -sr32 (&prcm_base->iclken_per,0 ,32 ,ICK_PER_ON );Hmmm...
Am I missing something or is this change breaks boards that currently rely on the peripheral clocks being enabled here?
Quoted 5 lines
Quoted 1 line
Quoted 1 line
This change break boards that are not correctly configured.
I don't agree on this one.
This change breaks boards that are _correctly_ configured prior to the patch.
If you think that if the boards are correct they should boot
Quoted 4 lines
As a consequence of this patch, there might be boards that are not correctly configured and thus broken.
In other words, this patch breaks boards that rely on those clocks being enabled.
Michael
Quoted 57 lines
Quoted 7 lines
Quoted 4 lines
To be more clear, this change just enable clocks that are supposed to be used.
Well, if I read the patch correctly, it does not enable anything. It removes the unconditional configuration of some clocks...
Quoted 2 lines
Now that code was supposed to be removed long
time ago.Were there any discussions on this meter?
Can you please point me to a discussion on this? Otherwise, the 'supposed' word here does not have a basis.Quoted 35 lines
Michael
Quoted 31 lines
Michael
Quoted 14 lines
Quoted 14 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-0sdelay (1000 ); }arch/arm/include/asm/arch-omap3/clock.h +0
-2@@ -27,8 +27,6 @@#define ICK_DSS_ON 0x00000001#define FCK_CAM_ON 0x00000001#define ICK_CAM_ON 0x00000001 -#define FCK_PER_ON 0x0003ffff -#define ICK_PER_ON 0x0003ffffQuoted 7 lines
arch/arm/include/asm/arch-omap3/clock.h line 32
Quoted 3 lines
arch/arm/include/asm/arch-omap3/clock.h +0
-0/* Used to index into DPLL parameter tables */ typedef struct {--
Regards,
Igor.--
| Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL |--
Regards,
Igor.
Signature · 4 lines
| Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL |
PATCH 1/1 arm: omap3: Enable clocks for peripherals only if they are used
Quoted 54 lines · Michael Trimarchi
Hi
Quoted 10 lines · Igor Grinberg
Hi Michael,
Quoted 7 lines · Michael Trimarchi
Hi Igor
Quoted 3 lines · Michael Trimarchi
Hi Igor
On Tue, Nov 19, 2013 at 9:24 AM, Igor Grinberg <[email protected]> wrote:
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Hi Michael,
Quoted 1 line · Michael Trimarchi
Enable clocks for the peripherals only if they are used
This is not exactly what the patch does, right?
I would expect a better description of what you do in the patch and what are the consequences of this patch.It does the right. If you open the files you can find that clock are enabled if the peripheral is used.
Quoted 2 lines
May be some of the consequences can be avoided?
Yes, this is correct. Most of the consequences come if you use gpio bank and you don't active them
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Quoted 22 lines
Quoted 12 lines
Signed-off-by Michael Trimarchi <[email protected]>--- arch/arm/cpu/armv7/omap3/clock.c | 2 -- arch/arm/include/asm/arch-omap3/clock.h | 2 -- 2 files changed, 4 deletions(-)arch/arm/cpu/armv7/omap3/clock.c +0
-0arch/arm/cpu/armv7/omap3/clock.c void per_clocks_enable(void) · line 734
Quoted 5 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-2@@ -730,8 +730,6 @@ void per_clocks_enable(void)sr32 (&prcm_base->fclken_cam,0 ,32 ,FCK_CAM_ON );sr32 (&prcm_base->iclken_cam,0 ,32 ,ICK_CAM_ON ); } -sr32 (&prcm_base->fclken_per,0 ,32 ,FCK_PER_ON ); -sr32 (&prcm_base->iclken_per,0 ,32 ,ICK_PER_ON );Hmmm...
Am I missing something or is this change breaks boards that currently rely on the peripheral clocks being enabled here?
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line
This change break boards that are not correctly configured.
I don't agree on this one.
This change breaks boards that are _correctly_ configured prior to the patch.If you think that if the boards are correct they should boot
I think this is an extension of the CONFIG_SYS_ENABLE_PADS_ALL / CONFIG_SYS_CLOCKS_ENABLE_ALL problem. The long stated design of U-Boot is we enable what we need. The long stated design of the Linux Kernel, in general, is that it doesn't rely on the bootloader to have enabled all of this. And then various vendors (mine included) broke both rules for a while when people weren't paying enough attention. So yes, it's likely that some boards will break because they assume the clock was enabled for them.
The question is, are there boards where it's reasonable to assume people would upgrade U-Boot but not upgrade the kernel and see this problem? That I don't know the answer to.
The second question is, are there problems with leaving the clock enablement on? I suspect there is, which is how this was run into in the first place.
At some level the platforms people use today and their needs outweigh the problems of the platforms people used to use, but still maybe could, if they wanted to dust it off and plug it in, and it didn't just up and die on them.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131120/b399b431/attachment.pgp>
PATCH 1/1 arm: omap3: Enable clocks for peripherals only if they are used
Hi
Quoted 61 lines · Tom Rini
Quoted 60 lines · Michael Trimarchi
Hi
Quoted 10 lines · Igor Grinberg
Hi Michael,
Quoted 7 lines · Michael Trimarchi
Hi Igor
Quoted 3 lines · Michael Trimarchi
Hi Igor
On Tue, Nov 19, 2013 at 9:24 AM, Igor Grinberg <[email protected]> wrote:
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Hi Michael,
Quoted 1 line · Michael Trimarchi
Enable clocks for the peripherals only if they are used
This is not exactly what the patch does, right?
I would expect a better description of what you do in the patch and what are the consequences of this patch.It does the right. If you open the files you can find that clock are enabled if the peripheral is used.
Quoted 2 lines
May be some of the consequences can be avoided?
Yes, this is correct. Most of the consequences come if you use gpio bank and you don't active them
Quoted 28 lines
Quoted 23 lines
Quoted 23 lines
Quoted 22 lines
Quoted 12 lines
Signed-off-by Michael Trimarchi <[email protected]>--- arch/arm/cpu/armv7/omap3/clock.c | 2 -- arch/arm/include/asm/arch-omap3/clock.h | 2 -- 2 files changed, 4 deletions(-)arch/arm/cpu/armv7/omap3/clock.c +0
-0arch/arm/cpu/armv7/omap3/clock.c void per_clocks_enable(void) · line 734
Quoted 5 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-2@@ -730,8 +730,6 @@ void per_clocks_enable(void)sr32 (&prcm_base->fclken_cam,0 ,32 ,FCK_CAM_ON );sr32 (&prcm_base->iclken_cam,0 ,32 ,ICK_CAM_ON ); } -sr32 (&prcm_base->fclken_per,0 ,32 ,FCK_PER_ON ); -sr32 (&prcm_base->iclken_per,0 ,32 ,ICK_PER_ON );Hmmm...
Am I missing something or is this change breaks boards that currently rely on the peripheral clocks being enabled here?Quoted 1 line
Quoted 1 line
This change break boards that are not correctly configured.
I don't agree on this one.
This change breaks boards that are _correctly_ configured prior to the patch.
Quoted 5 lines
Quoted 1 line
If you think that if the boards are correct they should boot
I think this is an extension of the
CONFIG_SYS_ENABLE_PADS_ALL/CONFIG_SYS_CLOCKS_ENABLE_ALLproblem. The long stated design of U-Boot is we enable what we need. The long stated design of the Linux Kernel,
Do you want me to re-submit with a better description?
Michael
Quoted 21 lines
in general, is that it doesn't rely on the bootloader to have enabled all of this. And then various vendors (mine included) broke both rules for a while when people weren't paying enough attention. So yes, it's likely that some boards will break because they assume the clock was enabled for them.
The question is, are there boards where it's reasonable to assume people would upgrade U-Boot but not upgrade the kernel and see this problem? That I don't know the answer to.
The second question is, are there problems with leaving the clock enablement on? I suspect there is, which is how this was run into in the first place.
At some level the platforms people use today and their needs outweigh the problems of the platforms people used to use, but still maybe could, if they wanted to dust it off and plug it in, and it didn't just up and die on them.
--
Tom
PATCH 1/1 arm: omap3: Enable clocks for peripherals only if they are used
Quoted 64 lines · Michael Trimarchi
Hi
Quoted 61 lines · Tom Rini
Quoted 60 lines · Michael Trimarchi
Hi
Quoted 10 lines · Igor Grinberg
Hi Michael,
Quoted 7 lines · Michael Trimarchi
Hi Igor
Quoted 3 lines · Michael Trimarchi
Hi Igor
On Tue, Nov 19, 2013 at 9:24 AM, Igor Grinberg <[email protected]> wrote:
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Hi Michael,
Quoted 1 line · Michael Trimarchi
Enable clocks for the peripherals only if they are used
This is not exactly what the patch does, right?
I would expect a better description of what you do in the patch and what are the consequences of this patch.It does the right. If you open the files you can find that clock are enabled if the peripheral is used.
Quoted 2 lines
May be some of the consequences can be avoided?
Yes, this is correct. Most of the consequences come if you use gpio bank and you don't active them
Quoted 28 lines
Quoted 23 lines
Quoted 23 lines
Quoted 22 lines
Quoted 12 lines
Signed-off-by Michael Trimarchi <[email protected]>--- arch/arm/cpu/armv7/omap3/clock.c | 2 -- arch/arm/include/asm/arch-omap3/clock.h | 2 -- 2 files changed, 4 deletions(-)arch/arm/cpu/armv7/omap3/clock.c +0
-0arch/arm/cpu/armv7/omap3/clock.c void per_clocks_enable(void) · line 734
Quoted 5 lines
arch/arm/cpu/armv7/omap3/clock.c +0
-2@@ -730,8 +730,6 @@ void per_clocks_enable(void)sr32 (&prcm_base->fclken_cam,0 ,32 ,FCK_CAM_ON );sr32 (&prcm_base->iclken_cam,0 ,32 ,ICK_CAM_ON ); } -sr32 (&prcm_base->fclken_per,0 ,32 ,FCK_PER_ON ); -sr32 (&prcm_base->iclken_per,0 ,32 ,ICK_PER_ON );Hmmm...
Am I missing something or is this change breaks boards that currently rely on the peripheral clocks being enabled here?Quoted 1 line
Quoted 1 line
This change break boards that are not correctly configured.
I don't agree on this one.
This change breaks boards that are _correctly_ configured prior to the patch.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
If you think that if the boards are correct they should boot
I think this is an extension of the
CONFIG_SYS_ENABLE_PADS_ALL/CONFIG_SYS_CLOCKS_ENABLE_ALLproblem. The long stated design of U-Boot is we enable what we need. The long stated design of the Linux Kernel,Do you want me to re-submit with a better description?
I definitely do!!!
One of my biggest concerns is the lack of the description
for such patches.
It must be clear to anyone who looks at the log, what this patch does. So, as for me, the patch itself is _fine_ (I also was always concerned about enabling clocks, remember the OMAP3 USB submissions?), but we must have a good description of what exactly may break after the patch. So if its lack of CONFIG_* defines, it must be stated in the commit message. If it is GPT clocks, WDOG clock, etc... - it must be stated in the commit message and we also need to consider adding CONFIG_* options for those that don't have such an option (e.g. GPT, WDOG).
Quoted 12 lines
Michael
Quoted 9 lines
in general, is that it doesn't rely on the bootloader to have enabled all of this. And then various vendors (mine included) broke both rules for a while when people weren't paying enough attention. So yes, it's likely that some boards will break because they assume the clock was enabled for them.
The question is, are there boards where it's reasonable to assume people would upgrade U-Boot but not upgrade the kernel and see this problem? That I don't know the answer to.
Well, yes there are customers who will upgrade U-Boot and not touch the kernel.
Quoted 4 lines
Quoted 4 lines
The second question is, are there problems with leaving the clock enablement on? I suspect there is, which is how this was run into in the first place.
Unless, we can leave OMAP3 like it was, but be more strict regarding newer SoCs.
Quoted 9 lines
Quoted 8 lines
At some level the platforms people use today and their needs outweigh the problems of the platforms people used to use, but still maybe could, if they wanted to dust it off and plug it in, and it didn't just up and die on them.
--
Tom
Signature · 2 lines
Regards, Igor.