Skip to contentSkip to conversation

should we propagate SMB error codes further?

DISCUSSION Christoph Hellwig 4 participants 5 messages Nov 20, 2013 – Nov 21, 2013 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

I'm seeing same interesting errors running against a server from a big NAS vendor that shall remain unnamed:

p224160.955651] CIFS VFS: Unexpected lookup error -5

[224161.298853] CIFS VFS: Unexpected lookup error -5
[224161.643559] CIFS VFS: Unexpected lookup error -5
[224161.992309] CIFS VFS: Unexpected lookup error -5
[224162.333310] CIFS VFS: Unexpected lookup error -5
[224162.677982] CIFS VFS: Unexpected lookup error -5

Unfortunately it seems like a EIO is the catchall for unknown SMB errors, so trying to debug this seems a bit hard. Should we maybe look into propagating the SMB error codes further up the chain inside the cifs driver instead of converting them at a fairly low level?

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 2 lines · Christoph Hellwig

I'm seeing same interesting errors running against a server from a big NAS vendor that shall remain unnamed:

Just tell NetApp to fix their SMB implementation :-)

SCNR.

Volker

#3 lore raw
In reply to a message not in the archive
Quoted 10 lines · On Wed, 20 Nov 2013 00:13:34 -0800 Christoph Hellwig…

I'm seeing same interesting errors running against a server from a big NAS vendor that shall remain unnamed:

p224160.955651] CIFS VFS: Unexpected lookup error -5

[224161.298853] CIFS VFS: Unexpected lookup error -5
[224161.643559] CIFS VFS: Unexpected lookup error -5
[224161.992309] CIFS VFS: Unexpected lookup error -5
[224162.333310] CIFS VFS: Unexpected lookup error -5
[224162.677982] CIFS VFS: Unexpected lookup error -5
Quoted 5 lines

Unfortunately it seems like a EIO is the catchall for unknown SMB errors, so trying to debug this seems a bit hard. Should we maybe look into propagating the SMB error codes further up the chain inside the cifs driver instead of converting them at a fairly low level?

That makes a lot of sense. We could also get rid of some nasty NT error->DOS error conversion code that way too.

That said, if that NAS vendor is the one I'm thinking of, then it's probable that it's just sending malformed responses and not sending actual error codes at all.

You may be interested in this samba bug which has some details about some of these problems:

    https://bugzilla.samba.org/show_bug.cgi?id=8914
Signature · 1 line
Jeff Layton <[email protected]>

A message that is not in the archive (sent off-list or not yet received): 20131120062619.312adee4-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org

#5 lore raw
Quoted 13 lines · Jeff Layton
Quoted 10 lines · On Wed, 20 Nov 2013 00:13:34 -0800 Christoph Hellwig…

I'm seeing same interesting errors running against a server from a big NAS vendor that shall remain unnamed:

p224160.955651] CIFS VFS: Unexpected lookup error -5

[224161.298853] CIFS VFS: Unexpected lookup error -5
[224161.643559] CIFS VFS: Unexpected lookup error -5
[224161.992309] CIFS VFS: Unexpected lookup error -5
[224162.333310] CIFS VFS: Unexpected lookup error -5
[224162.677982] CIFS VFS: Unexpected lookup error -5
Quoted 8 lines
Quoted 5 lines

Unfortunately it seems like a EIO is the catchall for unknown SMB errors, so trying to debug this seems a bit hard. Should we maybe look into propagating the SMB error codes further up the chain inside the cifs driver instead of converting them at a fairly low level?

That makes a lot of sense. We could also get rid of some nasty NT error->DOS error conversion code that way too.

At least in the SMB2/SMB3 case it is more direct onestep conversion which helps.

Quoted 8 lines

That said, if that NAS vendor is the one I'm thinking of, then it's probable that it's just sending malformed responses and not sending actual error codes at all.

You may be interested in this samba bug which has some details about some of these problems:

    https://bugzilla.samba.org/show_bug.cgi?id=8914

I think generally with some of the NAS vendors we are better off mounting with "vers=2.1" (or "vers=3.0" if more recent kernel) but probably not till at least at 3.11 kernel. With the big move to SMB2.1 (Windows 7 and Mac) and
SMB3, there is presumably a lot less testing going on with cifs in some of the NAS boxes.

Signature · 3 lines
Thanks,

Steve
#6 lore raw
In reply to a message not in the archive
Quoted 10 lines · Christoph Hellwig

I'm seeing same interesting errors running against a server from a big NAS vendor that shall remain unnamed:

p224160.955651] CIFS VFS: Unexpected lookup error -5

[224161.298853] CIFS VFS: Unexpected lookup error -5
[224161.643559] CIFS VFS: Unexpected lookup error -5
[224161.992309] CIFS VFS: Unexpected lookup error -5
[224162.333310] CIFS VFS: Unexpected lookup error -5
[224162.677982] CIFS VFS: Unexpected lookup error -5
Quoted 5 lines

Unfortunately it seems like a EIO is the catchall for unknown SMB errors, so trying to debug this seems a bit hard. Should we maybe look into propagating the SMB error codes further up the chain inside the cifs driver instead of converting them at a fairly low level?

I wish we could extend the POSIX-like errors that the kernel tolerates further (it is especially painful on mount where a few more return codes would make life easier for returning more specific mount errors, and I find it even harder on NFS so it is not just cifs which suffers from wanting more error codes to send back)

For your use case, you might try turning on the status code logging by setting the CIFS_RC flag in the cifs debug flags at runtime (unfortunately they are global not per-process).

"echo 2 > /proc/fs/cifs/cifsFYI"

Then you will see most of the nt status codes logged before they are remapped.

e.g.

[ 9830.513514] Status code returned 0xc0000016
NT_STATUS_MORE_PROCESSING_REQUIRED
[ 9830.562929] Status code returned 0xc0000225 NT_STATUS_NOT_FOUND

(Maximal logging can be done by "echo 7 > /proc/fs/cifs/cifsFYI" which also enables logging of CIFS_INFO and CIFS_TIMER events)

Signature · 3 lines
Thanks,

Steve