Skip to contentSkip to conversation

ti: libdce: Library for invoking the hw accelerated codec on IVA-HD.

PATCH In review Mrinmayee Hingolikar 4 participants 4 messages Nov 20, 2013 – Nov 21, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ti: libdce: Library for invoking the hw accelerated codec on IVA-HD.

---
 recipes-ti/libdce/libdce_git.bb |   14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 recipes-ti/libdce/libdce_git.bb
recipes-ti/libdce/libdce_git.bb new file +14 -0
new file mode 100644
index 0000000..fcb9984
@@ -0,0 +1,14 @@
+inherit autotools pkgconfig
+
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://libdce.h;beginline=1;endline=31;md5=0a398cf815b8b5f31f552266cd453dae"
+
+PR = "r0"
+
+DEPENDS = "libdrm ti-ipc"
+
+SRC_URI = "git://git.ti.com/glsdk/libdce2.git;protocol=git"
+SRCREV = "0aa6627d59a2a7c4837a40fe67f610b3318d23c1"
+
+S = "${WORKDIR}/git"
+EXTRA_OECONF += "IPC_HEADERS=${STAGING_DIR_TARGET}/usr/include/ti/ipc/mm"
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw

First of all:

Second, couple minor comments:

1. Please use "name: short summary" for the patch subject. No need for nested "ti: libdce: ". And the summary could have been shorter - you could have added a more expanded description separately...

2. inherit line usually goes after LICENSE, LIC_FILES_CHKSUM. And you are missing more generic, but optional SUMMARY, DESCRIPTION, HOMEPAGE and SECTION

Other than that - very good, I can take it and fix the minor comments myself.

Signature · 1 line
Denys
Quoted 33 lines · Mrinmayee Hingolikar
---
 recipes-ti/libdce/libdce_git.bb |   14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 recipes-ti/libdce/libdce_git.bb
recipes-ti/libdce/libdce_git.bb new file +14 -0
new file mode 100644
index 0000000..fcb9984
@@ -0,0 +1,14 @@
+inherit autotools pkgconfig
+
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://libdce.h;beginline=1;endline=31;md5=0a398cf815b8b5f31f552266cd453dae"
+
+PR = "r0"
+
+DEPENDS = "libdrm ti-ipc"
+
+SRC_URI = "git://git.ti.com/glsdk/libdce2.git;protocol=git"
+SRCREV = "0aa6627d59a2a7c4837a40fe67f610b3318d23c1"
+
+S = "${WORKDIR}/git"
+EXTRA_OECONF += "IPC_HEADERS=${STAGING_DIR_TARGET}/usr/include/ti/ipc/mm"
Signature · 6 lines
1.7.9.5

_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
#2 lore raw
In reply to Mrinmayee Hingolikar

recipes-ti/libdce/libdce_git.bb line 11

Quoted 3 lines · Mrinmayee Hingolikar
recipes-ti/libdce/libdce_git.bb new file +2 -0
+SRC_URI = "git://git.ti.com/glsdk/libdce2.git;protocol=git"
+SRCREV = "0aa6627d59a2a7c4837a40fe67f610b3318d23c1"

i guess you need to set PV, it might default to 1.0 otherwise.

#3 lore raw

From: [email protected] [mailto:[email protected]] On Behalf Of Nicolas Dechesne
Sent: Wednesday, November 20, 2013 4:06 PM
To: Hingolikar, Mrinmayee
Cc: [email protected]
Subject: Re: [meta-ti] [PATCH] ti: libdce: Library for invoking the hw accelerated codec on IVA-HD.

On Wed, Nov 20, 2013 at 11:38 AM, Mrinmayee Hingolikar <[email protected]<mailto:[email protected]>> wrote:
+SRC_URI = "git://git.ti.com/glsdk/libdce2.git;protocol=git<http://git.ti.com/glsdk/libdce2.git;protocol=git>" +SRCREV = "0aa6627d59a2a7c4837a40fe67f610b3318d23c1"

i guess you need to set PV, it might default to 1.0 otherwise.

[CEM] Good point Nicolas