cx18: check for allocation failure in cx18_read_eeprom()
Subsystems (3)
PATCH 1/1 cx18: check for allocation failure in cx18_read_eeprom()
It upsets static checkers when we don't check for allocation failure. I moved the memset() of "tv" earlier so we don't use uninitialized data on error.
drivers/media/pci/cx18/cx18-driver.c +4 -1
@@ -327,13 +327,16 @@ void cx18_read_eeprom(struct cx18 *cx, struct tveeprom *tv)struct i2c_client *c;u8 eedata[256 ]; +memset (tv,0 ,sizeof (*tv)); + c =kzalloc (sizeof (*c),GFP_KERNEL ); +if (!c) +return ;strlcpy (c->name,"cx18 tveeprom tmp" ,sizeof (c->name)); c->adapter = &cx->i2c_adap[0 ]; c->addr =0xa0 >>1 ; -memset (tv,0 ,sizeof (*tv));if (tveeprom_read (c, eedata,sizeof (eedata))) goto ret;
Btw, the MAINTAINERS file says the ivtv list is moderated but actually it's a subscriber only list... Sucks.
regards,
dan carpenter
Andy,
Should we perhaps change the MAINTAINERS file to point to the linux-media list instead?
Regards,
Hans
Quoted 2 lines · Dan Carpenter
Btw, the
MAINTAINERSfile says the ivtv list is moderated but actually it's a subscriber only list... Sucks.
Andy Walls
maintainerQuoted 4 lines · Hans Verkuil
Andy,
Should we perhaps change the
MAINTAINERSfile to point to the linux-media list instead?
Yes. When I get time this weekend, I can submit a patch; unless you beat me to it.
Regards,
Andy
Quoted 12 lines
Regards,
Hans
Quoted 2 lines · Dan Carpenter
Btw, the
MAINTAINERSfile says the ivtv list is moderated but actually it's a subscriber only list... Sucks.--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 6 lines · Dan Carpenter
It upsets static checkers when we don't check for allocation failure. I moved the
memset()of "tv" earlier so we don't use uninitialized data on error.Fixes 1d212cf0c2d8 ('[media] cx18: struct i2c_client is too big for stack')Signed-off-by Dan Carpenter <[email protected]>
Quoted 26 lines
drivers/media/pci/cx18/cx18-driver.c +4
-2@@ -327,13 +327,16 @@ void cx18_read_eeprom(struct cx18 *cx, struct tveeprom *tv)struct i2c_client *c;u8 eedata[256 ]; +memset (tv,0 ,sizeof (*tv)); + c =kzalloc (sizeof (*c),GFP_KERNEL ); +if (!c) +return ;strlcpy (c->name,"cx18 tveeprom tmp" ,sizeof (c->name)); c->adapter = &cx->i2c_adap[0 ]; c->addr =0xa0 >>1 ; -memset (tv,0 ,sizeof (*tv));if (tveeprom_read (c, eedata,sizeof (eedata))) goto ret; --To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html