Skip to contentSkip to conversation

nftables: add 'delete map' syntax

PATCH Applied Phil Oester 2 participants 2 messages Nov 30, 2013 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nftables: add 'delete map' syntax

Creating a map is done via "add map". However, to delete a map requires using "delete set", which is confusing. Add the appropriate synonym to parser. The downside to this is that one can now delete a set with "delete map", but this seems a minor issue. It could of course be fixed by adding a new CMD_OBJ_MAP.

This closes netfilter bugzilla #879.

src/parser.y +4 -0
index a49e5c2..c736240 100644
@@ -604,6 +604,10 @@ delete_cmd		:	TABLE		table_spec
 			{
 				$$ = cmd_alloc(CMD_DELETE, CMD_OBJ_SET, &$2, &@$, NULL);
 			}
+			|	MAP		set_spec
+			{
+				$$ = cmd_alloc(CMD_DELETE, CMD_OBJ_SET, &$2, &@$, NULL);
+			}
 			|	ELEMENT		set_spec	set_expr
 			{
 				$$ = cmd_alloc(CMD_DELETE, CMD_OBJ_SETELEM, &$2, &@$, $3);
maintainer Applied
#1 lore raw
Quoted 7 lines · Phil Oester

Creating a map is done via "add map". However, to delete a map requires using "delete set", which is confusing. Add the appropriate synonym to parser. The downside to this is that one can now delete a set with "delete map", but this seems a minor issue. It could of course be fixed by adding a new CMD_OBJ_MAP.

This closes netfilter bugzilla #879.

Applied this fix as well. Thanks.