smbnetfs: new package 0.5.3a
PATCH 1/1 smbnetfs: new package 0.5.3a
--- package/Config.in | 1 + package/smbnetfs/Config.in | 16 ++++++++++++++++ package/smbnetfs/smbnetfs-compile-with-uclibc.patch | 14 ++++++++++++++ package/smbnetfs/smbnetfs.mk | 11 +++++++++++ 4 files changed, 42 insertions(+) create mode 100644 package/smbnetfs/Config.in create mode 100644 package/smbnetfs/smbnetfs-compile-with-uclibc.patch create mode 100644 package/smbnetfs/smbnetfs.mk
package/Config.in +1 -0
@@ -148,6 +148,7 @@ source "package/makedevs/Config.in" source "package/mtd/Config.in" source "package/nfs-utils/Config.in" source "package/ntfs-3g/Config.in" +source "package/smbnetfs/Config.in" source "package/squashfs/Config.in" source "package/squashfs3/Config.in" source "package/sshfs/Config.in"
package/smbnetfs/Config.in new file +16 -0
@@ -0,0 +1,16 @@ +config BR2_PACKAGE_SMBNETFS + bool "smbnetfs" + depends on BR2_PACKAGE_SAMBA + select BR2_PACKAGE_SAMBA_LIBSMBCLIENT + select BR2_PACKAGE_LIBFUSE + select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE + help + A user-space filesystem that contains an entire + SMB/NMB network under a single mount point. + Workgroups, servers, and shares can be browsed much + like the Network Neighborhood in Microsoft Window. + + http://smbnetfs.sourceforge.net/ + +comment "smbnetfs needs samba" + depends on !BR2_PACKAGE_SAMBA
package/smbnetfs/smbnetfs-compile-with-uclibc.patch new file +14 -0
@@ -0,0 +1,14 @@ +Index: smbnetfs-0.5.3a/src/common.c +=================================================================== +--- smbnetfs-0.5.3a.orig/src/common.c 2013-11-15 11:22:27.520088835 -0600 ++++ smbnetfs-0.5.3a/src/common.c 2013-11-15 11:22:37.384088834 -0600 +@@ -4,7 +4,9 @@ + #include <stdarg.h> + #include <string.h> + #include <pthread.h> ++#ifdef HAVE_BACKTRACE + #include <execinfo.h> ++#endif + + #include "common.h" +
package/smbnetfs/smbnetfs.mk new file +11 -0
@@ -0,0 +1,11 @@ +################################################################################ +# +# smbnetfs +# +################################################################################ + +SMBNETFS_VERSION = 0.5.3a +SMBNETFS_SOURCE = smbnetfs-$(SMBNETFS_VERSION).tar.bz2 +SMBNETFS_SITE = http://downloads.sourceforge.net/smbnetfs + +$(eval $(autotools-package))
Signature · 1 line
1.8.4.rc3
PATCH 1/1 smbnetfs: new package 0.5.3a
Dear Andrew Ruder,
Thanks for this contribution as well!
Quoted 5 lines · Andrew Ruder
Signed-off-by Andrew Ruder <[email protected]>--- package/Config.in | 1 + package/smbnetfs/Config.in | 16 ++++++++++++++++ package/smbnetfs/smbnetfs-compile-with-uclibc.patch | 14 ++++++++++++++
We now normally wants patches to carry a sequence number, even if there is only one patch. So something like:
smbnetfs-01-compile-with-uclibc.patch
for example. See
http://buildroot.org/downloads/manual/manual.html#patch-policy for details.
Quoted 27 lines
package/smbnetfs/smbnetfs.mk | 11 +++++++++++ 4 files changed, 42 insertions(+) create mode 100644 package/smbnetfs/Config.in create mode 100644 package/smbnetfs/smbnetfs-compile-with-uclibc.patch create mode 100644 package/smbnetfs/smbnetfs.mkpackage/Config.in +1
-0@@ -148,6 +148,7 @@ source "package/makedevs/Config.in" source "package/mtd/Config.in" source "package/nfs-utils/Config.in" source "package/ntfs-3g/Config.in" +source "package/smbnetfs/Config.in" source "package/squashfs/Config.in" source "package/squashfs3/Config.in" source "package/sshfs/Config.in"package/smbnetfs/Config.in new file +3
-0@@ -0,0 +1,16 @@ +config BR2_PACKAGE_SMBNETFS + bool "smbnetfs" + depends on BR2_PACKAGE_SAMBA
package/smbnetfs/Config.in line 13
Quoted 10 lines
package/smbnetfs/Config.in new file +10
-0+ select BR2_PACKAGE_SAMBA_LIBSMBCLIENT + select BR2_PACKAGE_LIBFUSE + select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE + help + A user-space filesystem that contains an entire + SMB/NMB network under a single mount point. + Workgroups, servers, and shares can be browsed much + like the Network Neighborhood in Microsoft Window. + + http://smbnetfs.sourceforge.net/
Indentation of the help text is wrong. It should be one tab + two spaces.
package/smbnetfs/Config.in line 16
Quoted 2 lines
package/smbnetfs/Config.in new file +2
-0+comment "smbnetfs needs samba" + depends on !BR2_PACKAGE_SAMBA
I'm not sure here if we want to depend on Samba, or select Samba. Usually, we prefer "select" so that things are transparent for the user. However, when the thing being selected is "big", and fairly obvious for the user (like the Python interpreter being needed to build a Python module), we use depends on. I'm not sure which choice to make here.
However, what is sure is that you forgot to inherit the toolchain dependencies of libfuse: they should be added.
package/smbnetfs/smbnetfs-compile-with-uclibc.patch
Quoted 6 lines
package/smbnetfs/smbnetfs-compile-with-uclibc.patch new file +0
-0@@ -0,0 +1,14 @@
All patches should have a description + Signed-off-by. Also, it would be good if you could submit that patch upstream, so that it gets integrated in a future release.
Quoted 21 lines
package/smbnetfs/smbnetfs-compile-with-uclibc.patch new file +14
-0+Index: smbnetfs-0.5.3a/src/common.c +=================================================================== +--- smbnetfs-0.5.3a.orig/src/common.c 2013-11-15 11:22:27.520088835 -0600 ++++ smbnetfs-0.5.3a/src/common.c 2013-11-15 11:22:37.384088834 -0600 +@@ -4,7 +4,9 @@ + #include <stdarg.h> + #include <string.h> + #include <pthread.h> ++#ifdef HAVE_BACKTRACE + #include <execinfo.h> ++#endif + + #include "common.h" +package/smbnetfs/smbnetfs.mk new file +1
-0@@ -0,0 +1,11 @@ +################################################################################
package/smbnetfs/smbnetfs.mk line 11
Quoted 10 lines
package/smbnetfs/smbnetfs.mk new file +10
-0+# +# smbnetfs +# +################################################################################ + +SMBNETFS_VERSION = 0.5.3a +SMBNETFS_SOURCE = smbnetfs-$(SMBNETFS_VERSION).tar.bz2 +SMBNETFS_SITE = http://downloads.sourceforge.net/smbnetfs + +$(eval $(autotools-package))
No SMBNETFS_DEPENDENCIES to ensure libfuse, libiconv and samba are built before smbnetfs?
Also, we now request all new packages to have SMBNETFS_LICENSE and SMBNETFS_LICENSE_FILES.
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 smbnetfs: new package 0.5.3a
Summary: I apologize for the shoddiness of this and my other patch and I will take the info you've given me here and make much better v2's :).
Quoted 4 lines · Thomas Petazzoni
We now normally wants patches to carry a sequence number, even if there is only one patch. So something like:
smbnetfs-01-compile-with-uclibc.patch
Ok, can do for v2.
Quoted 2 lines
Indentation of the help text is wrong. It should be one tab + two spaces.
I'll fix that for v2.
Quoted 6 lines
I'm not sure here if we want to depend on Samba, or select Samba. Usually, we prefer "select" so that things are transparent for the user. However, when the thing being selected is "big", and fairly obvious for the user (like the Python interpreter being needed to build a Python module), we use depends on. I'm not sure which choice to make here.
Yes, I had made the decision that samba was "intrusive" enough to require explicit selection. I figured since it required something outside of the Libraries section, I would make the user explicitely add it.
Quoted 2 lines
However, what is sure is that you forgot to inherit the toolchain dependencies of libfuse: they should be added.
Ah, I am a little unfamiliar with the intricacies of Kconfig and didn't realize I needed to explicitely do that. Will take care of it in v2.
Quoted 3 lines
All patches should have a description + Signed-off-by. Also, it would be good if you could submit that patch upstream, so that it gets integrated in a future release.
OK, fair enough - can do on both counts.
Quoted 5 lines
No
SMBNETFS_DEPENDENCIESto ensure libfuse, libiconv and samba are built before smbnetfs?Also, we now request all new packages to have
SMBNETFS_LICENSEandSMBNETFS_LICENSE_FILES.
v2 and v2.
PATCH 1/1 smbnetfs: new package 0.5.3a
Dear Andrew Ruder,
Quoted 3 lines · Andrew Ruder
Summary: I apologize for the shoddiness of this and my other patch and I will take the info you've given me here and make much better v2's :).
Your v1 was really good! Only a few minor things need to be fixed, but overall, it's far from being shoddy, on the contrary!
Quoted 11 lines
Quoted 6 lines
I'm not sure here if we want to depend on Samba, or select Samba. Usually, we prefer "select" so that things are transparent for the user. However, when the thing being selected is "big", and fairly obvious for the user (like the Python interpreter being needed to build a Python module), we use depends on. I'm not sure which choice to make here.
Yes, I had made the decision that samba was "intrusive" enough to require explicit selection. I figured since it required something outside of the Libraries section, I would make the user explicitely add it.
I'm fine with this choice. We'll see what the other Buildroot developers think about this.
Quoted 6 lines
Quoted 2 lines
However, what is sure is that you forgot to inherit the toolchain dependencies of libfuse: they should be added.
Ah, I am a little unfamiliar with the intricacies of
Kconfigand didn't realize I needed to explicitely do that. Will take care of it in v2.
See
http://buildroot.org/downloads/manual/manual.html#dependencies-target-toolchain-options
for some details about this. But it's true that this part of the documentation doesn't really explain that the toolchain dependencies need to be propagated to all the reverse dependencies of a given package.
The reason is that when a Config.in option A "selects Config.in option B, then the unmet dependencies of option B are ignored by the "select" made by option A. So we have to replicate the dependencies.
Quoted 6 lines
Quoted 3 lines
All patches should have a description + Signed-off-by. Also, it would be good if you could submit that patch upstream, so that it gets integrated in a future release.
OK, fair enough - can do on both counts.
Quoted 7 lines
Quoted 5 lines
No
SMBNETFS_DEPENDENCIESto ensure libfuse, libiconv and samba are built before smbnetfs?Also, we now request all new packages to have
SMBNETFS_LICENSEandSMBNETFS_LICENSE_FILES.v2 and v2.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 smbnetfs: new package 0.5.3a
Hi,
On Tue, Dec 3, 2013 at 2:41 PM, Thomas Petazzoni
<[email protected]> wrote:
[..]
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
I'm not sure here if we want to depend on Samba, or select Samba. Usually, we prefer "select" so that things are transparent for the user. However, when the thing being selected is "big", and fairly obvious for the user (like the Python interpreter being needed to build a Python module), we use depends on. I'm not sure which choice to make here.
Quoted 8 lines
Quoted 4 lines
Yes, I had made the decision that samba was "intrusive" enough to require explicit selection. I figured since it required something outside of the Libraries section, I would make the user explicitely add it.
I'm fine with this choice. We'll see what the other Buildroot developers think about this.
I'm fine with either choice. However, if a 'depends on' is chosen, I don't think there should be a comment about it. We typically only add comments for toolchain dependencies.
Best regards,
Thomas