Skip to contentSkip to conversation

XFS development tree branch, master, updated. xfs-for-linus-v3.13-rc1-2-13369-gef70160

XFS updates [email protected] 1 participant 1 message Dec 5, 2013

lore
Share & tools
lore

[email protected]

author Reviewed-by Ben Myers Reviewed-by Ben Myers Reviewed-by Jie Liu
#0 lore raw

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "XFS development tree".

The branch, master has been updated
ef70160 xfs: fix memory leak in xfs_dir2_node_removename 2a84108 xfs: free the list of recovery items on error b7d961b xfs: growfs overruns AGFL buffer on V4 filesystems

      from  f9fd0135610084abef6867d984e9951c3099950d (commit)

Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.

- Log ----------------------------------------------------------------- commit ef701600fd26cace9d513ee174688a2b83832126

Author: Mark Tinguely <[email protected]>
Date:   Sat Oct 5 21:48:25 2013 -0500

xfs: fix memory leak in xfs_dir2_node_removename

Fix the leak of kernel memory in xfs_dir2_node_removename() when xfs_dir2_leafn_remove() returns an error code.

commit 2a84108fe275f95fbe838b1c92b7c45258dcae5c

Author: Mark Tinguely <[email protected]>
Date:   Wed Oct 2 07:51:12 2013 -0500

xfs: free the list of recovery items on error

Recovery builds a list of items on the transaction's r_itemq head. Normally these items are committed and freed. But in the event of a recovery error, these allocations are leaked.

If the error occurs during item reordering, then reconstruct the r_itemq list before deleting the list to avoid leaking the entries that were on one of the temporary lists.

commit b7d961b35b3ab69609aeea93f870269cb6e7ba4d

Author: Dave Chinner <[email protected]>
Date:   Thu Nov 21 15:41:06 2013 +1100

xfs: growfs overruns AGFL buffer on V4 filesystems

This loop in xfs_growfs_data_private() is incorrect for V4 superblocks filesystems:

for (bucket = 0; bucket < XFS_AGFL_SIZE(mp); bucket++)
agfl->agfl_bno[bucket] = cpu_to_be32(NULLAGBLOCK);

For V4 filesystems, we don't have a agfl header structure, and so XFS_AGFL_SIZE() returns an entire sector's worth of entries, which we then index from an offset into the sector. Hence: buffer overrun.

This problem was introduced in 3.10 by commit 77c95bba ("xfs: add CRC checks to the AGFL") which changed the AGFL structure but failed to update the growfs code to handle the different structures.

Fix it by using the correct offset into the buffer for both V4 and V5 filesystems.

-----------------------------------------------------------------------

Summary of changes:

 fs/xfs/xfs_dir2_node.c   | 26 +++++++++++++-------------
 fs/xfs/xfs_fsops.c       |  6 +++++-
 fs/xfs/xfs_log_recover.c | 17 ++++++++++++++---
 3 files changed, 32 insertions(+), 17 deletions(-)

hooks/post-receive

Signature · 6 lines
XFS development tree

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs