Skip to contentSkip to conversation

drivers: infiniband: Mark function _c4iw_write_mem_dma() as static in mem.c

PATCH In review Rashika Kheria 3 participants 3 messages Dec 14, 2013

Subsystems (2)
InfiniBand CXGB4 iWARP RNIC driver (IW_CXGB4)
lore
Share & tools
lore

Rashika Kheria

author
#0 lore raw

PATCH 1/1 drivers: infiniband: Mark function _c4iw_write_mem_dma() as static in mem.c

This patch marks the function _c4iw_write_mem_dma() as static in hw/cxgb4/mem.c because it is not used outside this file.

Thus, it also eliminates the following warning in hw/cxgb4/mem.c:
drivers/infiniband/hw/cxgb4/mem.c:176:5: warning: no previous prototype for ‘_c4iw_write_mem_dma’ [-Wmissing-prototypes]

Signed-off-by Rashika Kheria <[email protected]>
---
 drivers/infiniband/hw/cxgb4/mem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/cxgb4/mem.c +1 -1
index 4cb8eb2..84e4500 100644
@@ -173,7 +173,7 @@ static int _c4iw_write_mem_inline(struct c4iw_rdev *rdev, u32 addr, u32 len,
 	return ret;
 }
 
-int _c4iw_write_mem_dma(struct c4iw_rdev *rdev, u32 addr, u32 len, void *data)
+static int _c4iw_write_mem_dma(struct c4iw_rdev *rdev, u32 addr, u32 len, void *data)
 {
 	u32 remain = len;
 	u32 dmalen;
Signature · 6 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reviewed-by on v1 1/1
#2 lore raw
In reply to Rashika Kheria
Quoted 7 lines · Rashika Kheria

This patch marks the function _c4iw_write_mem_dma() as static in hw/cxgb4/mem.c because it is not used outside this file.

Thus, it also eliminates the following warning in hw/cxgb4/mem.c:
drivers/infiniband/hw/cxgb4/mem.c:176:5: warning: no previous prototype for ‘_c4iw_write_mem_dma’ [-Wmissing-prototypes]

Signed-off-by Rashika Kheria <[email protected]>
Reviewed-by Josh Triplett <[email protected]>
Quoted 19 lines
 drivers/infiniband/hw/cxgb4/mem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/cxgb4/mem.c +1 -1
index 4cb8eb2..84e4500 100644
@@ -173,7 +173,7 @@ static int _c4iw_write_mem_inline(struct c4iw_rdev *rdev, u32 addr, u32 len,
 	return ret;
 }
 
-int _c4iw_write_mem_dma(struct c4iw_rdev *rdev, u32 addr, u32 len, void *data)
+static int _c4iw_write_mem_dma(struct c4iw_rdev *rdev, u32 addr, u32 len, void *data)
 {
 	u32 remain = len;
 	u32 dmalen;
Signature · 1 line
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html