Skip to contentSkip to conversation

drivers: pnp: Mark the function pnp_build_option() as static in resource.c

PATCH Applied Rashika Kheria 3 participants 3 messages Dec 14, 2013 – Jan 5, 2014 Pnp support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: pnp: Mark the function pnp_build_option() as static in resource.c

This patch marks the function pnp_build_option() as static in resource.c because it is not used outside this file.

Thus, it also eliminates the following warning in resource.c:
drivers/pnp/resource.c:34:20: warning: no previous prototype for ‘pnp_build_option’ [-Wmissing-prototypes]

---
 drivers/pnp/resource.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pnp/resource.c +1 -1
index d95e101..bacddd1 100644
@@ -31,7 +31,7 @@ static int pnp_reserve_mem[16] = {[0 ... 15] = -1 };	/* reserve (don't use) some
  * option registration
  */
 
-struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
+static struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
 				    unsigned int option_flags)
 {
 	struct pnp_option *option;
Signature · 1 line
1.7.9.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Rashika Kheria

This patch marks the function pnp_build_option() as static in resource.c because it is not used outside this file.

Thus, it also eliminates the following warning in resource.c:
drivers/pnp/resource.c:34:20: warning: no previous prototype for ‘pnp_build_option’ [-Wmissing-prototypes]

Quoted 19 lines
 drivers/pnp/resource.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pnp/resource.c +1 -1
index d95e101..bacddd1 100644
@@ -31,7 +31,7 @@ static int pnp_reserve_mem[16] = {[0 ... 15] = -1 };	/* reserve (don't use) some
  * option registration
  */
 
-struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
+static struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
 				    unsigned int option_flags)
 {
 	struct pnp_option *option;
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 10 lines · Josh Triplett
Quoted 7 lines · Rashika Kheria

This patch marks the function pnp_build_option() as static in resource.c because it is not used outside this file.

Thus, it also eliminates the following warning in resource.c:
drivers/pnp/resource.c:34:20: warning: no previous prototype for ‘pnp_build_option’ [-Wmissing-prototypes]

Queued up for 3.14, thanks!

Quoted 21 lines
Quoted 8 lines
 drivers/pnp/resource.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pnp/resource.c +0 -0
index d95e101..bacddd1 100644

drivers/pnp/resource.c static int pnp_reserve_mem[16] = {[0 ... 15] = -1 }; /* reserve (don't use) some · line 37

Quoted 8 lines
drivers/pnp/resource.c +1 -1
@@ -31,7 +31,7 @@ static int pnp_reserve_mem[16] = {[0 ... 15] = -1 };	/* reserve (don't use) some
  * option registration
  */
 
-struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
+static struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
 				    unsigned int option_flags)
 {
 	struct pnp_option *option;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.