Skip to contentSkip to conversation

drivers: dwc2: Mark function as static in core.c

PATCH In review Rashika Kheria 3 participants 3 messages Dec 21, 2013 – Jan 8, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: dwc2: Mark function as static in core.c

Mark function dwc2_set_param_uframe_sched() as static in core.c because it is not used outside this file.

This eliminates the following warning in core.c:
drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype for ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]

---
 drivers/staging/dwc2/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dwc2/core.c +1 -1
index 6d001b5..c029cb6 100644
@@ -2736,7 +2736,7 @@ int dwc2_get_hwparams(struct dwc2_hsotg *hsotg)
 	return 0;
 }
 
-int dwc2_set_param_uframe_sched(struct dwc2_hsotg *hsotg, int val)
+static int dwc2_set_param_uframe_sched(struct dwc2_hsotg *hsotg, int val)
 {
 	int retval = 0;
 
Signature · 1 line
1.7.9.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Rashika Kheria

Mark function dwc2_set_param_uframe_sched() as static in core.c because it is not used outside this file.

This eliminates the following warning in core.c:
drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype for ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]

Quoted 19 lines
 drivers/staging/dwc2/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dwc2/core.c +1 -1
index 6d001b5..c029cb6 100644
@@ -2736,7 +2736,7 @@ int dwc2_get_hwparams(struct dwc2_hsotg *hsotg)
 	return 0;
 }
 
-int dwc2_set_param_uframe_sched(struct dwc2_hsotg *hsotg, int val)
+static int dwc2_set_param_uframe_sched(struct dwc2_hsotg *hsotg, int val)
 {
 	int retval = 0;
 
Signature · 1 line
1.7.9.5
#2 lore raw
In reply to Rashika Kheria
Quoted 7 lines · Rashika Kheria

Mark function dwc2_set_param_uframe_sched() as static in core.c because it is not used outside this file.

This eliminates the following warning in core.c:
drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype for ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]

This patch doesn't apply to my tree.

And please stop sending patches in base64 mode, it makes it impossible to add reviewed-by: markings to them.

thanks,

greg k-h