drm/i915: Fix refcount leak and possible NULL pointer dereference.]
Subsystems (2)
PATCH 1/1 drm/i915: Fix refcount leak and possible NULL pointer dereference.]
----- Forwarded message from Tetsuo Handa <[email protected]> -----
Date: Tue, 24 Dec 2013 20:50:23 +0900
From: Tetsuo Handa <[email protected]>
To: [email protected], [email protected], [email protected]
Cc: [email protected]
Subject: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer dereference.
Message-Id: <[email protected]>
Quoted 1 line
From
482be6384379072eb4c0d45d0ab8a25df4f59ed7Mon Sep 17 00:00:00 2001
From: Tetsuo Handa <[email protected]>
Date: Tue, 24 Dec 2013 18:04:14 +0900
Subject: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer dereference.
Since get_pid_task() grabs a reference on the task_struct, we have to drop the refcount after reading that task's comm name. Also, directly reading like get_pid_task()->comm can trigger an oops when get_pid_task() returned NULL.
This patch fixes both problems.
--- drivers/gpu/drm/i915/i915_debugfs.c | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +10 -1
@@ -406,11 +406,20 @@ static int i915_gem_object_info(struct seq_file *m, void* data)seq_putc (m,'\n' );list_for_each_entry_reverse (file, &dev->filelist, lhead) {struct file_stats stats; +struct task_struct *task; +char name[TASK_COMM_LEN ];memset (&stats,0 ,sizeof (stats));idr_for_each (&file->object_idr, per_file_stats, &stats); + task =get_pid_task (file->pid,PIDTYPE_PID ); +if (task) { +get_task_comm (name, task); +put_task_struct (task); + }else { +strlcpy (name,"<unknown>" ,sizeof (name)); + } seq_printf(m, "%s: %u objects, %zu bytes (%zu active, %zu inactive, %zu unbound)\n", - get_pid_task(file->pid, PIDTYPE_PID)->comm, + name, stats.count, stats.total, stats.active,
Signature · 6 lines
1.7.1 ----- End forwarded message ----- -- Ben Widawsky, Intel Open Source Technology Center