drm/i2c: tda998x: set the repeat PLL value in range 0..3
Subsystems (2)
PATCH v2 17/28 drm/i2c: tda998x: set the repeat PLL value in range 0..3
--- drivers/gpu/drm/i2c/tda998x_drv.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i2c/tda998x_drv.c +6 -1
@@ -220,7 +220,7 @@ struct tda998x_priv {# define PLL_SERIAL_1_SRL_IZ (x) (((x) & 3) << 1)# define PLL_SERIAL_1_SRL_MAN_IZ (1 << 6)#define REG_PLL_SERIAL_2 REG(0x02, 0x01)/* read/write */ -# define PLL_SERIAL_2_SRL_NOSC (x) (((x) & 3) << 0) +# define PLL_SERIAL_2_SRL_NOSC (x) ((x) << 0)# define PLL_SERIAL_2_SRL_PR (x) (((x) & 0xf) << 4)#define REG_PLL_SERIAL_3 REG(0x02, 0x02)/* read/write */ # define PLL_SERIAL_3_SRL_CCIR (1 << 0)
@@ -972,6 +972,11 @@ tda998x_encoder_mode_set(struct drm_encoder *encoder, } div =148500 / mode->clock; +if (div !=0 ) { + div--; +if (div >3 ) + div =3 ; + }/* mute the audio FIFO: */ reg_set (priv,REG_AIP_CNTRL_0 ,AIP_CNTRL_0_RST_FIFO );
Signature · 2 lines
Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
Quoted 20 lines · Jean-Francois Moine
Signed-off-by Jean-Francois Moine <[email protected]>--- drivers/gpu/drm/i2c/tda998x_drv.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/gpu/drm/i2c/tda998x_drv.c +1
-1@@ -220,7 +220,7 @@ struct tda998x_priv {# define PLL_SERIAL_1_SRL_IZ (x) (((x) & 3) << 1)# define PLL_SERIAL_1_SRL_MAN_IZ (1 << 6)#define REG_PLL_SERIAL_2 REG(0x02, 0x01)/* read/write */ -# define PLL_SERIAL_2_SRL_NOSC (x) (((x) & 3) << 0) +# define PLL_SERIAL_2_SRL_NOSC (x) ((x) << 0)# define PLL_SERIAL_2_SRL_PR (x) (((x) & 0xf) << 4)#define REG_PLL_SERIAL_3 REG(0x02, 0x02)/* read/write */ # define PLL_SERIAL_3_SRL_CCIR (1 << 0)
drivers/gpu/drm/i2c/tda998x_drv.c tda998x_encoder_mode_set(struct drm_encoder *encoder, · line 979
Quoted 8 lines
drivers/gpu/drm/i2c/tda998x_drv.c +5
-0@@ -972,6 +972,11 @@ tda998x_encoder_mode_set(struct drm_encoder *encoder, } div =148500 / mode->clock; +if (div !=0 ) { + div--; +if (div >3 ) + div =3 ; + }
As the driver currently stands, we know that the clock divider works for the lower resolution modes. So, as things stand, for 74.25MHz modes, we get a divisor of one.
Your patch changes this, the divider becomes zero. I wonder whether you've tested 720p modes at all with this?
Signature · 3 lines
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit".
Quoted 11 lines · On Sat, 11 Jan 2014 18:26:02 +0000 Russell King - ARM Linux…
drivers/gpu/drm/i2c/tda998x_drv.c tda998x_encoder_mode_set(struct drm_encoder *encoder, · line 979
Quoted 6 lines
drivers/gpu/drm/i2c/tda998x_drv.c +5
-0div =148500 / mode->clock; +if (div !=0 ) { + div--; +if (div >3 ) + div =3 ; + }As the driver currently stands, we know that the clock divider works for the lower resolution modes. So, as things stand, for 74.25MHz modes, we get a divisor of one.
Quoted 2 lines
Your patch changes this, the divider becomes zero. I wonder whether you've tested 720p modes at all with this?
In 720p, the divider becomes (148500 / 74250 - 1) = 1 and this mode works fine.
Signature · 2 lines
Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/