i40e: potential array underflow in i40e_vc_process_vf_msg()

PATCH New Dan Carpenter 1 participant 1 message Jan 11, 2014

Subsystems (3)

Network drivers Kernel janitors Intel Ethernet

lore

Share & tools

lore

Dan Carpenter

author

2014-01-11 09:58 UTC #0 lore raw

PATCH v2 1/1 i40e: potential array underflow in i40e_vc_process_vf_msg()

If "vf_id" is smaller than hw->func_caps.vf_base_id then it leads to an array underflow of the pf->vf[] array. This is unlikely to happen unless the hardware is bad, but it's a small change and it silences a static checker warning.

Fixes 7efa84b7abc1 ('i40e: support VFs on PFs other than 0')

Signed-off-by Dan Carpenter <[email protected]>

---
v2: rebased. commit message updated.

drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +1 -1

index 51a4f6125437..b77d7e79d977 100644
@@ -1772,7 +1772,7 @@ int i40e_vc_process_vf_msg(struct i40e_pf *pf, u16 vf_id, u32 v_opcode,
 			   u32 v_retval, u8 *msg, u16 msglen)
 {
 	struct i40e_hw *hw = &pf->hw;
-	int local_vf_id = vf_id - hw->func_caps.vf_base_id;
+	unsigned int local_vf_id = vf_id - hw->func_caps.vf_base_id;
 	struct i40e_vf *vf;
 	int ret;