Skip to contentSkip to conversation

x86, kaslr: export offset in VMCOREINFO ELF notes

PATCH Superseded Kees Cook 2 participants 3 messages Jan 22, 2014 – Jan 23, 2014 x86

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 x86, kaslr: export offset in VMCOREINFO ELF notes

Include kASLR offset in VMCOREINFO ELF notes to assist in debugging.

---
 arch/x86/kernel/machine_kexec_64.c |    2 ++
 1 file changed, 2 insertions(+)
arch/x86/kernel/machine_kexec_64.c +2 -0
index 4eabc160696f..679cef0791cd 100644
@@ -279,5 +279,7 @@ void arch_crash_save_vmcoreinfo(void)
 	VMCOREINFO_SYMBOL(node_data);
 	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
 #endif
+	vmcoreinfo_append_str("KERNELOFFSET=%lx\n",
+			      (unsigned long)&_text - __START_KERNEL);
 }
 
Signature · 5 lines
1.7.9.5

-- 
Kees Cook
Chrome OS Security
author
#2 lore raw
Quoted 11 lines · Ingo Molnar
Quoted 4 lines · Kees Cook

Include kASLR offset in VMCOREINFO ELF notes to assist in debugging.

The signoff sequence is weird. If this came from Eugene then the patch is missing a From: line. If he reviewed or acked it then it should be a Reviewed-by or Acked-by tag.

Ah, yes, seems like the From: got removed by my MUA, I will resend.

-Kees

Signature · 2 lines
Kees Cook
Chrome OS Security