Skip to contentSkip to conversation

status of drivers/scsi/scsi_tgt_lib.c

DISCUSSION Christoph Hellwig 3 participants 7 messages Jan 24, 2014 – Jan 30, 2014 SCSI

lore
Share & tools
lore
#0 lore raw

Hi Tomo-san,

what is the status of scsi_tgt_lib.c? I've recently been auditing the command allocation and I/O path for various possible improvements, and the use of many functions in this path in addition to the normal initiator code path is going to make a few things a bit harder.

The code seems to not have seen any major changes since about 2008, and at least SRP hast another maintained target in mainline.

Do you know if either SRP or ibmvscsi are used regularly these days? Does tgtd userspace still support this interface?

#1 lore raw

Hey,

Quoted 2 lines · On Fri, 24 Jan 2014 05:15:25 -0800 Christoph Hellwig <[email protected]> wrote:

Do you know if either SRP or ibmvscsi are used regularly these days? Does tgtd userspace still support this interface?

It doesn't. I think that ibm pseries switched to virtual fc driver from virtual srp long ago. Only very old pseries could use the driver. I'm not sure there are any users of the driver. I guess that you could try to remove the driver to see if someone would complain.

#2 lore raw
Quoted 5 lines · FUJITA Tomonori

Hey,

On Fri, 24 Jan 2014 05:15:25 -0800
Christoph Hellwig <[email protected]> wrote:

Quoted 7 lines
Quoted 2 lines

Do you know if either SRP or ibmvscsi are used regularly these days? Does tgtd userspace still support this interface?

It doesn't. I think that ibm pseries switched to virtual fc driver from virtual srp long ago. Only very old pseries could use the driver. I'm not sure there are any users of the driver. I guess that you could try to remove the driver to see if someone would complain.

Should we try to throw in a deprecation warnings for this merge window and see if anyone cares, or go ahead and remove it entirely?

#3 lore raw
Quoted 10 lines · On Sun, 26 Jan 2014 23:50:38 -0800 Christoph Hellwig <[email protected]> wrote:
Quoted 7 lines
Quoted 2 lines

Do you know if either SRP or ibmvscsi are used regularly these days? Does tgtd userspace still support this interface?

It doesn't. I think that ibm pseries switched to virtual fc driver from virtual srp long ago. Only very old pseries could use the driver. I'm not sure there are any users of the driver. I guess that you could try to remove the driver to see if someone would complain.

Should we try to throw in a deprecation warnings for this merge window and see if anyone cares, or go ahead and remove it entirely?

Either is fine by me.

#4 lore raw
Quoted 11 lines · FUJITA Tomonori
Quoted 8 lines · On Sun, 26 Jan 2014 23:50:38 -0800 Christoph Hellwig <[email protected]> wrote:
Quoted 7 lines
Quoted 2 lines

Do you know if either SRP or ibmvscsi are used regularly these days? Does tgtd userspace still support this interface?

It doesn't. I think that ibm pseries switched to virtual fc driver from virtual srp long ago. Only very old pseries could use the driver. I'm not sure there are any users of the driver. I guess that you could try to remove the driver to see if someone would complain.

Quoted 4 lines
Quoted 2 lines

Should we try to throw in a deprecation warnings for this merge window and see if anyone cares, or go ahead and remove it entirely?

Either is fine by me.

I actually know of a customer using this (with a semi-proprietary target mode driver). I'll be asking him what his plans are.

Cheers,

Hannes

Signature · 8 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#5 lore raw
Quoted 2 lines · Hannes Reinecke

I actually know of a customer using this (with a semi-proprietary target mode driver). I'll be asking him what his plans are.

They are using the IBM pseries vscsi driver for that? It they actually adding out of tree kernel code it doesn't really matter at all for this discussion..

#6 lore raw
Quoted 8 lines · Christoph Hellwig
Quoted 2 lines · Hannes Reinecke

I actually know of a customer using this (with a semi-proprietary target mode driver). I'll be asking him what his plans are.

They are using the IBM pseries vscsi driver for that? It they actually adding out of tree kernel code it doesn't really matter at all for this discussion..

No, not the vscsi driver. But the tgt hooks.

But yeah, I know. As said, I'll be in touch with them. I just wanted mention that _someone_ uses this code

Cheers,

Hannes

Signature · 8 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html